From b1996e1ce812995ed7d939ba72394c5ad268d1bf Mon Sep 17 00:00:00 2001 From: Mohamed Metwalli <mohamed.metwalli@sap.com> Date: Wed, 13 Jan 2021 16:04:17 +0100 Subject: [PATCH] Resolve TODO and use ext function --- .../de/rki/coronawarnapp/ui/main/home/HomeFragmentTest.kt | 5 ++--- .../coronawarnapp/ui/tracing/TracingDetailsFragmentTest.kt | 3 ++- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Corona-Warn-App/src/androidTest/java/de/rki/coronawarnapp/ui/main/home/HomeFragmentTest.kt b/Corona-Warn-App/src/androidTest/java/de/rki/coronawarnapp/ui/main/home/HomeFragmentTest.kt index 16407e5e5..c2a342df7 100644 --- a/Corona-Warn-App/src/androidTest/java/de/rki/coronawarnapp/ui/main/home/HomeFragmentTest.kt +++ b/Corona-Warn-App/src/androidTest/java/de/rki/coronawarnapp/ui/main/home/HomeFragmentTest.kt @@ -1,6 +1,5 @@ package de.rki.coronawarnapp.ui.main.home -import androidx.fragment.app.testing.launchFragment import androidx.lifecycle.LiveData import androidx.lifecycle.MutableLiveData import androidx.test.espresso.Espresso.onView @@ -44,6 +43,7 @@ import testhelpers.SCREENSHOT_DELAY_TIME import testhelpers.Screenshot import testhelpers.SystemUIDemoModeRule import testhelpers.TestDispatcherProvider +import testhelpers.launchFragment2 import testhelpers.launchFragmentInContainer2 import testhelpers.recyclerScrollTo import timber.log.Timber @@ -99,8 +99,7 @@ class HomeFragmentTest : BaseUITest() { @Test fun onResumeCallsRefresh() { - // AppTheme is required here to prevent xml inflation crash - launchFragment<HomeFragment>(themeResId = R.style.AppTheme) + launchFragment2<HomeFragment>() verify(exactly = 1) { viewModel.refreshRequiredData() } } diff --git a/Corona-Warn-App/src/androidTest/java/de/rki/coronawarnapp/ui/tracing/TracingDetailsFragmentTest.kt b/Corona-Warn-App/src/androidTest/java/de/rki/coronawarnapp/ui/tracing/TracingDetailsFragmentTest.kt index 0a1084886..e22171727 100644 --- a/Corona-Warn-App/src/androidTest/java/de/rki/coronawarnapp/ui/tracing/TracingDetailsFragmentTest.kt +++ b/Corona-Warn-App/src/androidTest/java/de/rki/coronawarnapp/ui/tracing/TracingDetailsFragmentTest.kt @@ -25,6 +25,7 @@ import org.junit.Rule import org.junit.Test import org.junit.runner.RunWith import testhelpers.BaseUITest +import testhelpers.SCREENSHOT_DELAY_TIME import testhelpers.Screenshot import testhelpers.SystemUIDemoModeRule import testhelpers.TestDispatcherProvider @@ -120,7 +121,7 @@ class TracingDetailsFragmentTest : BaseUITest() { private fun captureScreenshot(nameSuffix: String) { val name = TracingDetailsFragment::class.simpleName + "_" + nameSuffix launchFragmentInContainer2<TracingDetailsFragment>() - Thread.sleep(2000) // TODO use constant when EXPOSUREAPP-2950 is merged + Thread.sleep(SCREENSHOT_DELAY_TIME) Screengrab.screenshot(name) } } -- GitLab