From e95ff837d1c9c1e204747452139c0ddce5a202de Mon Sep 17 00:00:00 2001 From: chris-cwa <69595386+chris-cwa@users.noreply.github.com> Date: Mon, 14 Sep 2020 14:51:53 +0200 Subject: [PATCH] Reverted replaced wording (EXPOSUREAPP-2638) (#1153) * Fix: No exposure with low risk so far * Fixed klint issues (#1144) * restored reverted replaced wording for lint * https://github.com/corona-warn-app/cwa-app-android/pull/1153#discussion_r487801724 * fixed term --- .../util/formatter/FormatterRiskHelper.kt | 2 +- Corona-Warn-App/src/main/res/values-bg/strings.xml | 2 -- Corona-Warn-App/src/main/res/values-de/strings.xml | 12 +++++------- Corona-Warn-App/src/main/res/values-en/strings.xml | 2 -- Corona-Warn-App/src/main/res/values-pl/strings.xml | 2 -- Corona-Warn-App/src/main/res/values-ro/strings.xml | 2 -- Corona-Warn-App/src/main/res/values-tr/strings.xml | 2 -- Corona-Warn-App/src/main/res/values/strings.xml | 2 -- .../coronawarnapp/util/CachedKeyFileHolderTest.kt | 1 - .../coronawarnapp/util/GoogleQuotaCalculatorTest.kt | 4 +--- .../util/formatter/FormatterRiskHelperTest.kt | 4 +--- 11 files changed, 8 insertions(+), 27 deletions(-) diff --git a/Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/formatter/FormatterRiskHelper.kt b/Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/formatter/FormatterRiskHelper.kt index 5c5fe1ffb..37730c60a 100644 --- a/Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/formatter/FormatterRiskHelper.kt +++ b/Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/formatter/FormatterRiskHelper.kt @@ -142,7 +142,7 @@ fun formatRiskContact(riskLevelScore: Int?, matchedKeysCount: Int?): String { } RiskLevelConstants.LOW_LEVEL_RISK -> { if (matchedKeysCount == 0) { - appContext.getString(R.string.risk_card_body_contact_low_risk) + appContext.getString(R.string.risk_card_body_contact) } else { resources.getQuantityString( R.plurals.risk_card_body_contact_value, diff --git a/Corona-Warn-App/src/main/res/values-bg/strings.xml b/Corona-Warn-App/src/main/res/values-bg/strings.xml index 2b99bd903..45c9faa6b 100644 --- a/Corona-Warn-App/src/main/res/values-bg/strings.xml +++ b/Corona-Warn-App/src/main/res/values-bg/strings.xml @@ -135,8 +135,6 @@ <!-- XTXT: risk card - no contact yet --> <string name="risk_card_body_contact">"До момента нÑма излагане на риÑк"</string> - <!-- XTXT: risk card - no exposures with low risk --> - <string name="risk_card_body_contact_low_risk">"До момента нÑма излагане на ниÑък риÑк"</string> <!-- XTXT: risk card - number of contacts for one or more --> <plurals name="risk_card_body_contact_value"> <item quantity="one">"%1$s излагане на ниÑък риÑк"</item> diff --git a/Corona-Warn-App/src/main/res/values-de/strings.xml b/Corona-Warn-App/src/main/res/values-de/strings.xml index 337569d67..0c8e4fc5a 100644 --- a/Corona-Warn-App/src/main/res/values-de/strings.xml +++ b/Corona-Warn-App/src/main/res/values-de/strings.xml @@ -135,16 +135,14 @@ <!-- XTXT: risk card - no contact yet --> <string name="risk_card_body_contact">"Bisher keine Risiko-Begegnungen"</string> - <!-- XTXT: risk card - no exposures with low risk --> - <string name="risk_card_body_contact_low_risk">"Bisher keine Begegnungen mit niedrigem Risiko"</string> <!-- XTXT: risk card - number of contacts for one or more --> <plurals name="risk_card_body_contact_value"> - <item quantity="one">"%1$s Risiko-Begegnung mit niedrigem Risiko"</item> - <item quantity="other">"%1$s Risiko-Begegnungen mit niedrigem Risiko"</item> + <item quantity="one">"%1$s Begegnung mit niedrigem Risiko"</item> + <item quantity="other">"%1$s Begegnungen mit niedrigem Risiko"</item> <item quantity="zero">"Bisher keine Begegnungen mit niedrigem Risiko"</item> - <item quantity="two">"%1$s Risiko-Begegnungen mit niedrigem Risiko"</item> - <item quantity="few">"%1$s Risiko-Begegnungen mit niedrigem Risiko"</item> - <item quantity="many">"%1$s Risiko-Begegnungen mit niedrigem Risiko"</item> + <item quantity="two">"%1$s Begegnungen mit niedrigem Risiko"</item> + <item quantity="few">"%1$s Begegnungen mit niedrigem Risiko"</item> + <item quantity="many">"%1$s Begegnungen mit niedrigem Risiko"</item> </plurals> <!-- XTXT: risk card - number of contacts for one or more --> <plurals name="risk_card_body_contact_value_high_risk"> diff --git a/Corona-Warn-App/src/main/res/values-en/strings.xml b/Corona-Warn-App/src/main/res/values-en/strings.xml index 830860d2c..005b2a931 100644 --- a/Corona-Warn-App/src/main/res/values-en/strings.xml +++ b/Corona-Warn-App/src/main/res/values-en/strings.xml @@ -135,8 +135,6 @@ <!-- XTXT: risk card - no contact yet --> <string name="risk_card_body_contact">"No exposure up to now"</string> - <!-- XTXT: risk card - no exposures with low risk --> - <string name="risk_card_body_contact_low_risk">"No exposure with low risk so far"</string> <!-- XTXT: risk card - number of contacts for one or more --> <plurals name="risk_card_body_contact_value"> <item quantity="one">"%1$s exposure with low risk"</item> diff --git a/Corona-Warn-App/src/main/res/values-pl/strings.xml b/Corona-Warn-App/src/main/res/values-pl/strings.xml index d3faa61b4..fdf867dd9 100644 --- a/Corona-Warn-App/src/main/res/values-pl/strings.xml +++ b/Corona-Warn-App/src/main/res/values-pl/strings.xml @@ -135,8 +135,6 @@ <!-- XTXT: risk card - no contact yet --> <string name="risk_card_body_contact">"Brak narażenia do tej pory"</string> - <!-- XTXT: risk card - no exposures with low risk --> - <string name="risk_card_body_contact_low_risk">"Brak narażenia z niskim ryzykiem do tej pory"</string> <!-- XTXT: risk card - number of contacts for one or more --> <plurals name="risk_card_body_contact_value"> <item quantity="one">"%1$s narażenie z niskim ryzykiem"</item> diff --git a/Corona-Warn-App/src/main/res/values-ro/strings.xml b/Corona-Warn-App/src/main/res/values-ro/strings.xml index 13535ea50..62cf4a4e0 100644 --- a/Corona-Warn-App/src/main/res/values-ro/strings.xml +++ b/Corona-Warn-App/src/main/res/values-ro/strings.xml @@ -135,8 +135,6 @@ <!-- XTXT: risk card - no contact yet --> <string name="risk_card_body_contact">"Nicio expunere până acum"</string> - <!-- XTXT: risk card - no exposures with low risk --> - <string name="risk_card_body_contact_low_risk">"Nicio expunere cu risc redus până acum"</string> <!-- XTXT: risk card - number of contacts for one or more --> <plurals name="risk_card_body_contact_value"> <item quantity="one">"%1$s expunere cu risc redus"</item> diff --git a/Corona-Warn-App/src/main/res/values-tr/strings.xml b/Corona-Warn-App/src/main/res/values-tr/strings.xml index 844fd6e2b..98808553c 100644 --- a/Corona-Warn-App/src/main/res/values-tr/strings.xml +++ b/Corona-Warn-App/src/main/res/values-tr/strings.xml @@ -135,8 +135,6 @@ <!-- XTXT: risk card - no contact yet --> <string name="risk_card_body_contact">"Åžu ana dek hiçbir maruz kalma yok"</string> - <!-- XTXT: risk card - no exposures with low risk --> - <string name="risk_card_body_contact_low_risk">"Åžu ana dek hiçbir düşük riskli maruz kalma yok"</string> <!-- XTXT: risk card - number of contacts for one or more --> <plurals name="risk_card_body_contact_value"> <item quantity="one">"%1$s kez düşük riskli maruz kalma"</item> diff --git a/Corona-Warn-App/src/main/res/values/strings.xml b/Corona-Warn-App/src/main/res/values/strings.xml index 92fcc4795..135dfaf5e 100644 --- a/Corona-Warn-App/src/main/res/values/strings.xml +++ b/Corona-Warn-App/src/main/res/values/strings.xml @@ -137,8 +137,6 @@ <!-- XTXT: risk card - no contact yet --> <string name="risk_card_body_contact">"No exposure up to now"</string> - <!-- XTXT: risk card - no exposures with low risk --> - <string name="risk_card_body_contact_low_risk">"No exposure with low risk so far"</string> <!-- XTXT: risk card - number of contacts for one or more --> <plurals name="risk_card_body_contact_value"> <item quantity="one">"%1$s exposure with low risk"</item> diff --git a/Corona-Warn-App/src/test/java/de/rki/coronawarnapp/util/CachedKeyFileHolderTest.kt b/Corona-Warn-App/src/test/java/de/rki/coronawarnapp/util/CachedKeyFileHolderTest.kt index 607077c1a..b03e57dd7 100644 --- a/Corona-Warn-App/src/test/java/de/rki/coronawarnapp/util/CachedKeyFileHolderTest.kt +++ b/Corona-Warn-App/src/test/java/de/rki/coronawarnapp/util/CachedKeyFileHolderTest.kt @@ -53,7 +53,6 @@ class CachedKeyFileHolderTest { every { CachedKeyFileHolder["checkForFreeSpace"]() } returns Unit every { CachedKeyFileHolder["getDatesFromServer"]() } returns arrayListOf<String>() - runBlocking { CachedKeyFileHolder.asyncFetchFiles(date) diff --git a/Corona-Warn-App/src/test/java/de/rki/coronawarnapp/util/GoogleQuotaCalculatorTest.kt b/Corona-Warn-App/src/test/java/de/rki/coronawarnapp/util/GoogleQuotaCalculatorTest.kt index c60f9ed7d..1a506b0cd 100644 --- a/Corona-Warn-App/src/test/java/de/rki/coronawarnapp/util/GoogleQuotaCalculatorTest.kt +++ b/Corona-Warn-App/src/test/java/de/rki/coronawarnapp/util/GoogleQuotaCalculatorTest.kt @@ -54,7 +54,6 @@ internal class GoogleQuotaCalculatorTest { every { LocalData.googleAPIProvideDiagnosisKeysCallCount } answers { googleAPIProvideDiagnosisKeysCallCount.get() } - } @Test @@ -278,7 +277,6 @@ internal class GoogleQuotaCalculatorTest { val testTimeGMTAfterUTC = testTimeGMT.plusMinutes(1) assertEquals(true, testTimeGMTAfterUTC.isAfter(testTimeUTC)) - } @After @@ -286,4 +284,4 @@ internal class GoogleQuotaCalculatorTest { DateTimeUtils.setCurrentMillisSystem() unmockkObject(LocalData) } -} \ No newline at end of file +} diff --git a/Corona-Warn-App/src/test/java/de/rki/coronawarnapp/util/formatter/FormatterRiskHelperTest.kt b/Corona-Warn-App/src/test/java/de/rki/coronawarnapp/util/formatter/FormatterRiskHelperTest.kt index 3240d2c3e..76cdd3647 100644 --- a/Corona-Warn-App/src/test/java/de/rki/coronawarnapp/util/formatter/FormatterRiskHelperTest.kt +++ b/Corona-Warn-App/src/test/java/de/rki/coronawarnapp/util/formatter/FormatterRiskHelperTest.kt @@ -95,7 +95,6 @@ class FormatterRiskHelperTest { private fun formatRiskContactBase(iRiskLevelScore: Int?, iMatchedKeysCount: Int?, sValue: String) { every { context.getString(R.string.risk_card_body_contact) } returns R.string.risk_card_body_contact.toString() - every { context.getString(R.string.risk_card_body_contact_low_risk) } returns R.string.risk_card_body_contact_low_risk.toString() val result = formatRiskContact(riskLevelScore = iRiskLevelScore, matchedKeysCount = iMatchedKeysCount) assertThat( @@ -105,7 +104,6 @@ class FormatterRiskHelperTest { private fun formatRiskContactLastBase(iRiskLevelScore: Int?, iDaysSinceLastExposure: Int?, sValue: String) { every { context.getString(R.string.risk_card_body_contact) } returns R.string.risk_card_body_contact.toString() - every { context.getString(R.string.risk_card_body_contact_low_risk) } returns R.string.risk_card_body_contact_low_risk.toString() val result = formatRiskContactLast(riskLevelScore = iRiskLevelScore, daysSinceLastExposure = iDaysSinceLastExposure) @@ -602,7 +600,7 @@ class FormatterRiskHelperTest { formatRiskContactBase( iRiskLevelScore = RiskLevelConstants.LOW_LEVEL_RISK, iMatchedKeysCount = 0, - sValue = context.getString(R.string.risk_card_body_contact_low_risk) + sValue = context.getString(R.string.risk_card_body_contact) ) formatRiskContactBase( iRiskLevelScore = RiskLevelConstants.LOW_LEVEL_RISK, -- GitLab