-
harambasicluka authored* changes PR template, removed checkboxes and added new points * added: link issues * Update pull_request_template.md * Update pull_request_template.md * Update pull_request_template.md * added acceptance criteria for maintainers * fixed typo * + maintainers link github issues Co-authored-by:
Matthias Urhahn <darken@darken.eu>harambasicluka authored* changes PR template, removed checkboxes and added new points * added: link issues * Update pull_request_template.md * Update pull_request_template.md * Update pull_request_template.md * added acceptance criteria for maintainers * fixed typo * + maintainers link github issues Co-authored-by:Matthias Urhahn <darken@darken.eu>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.
pull_request_template.md 2.50 KiB
Checklist
Thank you for this this PR! Please consider the following:
- To the Community :heart::
- Please link to an issue ticket where your code change has been greenlit, otherwise it's unlikely it can be merged.
- Use a descriptive title: {task_name} (closes #{issue_number}), e.g.:
Use logger (closes # 41). - If this PR comes from a fork, please Allow edits from maintainers
- The PR can not contain changes in localization files, e.g.
values-[LANGUAGE-CODE]/strings/*and/orassets/*(see #332 for further information).
- To the Maintainers :coffee::
- Title structure:
Jira ticket name (EXPOSUREAPP-XXXX). - Set labels:
maintainers,sprintX. - Update Jira status:
In Review. - Fulfill internal
Acceptance Criteria. - If mentioned in the Jira ticket link all corresponding GitHub issues in the sidebar.
- Title structure:
- To everyone :world_map::
- Describe your changes in detail, if you changed the UI, screenshots or GIFs would be awesome!
- Short step by step instructions help the reviewer test your changes, e.g. how to navigate to a new UI element you added.
- The PR won't be reviewed if CircleCi is failing or if there are merge conflicts. If Circle CI is still failing mark the PR as a draft and write a little comment on your status.
- Provide at least a few unit and/or instrumentation tests.
- Use a meaning full branch name. Use either
fixorfeatureas prefix for your branch, e.g.fix/prevent-npe-on-device-rotation-issue_123 - Test your changes thoroughly. Only open PRs which you think is ready to be merged. If you explicitly need feedback mark the PR as
DRAFTon Github. - Don't introduce unrelated code reformatting (e.g., on-save hooks in your IDE)
- Remove this checklist before creating your pull request.