QR Code stricter validation (EXPOSUREAPP-2570) (#1127)
* test for OnboardingFragment * QR code stricter validations * regex pattern improvement * removed Obsolete test * lint changes to fix pipeline issue * logic refinement and test coverage improvement * pipeline related fixes * piepline related fixes : unnecessary test removed * pipeline fixes and increased tests coverage * QR code validation logic improvement * detekt pipeline issue resolved * pipeline issue Fix * logic ovehaul and improvement for QRCode scans / validations 1, Data object for ScanResults 2. new Test for ScanResults 3. logic simplified * removing unused imports from tests * Small refactoring together with Rituraj. * Adjust detekt, early abort via return is GOOD! Co-authored-by:Matthias Urhahn <darken@darken.eu> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
Showing
- Corona-Warn-App/config/detekt.yml 1 addition, 1 deletionCorona-Warn-App/config/detekt.yml
- Corona-Warn-App/src/main/java/de/rki/coronawarnapp/service/submission/QRScanResult.kt 32 additions, 0 deletions...a/de/rki/coronawarnapp/service/submission/QRScanResult.kt
- Corona-Warn-App/src/main/java/de/rki/coronawarnapp/service/submission/SubmissionConstants.kt 0 additions, 4 deletions...i/coronawarnapp/service/submission/SubmissionConstants.kt
- Corona-Warn-App/src/main/java/de/rki/coronawarnapp/service/submission/SubmissionService.kt 2 additions, 11 deletions...rki/coronawarnapp/service/submission/SubmissionService.kt
- Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/viewmodel/SubmissionViewModel.kt 5 additions, 4 deletions.../de/rki/coronawarnapp/ui/viewmodel/SubmissionViewModel.kt
- Corona-Warn-App/src/test/java/de/rki/coronawarnapp/service/submission/ScanResultTest.kt 54 additions, 0 deletions...de/rki/coronawarnapp/service/submission/ScanResultTest.kt
- Corona-Warn-App/src/test/java/de/rki/coronawarnapp/service/submission/SubmissionConstantsTest.kt 7 additions, 4 deletions...ronawarnapp/service/submission/SubmissionConstantsTest.kt
- Corona-Warn-App/src/test/java/de/rki/coronawarnapp/service/submission/SubmissionServiceTest.kt 0 additions, 22 deletions...coronawarnapp/service/submission/SubmissionServiceTest.kt
- Corona-Warn-App/src/test/java/de/rki/coronawarnapp/ui/viewmodel/SubmissionViewModelTest.kt 1 addition, 1 deletion...rki/coronawarnapp/ui/viewmodel/SubmissionViewModelTest.kt
Loading
Please register or sign in to comment