Skip to content
Snippets Groups Projects
Unverified Commit 0e5e9fc5 authored by Matthias Urhahn's avatar Matthias Urhahn Committed by GitHub
Browse files

Change LINT check for "LongMethod" from 60 to 120 lines. (#2047)

Long methods are not generally bad and should be decided on a case by case basis in PR reviews.
parent e6a05201
No related branches found
No related tags found
No related merge requests found
...@@ -77,7 +77,7 @@ complexity: ...@@ -77,7 +77,7 @@ complexity:
threshold: 600 threshold: 600
LongMethod: LongMethod:
active: true active: true
threshold: 60 threshold: 120
LongParameterList: LongParameterList:
active: true active: true
functionThreshold: 6 functionThreshold: 6
......
...@@ -25,7 +25,6 @@ import timber.log.Timber ...@@ -25,7 +25,6 @@ import timber.log.Timber
import java.io.File import java.io.File
import javax.inject.Inject import javax.inject.Inject
@Suppress("LongMethod")
class TestRiskLevelCalculationFragment : Fragment(R.layout.fragment_test_risk_level_calculation), class TestRiskLevelCalculationFragment : Fragment(R.layout.fragment_test_risk_level_calculation),
AutoInject { AutoInject {
private val navArgs by navArgs<TestRiskLevelCalculationFragmentArgs>() private val navArgs by navArgs<TestRiskLevelCalculationFragmentArgs>()
......
...@@ -16,7 +16,6 @@ import de.rki.coronawarnapp.util.viewmodel.cwaViewModels ...@@ -16,7 +16,6 @@ import de.rki.coronawarnapp.util.viewmodel.cwaViewModels
import javax.inject.Inject import javax.inject.Inject
@SuppressLint("SetTextI18n") @SuppressLint("SetTextI18n")
@Suppress("LongMethod")
class TestTaskControllerFragment : Fragment(R.layout.fragment_test_task_controller), AutoInject { class TestTaskControllerFragment : Fragment(R.layout.fragment_test_task_controller), AutoInject {
@Inject lateinit var viewModelFactory: CWAViewModelFactoryProvider.Factory @Inject lateinit var viewModelFactory: CWAViewModelFactoryProvider.Factory
......
...@@ -39,7 +39,6 @@ class DownloadDiagnosisKeysTask @Inject constructor( ...@@ -39,7 +39,6 @@ class DownloadDiagnosisKeysTask @Inject constructor(
private var isCanceled = false private var isCanceled = false
@Suppress("LongMethod")
override suspend fun run(arguments: Task.Arguments): Task.Result { override suspend fun run(arguments: Task.Arguments): Task.Result {
val rollbackItems = mutableListOf<RollbackItem>() val rollbackItems = mutableListOf<RollbackItem>()
try { try {
......
...@@ -13,7 +13,6 @@ import java.util.Locale ...@@ -13,7 +13,6 @@ import java.util.Locale
class ErrorReportReceiver(private val activity: Activity) : BroadcastReceiver() { class ErrorReportReceiver(private val activity: Activity) : BroadcastReceiver() {
@Suppress("LongMethod")
override fun onReceive(context: Context, intent: Intent) { override fun onReceive(context: Context, intent: Intent) {
val category = ExceptionCategory val category = ExceptionCategory
.valueOf(intent.getStringExtra(ReportingConstants.ERROR_REPORT_CATEGORY_EXTRA) ?: "") .valueOf(intent.getStringExtra(ReportingConstants.ERROR_REPORT_CATEGORY_EXTRA) ?: "")
......
...@@ -48,7 +48,6 @@ class RiskLevelTask @Inject constructor( ...@@ -48,7 +48,6 @@ class RiskLevelTask @Inject constructor(
private var isCanceled = false private var isCanceled = false
@Suppress("LongMethod")
override suspend fun run(arguments: Task.Arguments): RiskLevelTaskResult = try { override suspend fun run(arguments: Task.Arguments): RiskLevelTaskResult = try {
Timber.d("Running with arguments=%s", arguments) Timber.d("Running with arguments=%s", arguments)
......
...@@ -47,7 +47,6 @@ class HomeFragment : Fragment(R.layout.home_fragment_layout), AutoInject { ...@@ -47,7 +47,6 @@ class HomeFragment : Fragment(R.layout.home_fragment_layout), AutoInject {
private val homeAdapter = HomeAdapter() private val homeAdapter = HomeAdapter()
@Suppress("LongMethod")
override fun onViewCreated(view: View, savedInstanceState: Bundle?) { override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
super.onViewCreated(view, savedInstanceState) super.onViewCreated(view, savedInstanceState)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment