Skip to content
Snippets Groups Projects
Unverified Commit b97d44b6 authored by Matthias Urhahn's avatar Matthias Urhahn Committed by GitHub
Browse files

Fix flaky "onTestOpened" PPA unit-test (DEV) (#3140)


* Pass dispatcher provider to run synchronous in unit tests.

* Update SubmissionTestResultNoConsentGivenFragmentTest.kt

Co-authored-by: default avatarMohamed Metwalli <mohamed.metwalli@sap.com>
parent 9a7438d6
No related branches found
No related tags found
No related merge requests found
...@@ -27,6 +27,7 @@ import org.junit.runner.RunWith ...@@ -27,6 +27,7 @@ import org.junit.runner.RunWith
import testhelpers.BaseUITest import testhelpers.BaseUITest
import testhelpers.Screenshot import testhelpers.Screenshot
import testhelpers.SystemUIDemoModeRule import testhelpers.SystemUIDemoModeRule
import testhelpers.TestDispatcherProvider
import testhelpers.captureScreenshot import testhelpers.captureScreenshot
import tools.fastlane.screengrab.locale.LocaleTestRule import tools.fastlane.screengrab.locale.LocaleTestRule
...@@ -55,6 +56,7 @@ class SubmissionTestResultNoConsentGivenFragmentTest : BaseUITest() { ...@@ -55,6 +56,7 @@ class SubmissionTestResultNoConsentGivenFragmentTest : BaseUITest() {
viewModel = viewModel =
spyk( spyk(
SubmissionTestResultNoConsentViewModel( SubmissionTestResultNoConsentViewModel(
TestDispatcherProvider(),
submissionRepository, submissionRepository,
testResultAvailableNotificationService, testResultAvailableNotificationService,
analyticsKeySubmissionCollector, analyticsKeySubmissionCollector,
......
...@@ -12,6 +12,7 @@ import de.rki.coronawarnapp.datadonation.analytics.modules.keysubmission.Analyti ...@@ -12,6 +12,7 @@ import de.rki.coronawarnapp.datadonation.analytics.modules.keysubmission.Analyti
import de.rki.coronawarnapp.datadonation.analytics.modules.keysubmission.Screen import de.rki.coronawarnapp.datadonation.analytics.modules.keysubmission.Screen
import de.rki.coronawarnapp.submission.SubmissionRepository import de.rki.coronawarnapp.submission.SubmissionRepository
import de.rki.coronawarnapp.ui.submission.testresult.TestResultUIState import de.rki.coronawarnapp.ui.submission.testresult.TestResultUIState
import de.rki.coronawarnapp.util.coroutine.DispatcherProvider
import de.rki.coronawarnapp.util.viewmodel.CWAViewModel import de.rki.coronawarnapp.util.viewmodel.CWAViewModel
import de.rki.coronawarnapp.util.viewmodel.CWAViewModelFactory import de.rki.coronawarnapp.util.viewmodel.CWAViewModelFactory
import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.Dispatchers
...@@ -20,11 +21,12 @@ import kotlinx.coroutines.flow.map ...@@ -20,11 +21,12 @@ import kotlinx.coroutines.flow.map
import timber.log.Timber import timber.log.Timber
class SubmissionTestResultNoConsentViewModel @AssistedInject constructor( class SubmissionTestResultNoConsentViewModel @AssistedInject constructor(
dispatcherProvider: DispatcherProvider,
private val submissionRepository: SubmissionRepository, private val submissionRepository: SubmissionRepository,
private val testResultAvailableNotificationService: PCRTestResultAvailableNotificationService, private val testResultAvailableNotificationService: PCRTestResultAvailableNotificationService,
private val analyticsKeySubmissionCollector: AnalyticsKeySubmissionCollector, private val analyticsKeySubmissionCollector: AnalyticsKeySubmissionCollector,
@Assisted private val testType: CoronaTest.Type @Assisted private val testType: CoronaTest.Type
) : CWAViewModel() { ) : CWAViewModel(dispatcherProvider = dispatcherProvider) {
init { init {
Timber.v("init() coronaTestType=%s", testType) Timber.v("init() coronaTestType=%s", testType)
} }
......
...@@ -13,6 +13,7 @@ import io.mockk.verify ...@@ -13,6 +13,7 @@ import io.mockk.verify
import org.junit.jupiter.api.BeforeEach import org.junit.jupiter.api.BeforeEach
import org.junit.jupiter.api.Test import org.junit.jupiter.api.Test
import testhelpers.BaseTest import testhelpers.BaseTest
import testhelpers.TestDispatcherProvider
internal class SubmissionTestResultNoConsentViewModelTest : BaseTest() { internal class SubmissionTestResultNoConsentViewModelTest : BaseTest() {
...@@ -26,6 +27,7 @@ internal class SubmissionTestResultNoConsentViewModelTest : BaseTest() { ...@@ -26,6 +27,7 @@ internal class SubmissionTestResultNoConsentViewModelTest : BaseTest() {
} }
private fun createInstance(testType: Type) = SubmissionTestResultNoConsentViewModel( private fun createInstance(testType: Type) = SubmissionTestResultNoConsentViewModel(
TestDispatcherProvider(),
submissionRepository, submissionRepository,
testResultAvailableNotificationService, testResultAvailableNotificationService,
analyticsKeySubmissionCollector, analyticsKeySubmissionCollector,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment