Fix missing error dialog (DEV) (#1564)

* Fix task exceptions not being forwarded to our current error UI elements.

* Clean up old transaction names.

* Use simple class name as error tag.

* Prevent error reporting from triggering in unit tests due to static access.

* Move isUnitTest to CWDebug

Co-authored-by: harambasicluka <64483219+harambasicluka@users.noreply.github.com>

Corona-Warn-App/src/main/java/de/rki/coronawarnapp/bugreporting/BugReporter.kt

 package de.rki.coronawarnapp.bugreporting
 
+import de.rki.coronawarnapp.util.CWADebug
 import de.rki.coronawarnapp.util.di.AppInjector
 
 interface BugReporter {
@@ -7,6 +8,7 @@ interface BugReporter {
 }
 
 fun Throwable.reportProblem(tag: String? = null, info: String? = null) {
+    if (CWADebug.isAUnitTest) return
     val reporter = AppInjector.component.bugReporter
     reporter.report(this, tag, info)
 }

Corona-Warn-App/src/main/java/de/rki/coronawarnapp/exception/reporting/ExceptionReporter.kt

@@ -10,6 +10,7 @@ import de.rki.coronawarnapp.exception.ExceptionCategory
 import de.rki.coronawarnapp.exception.reporting.ReportingConstants.STATUS_CODE_GOOGLE_API_FAIL
 import de.rki.coronawarnapp.exception.reporting.ReportingConstants.STATUS_CODE_GOOGLE_UPDATE_NEEDED
 import de.rki.coronawarnapp.exception.reporting.ReportingConstants.STATUS_CODE_REACHED_REQUEST_LIMIT
+import de.rki.coronawarnapp.util.CWADebug
 import de.rki.coronawarnapp.util.tryFormattedError
 import java.io.PrintWriter
 import java.io.StringWriter
@@ -22,6 +23,8 @@ fun Throwable.report(
     prefix: String?,
     suffix: String?
 ) {
+    if (CWADebug.isAUnitTest) return
+
     reportProblem(tag = prefix, info = suffix)
     val context = CoronaWarnApplication.getAppContext()
 

Corona-Warn-App/src/main/java/de/rki/coronawarnapp/task/TaskController.kt

 package de.rki.coronawarnapp.task
 
 import androidx.annotation.VisibleForTesting
+import de.rki.coronawarnapp.bugreporting.reportProblem
+import de.rki.coronawarnapp.exception.ExceptionCategory
+import de.rki.coronawarnapp.exception.reporting.report
 import de.rki.coronawarnapp.task.TaskFactory.Config.CollisionBehavior
 import de.rki.coronawarnapp.task.internal.InternalTaskState
 import de.rki.coronawarnapp.util.TimeStamper
@@ -147,6 +150,8 @@ class TaskController @Inject constructor(
                     state.job.getCompleted()
                 } else {
                     Timber.tag(TAG).e(error, "Task failed: %s", state)
+                    error.report(ExceptionCategory.INTERNAL)
+                    error.reportProblem(tag = state.request.type.simpleName)
                     null
                 }
 

Corona-Warn-App/src/main/java/de/rki/coronawarnapp/transaction/TransactionCoroutineScope.kt → Corona-Warn-App/src/main/java/de/rki/coronawarnapp/task/internal/DefaultTaskCoroutineScope.kt

-package de.rki.coronawarnapp.transaction
+package de.rki.coronawarnapp.task.internal
 
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Dispatchers
@@ -8,6 +8,6 @@ import javax.inject.Singleton
 import kotlin.coroutines.CoroutineContext
 
 @Singleton
-class TransactionCoroutineScope @Inject constructor() : CoroutineScope {
+class DefaultTaskCoroutineScope @Inject constructor() : CoroutineScope {
     override val coroutineContext: CoroutineContext = SupervisorJob() + Dispatchers.Default
 }

Corona-Warn-App/src/main/java/de/rki/coronawarnapp/task/internal/TaskModule.kt

@@ -4,7 +4,6 @@ import dagger.Module
 import dagger.Provides
 import de.rki.coronawarnapp.task.TaskCoroutineScope
 import de.rki.coronawarnapp.task.example.QueueingTaskModule
-import de.rki.coronawarnapp.transaction.TransactionCoroutineScope
 import kotlinx.coroutines.CoroutineScope
 import javax.inject.Singleton
 
@@ -17,5 +16,5 @@ class TaskModule {
     @Provides
     @Singleton
     @TaskCoroutineScope
-    fun provideScope(scope: TransactionCoroutineScope): CoroutineScope = scope
+    fun provideScope(scope: DefaultTaskCoroutineScope): CoroutineScope = scope
 }

Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/CWADebug.kt

@@ -31,4 +31,13 @@ object CWADebug {
         DEVICE("device"),
         DEVICE_FOR_TESTERS("deviceForTesters")
     }
+
+    val isAUnitTest: Boolean by lazy {
+        try {
+            Class.forName("testhelpers.IsAUnitTest")
+            true
+        } catch (e: Exception) {
+            false
+        }
+    }
 }

Corona-Warn-App/src/test/java/testhelpers/IsAUnitTest.kt

+package testhelpers
+
+class IsAUnitTest