Skip to content
Snippets Groups Projects
Unverified Commit e33f6e14 authored by Mike McCready's avatar Mike McCready Committed by GitHub
Browse files

Correct pull-request-template minor typos (COMMUNITY) (#2848)

parent bc60bf8d
No related branches found
No related tags found
No related merge requests found
...@@ -25,8 +25,8 @@ __Thank you for this this PR! Please consider the following:__ ...@@ -25,8 +25,8 @@ __Thank you for this this PR! Please consider the following:__
* Short step by step instructions help the reviewer test your changes, e.g. how to navigate to a new UI element you added. * Short step by step instructions help the reviewer test your changes, e.g. how to navigate to a new UI element you added.
* The PR _won't be reviewed_ if CircleCi is failing or if there are merge conflicts. If Circle CI is still failing mark the PR as a draft and write a little comment on your status. * The PR _won't be reviewed_ if CircleCi is failing or if there are merge conflicts. If Circle CI is still failing mark the PR as a draft and write a little comment on your status.
* Provide at least a few unit and/or instrumentation tests. * Provide at least a few unit and/or instrumentation tests.
* Use a meaning full branch name. Use either `fix` or `feature` as prefix for your branch, e.g. `fix/prevent-npe-on-device-rotation-issue_123` * Use a meaningful branch name. Use either `fix` or `feature` as prefix for your branch, e.g. `fix/prevent-npe-on-device-rotation-issue_123`
* Test your changes thoroughly. Only open PRs which you think is ready to be merged. If you explicitly need feedback mark the PR as `DRAFT` on Github. * Test your changes thoroughly. Only open PRs which you think is ready to be merged. If you explicitly need feedback mark the PR as `DRAFT` on GitHub.
* Don't introduce unrelated code reformatting (e.g., on-save hooks in your IDE) * Don't introduce unrelated code reformatting (e.g., on-save hooks in your IDE)
* Remove this checklist before creating your pull request. * Remove this checklist before creating your pull request.
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment