- Nov 11, 2020
-
-
Matthias Urhahn authored
* If we revoked any cached keys we need to force an index lookup. + Additional tests to check that forced index lookup is decided on correctly. * Fix merge regressions in tests.
-
Matthias Urhahn authored
The timeout checker doesn't need to force an app-config refresh, it's fine working with the latest available one. (#1573) Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
Matthias Urhahn authored
* Show more specific error message when quota limit is reached and remove "Update ever 24h text". * Show custom title in error dialog and make stack trace selectable. * LINTs * Add a log statement so that in all cases the the base error reporting is made visible. Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
Rituraj Sambherao authored
* improved logging for Bakcground Worker * loggin added in updateRiskLevelScore Notification Permissions logged and notification sent is loggged * merge conflict resolution * uniformity in Log tags Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
CWA Technical User authored
* Update from https://github.com/corona-warn-app/cwa-protocol-buffers/commit/9586b423837c598edc76c2ddf08baebcce1b1c36 * Adjust API to new protobuf names. Update default config. * Adjust function naming invalid -> revoked. Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Matthias Urhahn authored
* Replaced KeyFileDownloader.kt in favor of KeyFileSyncTool.kt. Supports new logic for more frequent downloads First draft. * Change "country" to location, which is more fitting. * Split sync success tracking into days and hours, track them separately. * Fix stale location data not being cleaned up. * Test fragment, first drafts. Remove 24 hour mode options, no longer used. * Implemented metered connection check for hourly key download. * Provide timeout values for download transaction and individual downloads via app config. * Add clear+download actions, and current network state display to the key download test fragment. * Complete unit tests for KeyDownloadTool.kt * Complete unit tests for FlowPreference and DownloadConfigMapper- * Unit tests for day and hour sync tool. * Complete tests for KeyPackageSyncTool.kt * klint & detekt <3 * Fix tags and commented out code (the deletion behavior is covered by `getting completed keys` * Fix text typo. * Sync tools need to tell what (if) new packages have been downloaded. * Interval checks for exposure detection. * Use the ENFClient, avoid direct access to the calculation tracker. * Remove defensive check "wanted countries"/"available countries" to reduce server hits. * CalculationTracker's timeout should come from the AppConfig (androidExposureDetectionParameters.overallTimeoutInSeconds) * Add test to confirm that we delete stale locations. * Finished key packages test screen. Introduced some boilerplate code to make async diffutils easier to use (will help us with the homefragment later on). * Remove ETag fallback behavior, missing ETag is such an edge case that we should throw. * Check valid max and min config values. * Fix linting issues. * Address PR comments. * EXPECT_NEW_*_PACKAGES should be based on the package time data, not the download creation timestamp. The downloads creation timestamp can be subject to race conditions. * Fix overflow due to time addition with Long.MAX_VALUE * Clean up tests * Don't crash the task if we can't get today's hour index. (Makes timetravel testing difficult, and a real abort reason would be a crash on the day index) * Display errors (don't crash) when running manual keysync from the test menu. * Fix last day/hour sync result success state not being updated. * Change Key download task collision mode from ENQUEUE to SKIP_IF_SIBLING_RUNNING. * Rename CalculationTracker to ExposureDetectionTracker * Rename `forceSync` to `forceIndexLookup`. * Remove outdated comments. * Spell out viewholder. * Move `maxExposureDetectionsPerUTCDay == 0` into it's own check. * Change test menu metered connection button behavior. It's now a button that "fakes" the connection status to metered. It's now also part of the `TestSettings` and the connection state is faked for the `NetworkStateProvider` class which may be reused. * Change test menu metered connection button behavior. It's now a button that "fakes" the connection status to metered. It's now also part of the `TestSettings` and the connection state is faked for the `NetworkStateProvider` class which may be reused. * Dry sync/error logging call. * Improve parameter naming, it's target locations, not available locations. The app config alone determines which locations we try to sync. Co-authored-by:
BMItter <46747780+BMItter@users.noreply.github.com>
-
Matthias Urhahn authored
* Fix task exceptions not being forwarded to our current error UI elements. * Clean up old transaction names. * Use simple class name as error tag. * Prevent error reporting from triggering in unit tests due to static access. * Move isUnitTest to CWDebug Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
- Nov 10, 2020
-
-
Matthias Urhahn authored
* Add default app config as last resort fallback. * Change config type names and improve logging for HotDataFlow.kt * Run the app config retrieval on the app scope, otherwise UI unsubscription could cancel the app config retrieval. * Offer "identifier" property that can identify app configs such that subscribers know when it is considered changed. * Behavior change AppConfigProvider.kt, there is no caching/replay grace period, once the last subscription is gone, it's last value is cleared. * Klint ;) * Add a unit test specifically for checking the default configs checkum and parsability. * Fix test breaking on CI. * Don't check the checksum for the config loaded from assets. Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
Ralf Gehrer authored
* Update EN SDK to 1.7.2 (EXPOSUREAPP-3662) * Upgrade Work Manager dependencies Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
Ralf Gehrer authored
* Extend NotificationHelper with functionality to schedule repeating notifications. * Enable cancelation of recurring notifications * Only show two positive test reminders * Implement proper positive test result reminder triggers * please ktlint * Reset notification on app reset via settings * Extract positive test result notification logic in an injectable service * Add tests * Fix injection issue of NotificationReceiver * Reset states of the SubmissionRepository on app reset via settings menu * Fix ktlint issue * add more logs Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
janetback authored
-
Oliver Zimmerman authored
* Small change to check length of TAN before checking it's validity * Unit test adjustment to reflect changes. * Adjusted comparison to use less than operator. Additional tests. * Seperated tan valid and tan length check fore better readibility. Adjusted tests * lint fix * use new isCorrectLength in isTanValidFormat Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
- Nov 09, 2020
-
-
janetback authored
Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
AlexanderAlferov authored
* Deadman notification: strings, onetimeworker, time calculation and unit tests * Periodic deadman notification worker added * Deadman notification refactor * Deadman notification refactor New tests * Worker refactored to new DI * Test boilerplate added * Additional tests * Clean up * Added mock providers for deadman notification workers * Comments and code clean up * Test clean up * Schedule work from CoronaWarnApplication * Variable naming fix * Switch to foreground state * Formatting * Formatting * Inject Notification Manager Compat * Change WorkManager initialization, make it impossible to inject the instance without it being initialized. Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Matthias Urhahn authored
-
- Nov 06, 2020
-
-
chris-cwa authored
* converted RetrieveDiagnosisKeysTransaction to Task * cherry picked and solved access to the new task * fixed background workers * fixed background workers * detekt ktlint unit test * ktlint * check cancel * fixed flow * fixed flow * fixed flow * fixed typo * Make klint happy. * Little refactoring to address PR comments (DI instead of static access). Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
- Nov 05, 2020
-
-
Rituraj Sambherao authored
* Harmonization of the expired QR-Code * implmentation and refactoring of the asyncRegisterDevice method * fix detekt pipeline issue * test failing pipeline fix * QRCode Exceotion, observevent and timestamp improvements as per code reviews * removed deregistration logic from Fragment to viewModel UI Thread protection as this is important logic and should run on ViewModel * Code conflict resolution * ktlint fixes * changin the method deregisterTestFromDevice() to private * scanStatus SingleLIveEvent and relevant test cases added Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
janetback authored
Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
Matthias Urhahn authored
* Split and hide the protobuf config behind interfaces with individual mappers responsible for creating the desired formats. * Merge branch 'release/1.7.x' into feature/3455-more-frequent-riskscore-updates-configs # Conflicts: # Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/risklevel/ui/TestRiskLevelCalculationFragmentCWAViewModel.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/transaction/RiskLevelTransaction.kt # Corona-Warn-App/src/test/java/de/rki/coronawarnapp/transaction/RiskLevelTransactionTest.kt * Make the AppConfig observable. Provide the server time offset. Offer a lastUpdatedAt timestamp. Add an app config specific test screen. Clean up test screens a bit and move debug options out of API test options. * Fix test regression due to refactoring (moved code around). * Store the server timestamp and offset at retrieval. Switch to config storage via json to be able to store additional meta data fields (i.e. time). * KLint and Me have a hate relationship based on both mutual admiration. * Fix time offset parsing being locale dependent. * Fix broken unit tests. * Improve offset accuracy, move before unzipping. * Fix overly long livedata subscription to results (viewmodel scope vs observer scope) * Add mapping for the new protobuf configs + tests. * For cached (retrofit) response, we need to check the cacheResponse and its timestamps to determine an accurate time offset. * Exposure a boolean property to tell us when a fallback config is being used. * Hide the observable flow<ConfigData> behind a method that can automatically triggers refreshes. * Use a common mapper interface. * Address PR comments and KLints. * Fix refactoring regression. * Improve config unzipping code. * Add flag to forward exception thrown during HotDataFlow.kt initialization. * Don't specify a default context via singleton. * Move download and fallback logic into it's own class just responsible for sourcing the config: "AppConfigSource". "AppConfigProvider" is now only responsible for making it available. * Simplify current concepts for making the app config observable until we have a default configuration. * Improve app config test screen, delete options, better feedback. Show toast instead of crash on errors. * Fixed GSON serialization not encoding/decoding the byte array correctly. Added specific type adapters for instant and duration to get cleaner json. * Remove type adapters from base gson due to conflict with CalculationTrackerStorage. * We want to default to forced serialization of instant by our converters, instead of using the default serialization which will differ between Java8.Instant and JodaTime.Instant, to prevent future headaches there, register explicit converters by default, and overwrite them if necessary (currently only needed for CalculationTrackerStorage.kt). * Improve AppConfigServer code readability by moving code into extensions. * Fix merge conflicts * Throw a more specific exception if gson type decoding fails due to malformed base64 encoding. * Add unit test for Gson ByteArrayAdapter. Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
janetback authored
-
- Nov 04, 2020
-
-
Alex Paulescu authored
* Added required strings. * Updated strings according to ticket description. Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
chris-cwa authored
-
- Nov 03, 2020
-
-
AlexanderAlferov authored
* Test run * Test run * Test run * Clean up * Property fix * Quotes fix * merge conflict solved Co-authored-by:
BMItter <46747780+BMItter@users.noreply.github.com> Co-authored-by:
BMItter <Berndus@gmx.de>
-
Rituraj Sambherao authored
* Regex updated and new test cases added * test cases refactored, regex improvement, obsolete tests removed
-
Matthias Urhahn authored
* On flavor "deviceForTesters" show a toast to tell the testers/devs which environment is currently activated. * Add unit tests for new "Current env: ..." toast. Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
BMItter authored
* moved getHash call to DeviceForTesters Flavor to satisfy CircleCI * added variant prefix
-
Alex Paulescu authored
* Fixed lived data in VM being filtered resulting in issue where it wouldn't be updated in the future * Removed unused imports * Delete Project.xml Removed unnecessary file. * Forgot to add if statement in observer * Revert Project.xml
-
- Nov 02, 2020
-
-
chris-cwa authored
* converted risk level transaction to task * simplified * fixed config: timeout is now duration * less is more * arrangement + empty lines * Added additional checks to notification of exposure/test-result to check for finished submission Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * submit risk level task requests * - unreachable catch blocks * housekeeping * satisfied ktlint + detekt * fixed flow: isRefreshing * fixed flavour for testers * refactored benchmark * fixed package declaration * unit tests * fixed injection * fixed tests * comments from PR * fixed injection * fixed lint issues * fixed another merge conflict * - unused class * map task factory * fulfilled comment style wishes * fixed tests suspended by changes from develop branch * Update Corona-Warn-App/src/main/java/de/rki/coronawarnapp/risk/DefaultRiskLevels.kt https://github.com/corona-warn-app/cwa-app-android/pull/1412#discussion_r514325776 Co-authored-by:
Kolya Opahle <k.opahle@sap.com> * changes from PR * fixed a test * show logs, ktlint issues * made log tag non-nullable * improvements from reviewers * reduced static access * Saint Pipeline, please give me the green light * toString() * ktlint + di * fixed test Co-authored-by:
Kolya Opahle <k.opahle@sap.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
Ralf Gehrer authored
-
- Oct 30, 2020
-
-
Matthias Urhahn authored
* Initial refactoring on the Submission flow. Trimming down SubmissionViewModel.kt * Refactored submission tan, and began instrumentation tests. Intro, Dispatcher and Tan complete * Adapted instrumentation tests after merge - added ToDos * Completed boilerplate submission instrumentation tests. Verification and screenshots to follow * Fix lints * More lint issues. * Fix instrumentation test dependency missmatch. * Move screenshot related permissions into a debug AndroidManifest.xml, such that they don't get included in production builds. * Added missing new line to manifest Co-authored-by:
Oliver Zimmerman <oezimmerman@gmail.com> Co-authored-by:
Kolya Opahle <k.opahle@sap.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
Matthias Urhahn authored
* Allow WorkerManager's workers to be injected. * Remove static access for Playbook * Add mock for playbook so dagger can create the worker factory map.
-
- Oct 29, 2020
-
-
Alexander Alferov authored
Test pipeline config
-
SAP LX Lab Service Account authored
Change-Id: Icbc05a9bc4c2d638335e918ece24bf772769b4c0
-
BMItter authored
* FileLoggerPlus - RX added - preparation * Buffer config as constants * avoid empty lines * Reworked logging to file - wip * Collecting errors to dao - wip * Added crash report to app db and created module * do it * inject crashReportTree - wip * use dagger injection * retrieve short hash via gradle * removed todo * Updated database to version 2 for new ReportEntity - old base * deprecated old engagement - RX not allowed anymore * use global scope for coroutines in crash report tree - ktlint clean * added menu item - error reporter (replace later to new structure) * basic recylcerview and fragment added to menu - wip * deprecated data class * Delete CrashModel.kt * crash report list item to use data binding * separated Reporteradapter - klint clean * use separated Adapter in ReporterFragment - cleanup * Added ErrorReporterViewModel - connected data to list * dependency injection for crash report, better structure, todo cleanup * some refactoring, cleanup, ktlint * adjustments for 1.6.x * temp action to open crash report fragment * removed testcode * updated layout - wip * connected view & data * satisfy circle ci checks * plant reportingTree, testbutton, klint clean * updated layout for reporter - wip * better format and layout * better message handling * missing icons for errors on debug * Adjusted error report index * Removed ugly show button, report clickable * Added SettingsCrashReportDetailsFragment & corresponding files * fixed merge inconsistence * fixed injection overall * use livedata * details added to report - wip * beauty * share & layout root preparation * make error report shareable * removed Dispatcher.IO for example * Introduce skeleton classes for bugreporting * Refactoring, adjustments to be able to build again * Created BugEventEntity, Changed id to Long for more efficiency, Removed unused events * refactored ui to deviceForTesters, testmenu etc * adjusted interfaces & related, better structure * uses own db, added converter, adjusted modules * adjusted bugrepo, defaultbugrepo * shared report, better visualisation * changed crash db name * Implemented DefaultBugRepository * Added device info to BugEvent, BugReporter collects Tag, Added default impl of BugEvent etc * corrected bug in RollingLogHistory * removed deprecated crash package * quickfix - wip * cleanup * cleanUp, adjusted simulation button to new structure * moved bug related layouts to deviceForTesters package * removed old RX dependenies and related context * fix build for deviceDebug * lint clean * current set of relevant exceptions as before * attach log to output * improved output * Delete obsolet ic_bug in main * Delete ic_coffee.xml * changed shortID to shortCommitHash for better transparency * companion to bottom * removed string encapsulation * cleanup unused import and blank line - PR Comment * typo fixed * rm empty line * removed relict module * layout fix * adjusted unrelated method call * fixed package inkonsistence * Use flow instead of livedata in non-ui * better fun naming * Replaced interface with inline listener * Improved SettingsCrashReportDetailsFragment and SettingsCrashReportViewModel, formatting adjusted * cleaned converter * Delete Project.xml * added log statement to DefaultBugRepository * adjusted magical number * Use CommonConverters instead of unique Converters in BugDatabase * Extension function for the resuce -defaultBugRepository * removed FormatterCrashReport completly * changed long to UUID * satisfy buggy ktlint checks * Update SettingsCrashReportViewModel.kt use postvalue * avoid passing viewmodel * store appVersionCode as Long for beeing futuresave * Update SettingsCrashReportViewModel.kt removed lazy init * Changed BugDatabase to factory pattern Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
- Oct 28, 2020
-
-
Matthias Urhahn authored
-
Alex Paulescu authored
* Added logic for showing notification on risk level change * Got rid of magic number * Fixed ktlint issue * Notification only shows up when risk card goes from red to green * Showing dialog onResume * Added static string for preference key and renamed method to better reflect usage * Whether not weather * Showing dialog is handled by the VM * Fixed ktlint error * Fixed an issue where the dialog would be shown only after navigating back to the home fragment. * Move decision logic for showing the lowered risk into the viewmodel. * Make the lowered risk level score event observable. * Fix wrong init value used for testing. * Update strings.xml * Fix test regressions due to static LocalData access. Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Alex Paulescu authored
* Refactored DataRetentionHelper class to use injection * Added ViewModel to SettingsReset * Add a clear cache method to AppConfigProvider.kt * Fixed repository live data containing stale data after app reset. * Moved logic from fragment to view model. * Adjusted tests to accommodate AppConfigProvider changes * Reverted back last 2 commits and downgraded ktlint plugin * Fixed DI issue * Put the scope in the hands of the VM * Deleted unused imports * Removed unused imports from VM * Use injected dispatcher provider to simplify testing. Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> Co-authored-by:
AlexanderAlferov <64849422+AlexanderAlferov@users.noreply.github.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
Matthias Urhahn authored
Retry the reset for v1.6.0+ as the failed reset attempt in 1.5.0 may have consumed the reset attempt already. (#1492)
-
Matthias Urhahn authored
* Cleaner log and remove superfluos removal, if we replace the entry anyways, we don't have to remove it. * Only propagate changes if the data actually changed. Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-