- Oct 07, 2020
-
-
Matthias Urhahn authored
Introduce VM injection for home screen and enable screen testing (EXPOSUREAPP-2946, EXPOSUREAPP-2948) (#1320) * Rename "MainFragment" to "HomeFragment" Add VM injection. Move initial logic into VM. TODO: Move more code, write more tests. * Additional refactoring, moving logic out of the Fragment. Moving code into their own encapsulated routines/components. Use composition to reuse TracingViewModel, SettingsViewModel and SubmissionViewModel * Introduce @AppContext annotation to prevent anyone mistaking it for something else. * Add VM to RiskDetailsFragment * Simplify nested viewmodels, here: TracingViewModel.kt * Add skeletons instrumentation test skeleton for single fragments with injection and mocking. * Address PR comments. * Introduce sealed events class, + some refactoring. * Make the linter happy.
-
- Oct 01, 2020
-
-
Matthias Urhahn authored
* Fix unreliable test. Random could be randomly 0 which would fail the test. * Create types for buildflavors to prevent string comparison. Use these build variants for specific tests. * Don't assign the times variable to a final value as it breaks tests. Until refactored, it's okay to recalculate this. * Remove a few sonar code smells. * Fix broken instrumentation test for key verification. Add matching binary, signature and pubkey from pod.
-
- Sep 18, 2020
-
-
Matthias Urhahn authored
This reverts commit 6054bf57.
-
Jakob Möller authored
* Added first set of country flags Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Added first implementation of Submission Country Selection Screen. (Currently not part of nav graph). Moved stuff inside of submission package into subpackages Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Added missing changes to nav_graph file * Test Menu options for Country selection and Measurement (EXPOSUREAPP-2229) (#1086) * Implement country filter (#2229) * Implement measure for Risk calculation and Key Retrieval (#2229) * Some code cleanup for measureRiskLevelAndKeyRetrieval * Some code cleanup (#2229) * Implement usage of AppConfig usage for country codes (#2229) * change CURRENT_COUNTRY val to var * Suppress "LongMethod" warning (#2229) * Adjust unit tests to respect new country filter * Align with backend for app config country property name * Display total file size of keys in results (#2229) * Fix linting issue * Update strings.xml files * Do refactoring and some code clean up * Move RiskLevel and Key retrieval measurement in own class * Move code in logical classes. Remove translation in test fragment * Fix linting and Unit tests * Remove 3hour boolean check from debug class. * Refactor CountryWrapper and missing dates check. * Fix linting and Unit tests * Add Unit test for getMissingDates * Code cleanup * Hide keyboard on action * Extend statistics for api submission * Set callback to null after invoked Co-authored-by:
Mert Safter <mert.safter@sap.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> * Overhaul of DiagnosisKey related Download and Caching Mechanisms (EXPOSUREAPP-2469) (#1136) * Rework of keyfile download and caching. * Supports interop * More modular for better testing and build flavour based behavior adjustments * More resilient handling of failed downloads * Preperations for future hourly download and serverside checksums TODO: Finish unit tests, keycache migration and cache health check * First batch of unit tests and some fixes for incorrect behavior that the tests surfaced. * Added unit tests for the KeyCacheRepository TODO: Tests for downloader and migration. * Implemented POC for migration old key files. * Fixed legacy file migration and cleanup, improved logging. * Added unit tests for legacy key file migration. * Add fallback for different file hashes in the header. * Yes kLint, we know it's a long method, but for this it's better to read it in one block vs jumping to extra methods. * More linting issues, adjusting project code style prevent a few of these in the future. * Added missing unit tests for `KeyFileDownloader` and fixed faulty behavior that was noticed during testing. * CRUD (instrumentation) test for `KeyCacheDatabase` * Remove unused `FileStorageHelper` and related constants+tests. * Fix last3Hours unit test in deviceRelease mode, we need to explicitly enable debug for these tests. * Until we have more information about the hashsum's format in the header, default to `ETag * Split app config server API from diagnosis key download API, and reintroduce caching for the app config download. * Add test to check that the cache is used on flaky connections. * Code changes based on PR comment, part #1. * Code fluff, formatting. * Handle download errors correctly. * Refactoring: * Remove unnecessary `currentDate` we always start with the newest date from the servers index. * Make a specialised class for header validation * Let legacy cache migration abort early, depending on whether the key dir exists. * If we can't create the base directory for the key repo, throw an exception. * Delete cache entry if a download fails. * Fixed test regression due to refactoring. * Consolidate staleness check into `getStale` * Consolidate clean up for failed downloads into the download method. Added tests to check that we delete the keycache entry if the download fails (which we didn't for hours :O!) * Because the hour-mode uses caching too, we add an explicit button to the test menu that clears the cache. * Add comment with reference to ticket regarding follow up on the other headers. * Move expected storage size per country into a named constant. Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> * Implementation of tests for the interoperability countries selection screen (EXPOSUREAPP-2439) (#1140) * Added initial set of viewModel tests Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Fail tests on unexpected null. Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> Co-authored-by:
Kolya Opahle <k.opahle@sap.com> Co-authored-by:
apopovsap <66370584+apopovsap@users.noreply.github.com> Co-authored-by:
Mert Safter <69803294+MertSafter@users.noreply.github.com> Co-authored-by:
Mert Safter <mert.safter@sap.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> Co-authored-by:
Matthias Urhahn <darken@darken.eu>
-
- Sep 11, 2020
-
-
Matthias Urhahn authored
* Rework of keyfile download and caching. * Supports interop * More modular for better testing and build flavour based behavior adjustments * More resilient handling of failed downloads * Preperations for future hourly download and serverside checksums TODO: Finish unit tests, keycache migration and cache health check * First batch of unit tests and some fixes for incorrect behavior that the tests surfaced. * Added unit tests for the KeyCacheRepository TODO: Tests for downloader and migration. * Implemented POC for migration old key files. * Fixed legacy file migration and cleanup, improved logging. * Added unit tests for legacy key file migration. * Add fallback for different file hashes in the header. * Yes kLint, we know it's a long method, but for this it's better to read it in one block vs jumping to extra methods. * More linting issues, adjusting project code style prevent a few of these in the future. * Added missing unit tests for `KeyFileDownloader` and fixed faulty behavior that was noticed during testing. * CRUD (instrumentation) test for `KeyCacheDatabase` * Remove unused `FileStorageHelper` and related constants+tests. * Fix last3Hours unit test in deviceRelease mode, we need to explicitly enable debug for these tests. * Until we have more information about the hashsum's format in the header, default to `ETag * Split app config server API from diagnosis key download API, and reintroduce caching for the app config download. * Add test to check that the cache is used on flaky connections. * Code changes based on PR comment, part #1. * Code fluff, formatting. * Handle download errors correctly. * Refactoring: * Remove unnecessary `currentDate` we always start with the newest date from the servers index. * Make a specialised class for header validation * Let legacy cache migration abort early, depending on whether the key dir exists. * If we can't create the base directory for the key repo, throw an exception. * Delete cache entry if a download fails. * Fixed test regression due to refactoring. * Consolidate staleness check into `getStale` * Consolidate clean up for failed downloads into the download method. Added tests to check that we delete the keycache entry if the download fails (which we didn't for hours :O!) * Because the hour-mode uses caching too, we add an explicit button to the test menu that clears the cache. * Add comment with reference to ticket regarding follow up on the other headers. * Move expected storage size per country into a named constant. Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
- Jun 11, 2020
-
-
ksergeevit authored
* worker tests * small fix * fixes testresult job tests Co-authored-by:
Hee Tatt Ooi <hee.tatt.ooi@sap.com> Co-authored-by:
Jakob Möller <jakob.moeller@sap.com>
-
- Jun 09, 2020
-
-
Jakob Möller authored
Signed-off-by:
d067928 <jakob.moeller@sap.com>
-
ksergeevit authored
Co-authored-by:
Jakob Möller <jakob.moeller@sap.com>
-
- Jun 07, 2020
-
-
Jakob Möller authored
* [INTERNAL] Translation delivery: commit by LX Lab Change-Id: Ic0905f66e03544c549ee6bf0edde3707c528215c * Translation branch update (#127) * Implement submission done fragment (#20) * Added submission done fragment (currently dangling in nav graph) * fixed leftover javadoc * Moved QR code scan and registration fragment to submission package (#21) * Dependency Updates and Gradle Fixes (#34) * Bump up Gradle to 4.0.0 / 6.1.1 * Bump up NDK * Bump Up SQLite * adapt circle config * Fix #23: Typo in onboarding screen (#31) Co-authored-by:
Jakob Möller <jakob.moeller@sap.com> * Submission UI Additions (#25) * Moved camera permission check to dispatcher fragment * Added illustrations for test result screen * Updated result fragment to match new design * Added constraints to status card * Integrated submission result positive other warning fragment in ui flow * Added submission done fragment to nav graph Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Added ability to dialog helper to create dialog without negative button * Switched from AlertDialog.Builder to DIalogHelper * Enable diagnosis key upload to backend (#35) * Moved camera permission check to dispatcher fragment * Added illustrations for test result screen * Updated result fragment to match new design * Added constraints to status card * Integrated submission result positive other warning fragment in ui flow * add TAN fetching to the key submission transaction * remove unneeded function * Fix log message for fetching TAN * Added submission done fragment to nav graph Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Added ability to dialog helper to create dialog without negative button * Switched from AlertDialog.Builder to DIalogHelper * use actual TAN (authCode) for key submission set the TAN in the corresponding header field fixes #8 * request permission to retrieve diagnosis keys * permission needs to be requested again after dialog has been presented to the users * trigger transaction to retrieve TAN and upload keys Co-authored-by:
Kolya Opahle <k.opahle@sap.com> * Removed ExposureNotificationIntentService, the functionality is handled by NotificationHelper (#40) * Fixing tele tan registration (#45) * Fixed teleTAN based device registration Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * allowed excluded tan chars for testing Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Revert "allowed excluded tan chars for testing" This reverts commit 253ede4ea9c8ba2b5e6dd324680eed0f8f7e74c1. * Release/0.5.5 (#48) * Release/0.5.5 * Hotfix for resetting Gradle Version (internal pipeline confirmation) (#52) * Gradle Reset to 0.5.4 (#53) * Release/0.5.5 (#48) * Hotfix for resetting Gradle Version (internal pipeline confirmation) (#52) * Minify and Shrink Disabled (#56) * Release/0.5.5 * Gradle Reset to 0.5.4 (#53) * Release/0.5.5 (#48) * Hotfix for resetting Gradle Version (internal pipeline confirmation) (#52) * Disable minify / shrink * Dont obfuscate * 0.5.6 * Update known issues and fixing typo in readme (#44) * added strings wip to known issues * updated readme Co-authored-by:
Muschko <marc.muschko@sap.com> * Updated strings, introduced more details on app-information screens (#88) * updated strings for risk card and risk card details; plural strings are todo when finalized * updated more strings on main / details * added comments * added strings for information about, information technical hotline; changed technical hotline layout * removed hotline test icon * fixed build issues * Cleanup pull_request_template.md (#54) * Update pull_request_template.md * Removed Link to Contribution Guidelines (added by Github on the right hand side, anyhow) * Removed Link to issue #41 from title example (this has been linked quite a lot...) * 0.5.6 * Fix typo Co-authored-by:
Jakob Möller <jakob.moeller@sap.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by:
marcmuschko <marc.muschko@sap.com> * Add Support for lower case characters in the teleTAN screen (#66) * added support for lower case input in teleTan fragment Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Removed notice of case insensitivity from temporary strings.xml Signed-off-by:
Kolya Opahle <k.opahle@sap.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> * Correct typos in architecture overview (#67) Co-authored-by:
marcmuschko <marc.muschko@sap.com> * Bluetooth & connection card (#97) * introduced settings navigation helper * added connection and bluetooth stati to main and tracing settings * moved strings * removed unnecessary backgroundTint Co-authored-by:
marcmuschko <marc.muschko@sap.com> * Fix typo in class documentation (#71) * 0.5.6 * fix typo Co-authored-by:
Jakob Möller <jakob.moeller@sap.com> Co-authored-by:
marcmuschko <marc.muschko@sap.com> * spelling fixes (#87) * 0.5.6 * spelling fixes Co-authored-by:
Jakob Möller <jakob.moeller@sap.com> Co-authored-by:
klemens <ka7@github.com> Co-authored-by:
marcmuschko <marc.muschko@sap.com> * Moves creation of notification channel to app startup (#32) Co-authored-by:
Jakob Möller <jakob.moeller@sap.com> * Tracing start/stop fix due to missing handling inside tracing (#99) Co-authored-by:
Jakob Möller <jakob.moeller@sap.com> * Switch the DB Password to use the KeyStore MasterKey (#98) Signed-off-by:
d067928 <jakob.moeller@sap.com> * Shared prefs ktx shorthand (#38) * closes #33 * Add Commit Flag to ensure synchronous consistent Updates to Disk Signed-off-by:
d067928 <jakob.moeller@sap.com> * Add persistance of timestamp and whether user is allowed to submit keys (#74) * Store timestamp of receiving registration token * also reset this timestamp when deleting the registration token * use correct timestamp for display of test time * replace tracing activation time by test result reception time * rename TAN request to match context * set isAllowedToSubmitDiagnosisKeys properly Co-authored-by:
Jakob Möller <jakob.moeller@sap.com> * set "enabled" for include_settings_switch_row in notifications settings, fixes wrong binding and removed clickable rows (#101) Co-authored-by:
marcmuschko <marc.muschko@sap.com> * fix #82 (#94) * fix #82 Co-authored-by:
Jakob Möller <jakob.moeller@sap.com> * Add ShareHelper (#85) * Add ShareHelper * Use ShareHelper in MainShareFragment * Replace the current exposure status with a positive result card when test result is positive (#79) * Made submission status card style more cross device friendly Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Added the positive result submission status card Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * lint fix * Updated main fragment documentation * Added icon for sharing risk status Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Updated positive result home screen card text and icons Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Added loading indicator to test result fragment (#100) Co-authored-by:
marcmuschko <marc.muschko@sap.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> * Adjusted onboarding flow, adjusted contribution file, small fixes in settings (#106) * changed permission dialog logic for onboarding tracing fragment and onboarding notification fragment * adjusted contributing file * added settings notification handling to display value in settings overview * fixed app crash during bluetooth settings navigation * corrected wrong value from view model in tracing settings text * Submission Contact Fragment & StepView Custom View (#102) * - submission-contact fragment added - StepEntry custom view added to unify various step entry views - SimpleStepEntry as a simple implementation of a StepEntry with title and text added * - apply naming conventions for ids - use CallHelper to trigger a call - access views using kotlinx.android.synthetic Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> * Notifications when risk value has changed between low and high. (#76) * Notifications when risk value has changed between low and high. * Notifications when risk value has changed between low and high. Fixed wildcard imports. * Fixed formatting, ktlint issue. * app foreground/background checking. Notifications are not sent when app is in background * update comments * initialize foreground flag as false(valid for background threads before ui starts) * comments * included UNDERTERMINED as a low, for initialisation * fixed icon * fixed tests Co-authored-by:
Jakob Möller <jakob.moeller@sap.com> * added onboarding strings (#109) * disable colored output for ktlint (#105) Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by:
Jakob Möller <jakob.moeller@sap.com> * Limit number of keys to be uploaded to server (#107) * limit the number of keys to be uploaded to 14 * fix spaces Co-authored-by:
Jakob Möller <jakob.moeller@sap.com> * Fix white space, informal language and spelling of Docker in Readme (#78) * 0.5.6 * Fix spelling gonna and docker * Add missing "to" Co-authored-by:
Jakob Möller <jakob.moeller@sap.com> Co-authored-by:
marcmuschko <marc.muschko@sap.com> * Update build.gradle (#111) * Build.Gradle Conflict Resolving (0.8.0) (#112) * Minify and proguard fix (#113) Commented out -dontobfuscate * Circle progress bar (#96) * circle progress bar impl * ktlint format * added new ui * added circle to contact tracing without binding * added binding and final icon * added circle progress to risk card * added comments * changed default value for disableText * adapted views order to designs * removed testing value Co-authored-by:
Kirill <kirill.sergeev@sap.com> * TracingStatusHelper unit test (#114) * TracingStatusHelper unit test * removed duplicate * Prevent screenshot of the app for all activities (#108) * Prevent screenshot of the app for all activities * fix ktlint * code smell fix Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> * Feature: Bluetooth callback (#115) * bluetooth callback added * bound bluetooth callback to the ui Co-authored-by:
Kirill <kirill.sergeev@sap.com> * Added main overview page to main menu (#120) * added overview fragment baseline * main overview draft version completed with build fixes * checked some final strings again * Fixed screen orientation to portrait (#121) * added restriction to portrait and reversed portrait orientation only * suppress SourceLockedOrientationActivity lint error * changed local config that a high match can be generated via QR code, integrated it with the UI (#125) * Feature: Translation preparation (#126) * renamed old strings and reordered * app information strings translation tags * updated translation tags for long texts * added translation comments to strings * fixed naming error * removed empty comment Co-authored-by:
Muschko <marc.muschko@sap.com> Co-authored-by:
Kolya Opahle <k.opahle@sap.com> Co-authored-by:
Jakob Möller <jakob.moeller@sap.com> Co-authored-by:
Michael Keppler <bananeweizen@gmx.de> Co-authored-by:
Thomas Klingbeil <64434904+tklingbeil@users.noreply.github.com> Co-authored-by:
Hee Tatt Ooi <64406309+HeeTattSap@users.noreply.github.com> Co-authored-by:
Muschko <marc.muschko@sap.com> Co-authored-by:
Thomas Kowark <thomas.kowark@sap.com> Co-authored-by:
Robert Scheck <robert-scheck@users.noreply.github.com> Co-authored-by:
Volkmar Vogel <volkmar@vogel.app> Co-authored-by:
ka7 <ka7@la-evento.com> Co-authored-by:
klemens <ka7@github.com> Co-authored-by:
Tim Brüggenthies <tim.brueggenthies@outlook.de> Co-authored-by:
mseele <mseele@gmail.com> Co-authored-by:
Janik Steegmüller <janik.steegmueller@gmail.com> Co-authored-by:
Fabian-K <fabian.kajzar@sap.com> Co-authored-by:
Hee Tatt Ooi <hee.tatt.ooi@sap.com> Co-authored-by:
Matthias Küch <mail@matthias-kuech.de> Co-authored-by:
oemerb <66002424+oemerb@users.noreply.github.com> Co-authored-by:
AlexanderAlferov <64849422+AlexanderAlferov@users.noreply.github.com> Co-authored-by:
Kirill <kirill.sergeev@sap.com> Co-authored-by:
Philipp Woessner <64482866+pwoessner@users.noreply.github.com> * [INTERNAL] Translation delivery: commit by LX Lab Change-Id: Ic0905f66e03544c549ee6bf0edde3707c528215c * Remove values-2Q Signed-off-by:
d067928 <jakob.moeller@sap.com> * [INTERNAL] Translation delivery: commit by LX Lab Change-Id: Idf52dece137fdc6e314ed752a8ef6b79b08683b0 * deleted 2Q * [INTERNAL] Translation delivery: commit by LX Lab Change-Id: I63afce1d7307c912b034728d8b78d437974f818d * excluded translation from lint for dev * fixed quickBuild errors Co-authored-by:
service-tip-git <tmsatsls@gmail.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by:
Kolya Opahle <k.opahle@sap.com> Co-authored-by:
Michael Keppler <bananeweizen@gmx.de> Co-authored-by:
Thomas Klingbeil <64434904+tklingbeil@users.noreply.github.com> Co-authored-by:
Hee Tatt Ooi <64406309+HeeTattSap@users.noreply.github.com> Co-authored-by:
Muschko <marc.muschko@sap.com> Co-authored-by:
Thomas Kowark <thomas.kowark@sap.com> Co-authored-by:
Robert Scheck <robert-scheck@users.noreply.github.com> Co-authored-by:
Volkmar Vogel <volkmar@vogel.app> Co-authored-by:
ka7 <ka7@la-evento.com> Co-authored-by:
klemens <ka7@github.com> Co-authored-by:
Tim Brüggenthies <tim.brueggenthies@outlook.de> Co-authored-by:
mseele <mseele@gmail.com> Co-authored-by:
Janik Steegmüller <janik.steegmueller@gmail.com> Co-authored-by:
Fabian-K <fabian.kajzar@sap.com> Co-authored-by:
Hee Tatt Ooi <hee.tatt.ooi@sap.com> Co-authored-by:
Matthias Küch <mail@matthias-kuech.de> Co-authored-by:
oemerb <66002424+oemerb@users.noreply.github.com> Co-authored-by:
AlexanderAlferov <64849422+AlexanderAlferov@users.noreply.github.com> Co-authored-by:
Kirill <kirill.sergeev@sap.com> Co-authored-by:
Philipp Woessner <64482866+pwoessner@users.noreply.github.com> Co-authored-by:
Luka Harambasic <luka.harambasic@sap.com>
-
Jakob Möller authored
* Implement passphrase generation for db (closes #173) (#224) * Add failing tests (#173) * Fix AppDatabase instance not reset when method called (#173) * Implement passphrase generation and storage/retrieval of passphrase by encrypted shared preferences (#173) * Setup Retention while maintaining the DB Password Signed-off-by:
d067928 <jakob.moeller@sap.com> * Setup Retention while maintaining the DB Password Signed-off-by:
d067928 <jakob.moeller@sap.com> * Lint Signed-off-by:
d067928 <jakob.moeller@sap.com> Co-authored-by:
Andreas Schattney <a.schattney@gmail.com> Co-authored-by:
Philipp Woessner <64482866+pwoessner@users.noreply.github.com>
-
- Jun 04, 2020
-
-
ksergeevit authored
* util tests * util tests * util tests + persistence tests * more persistence tests
-
ksergeevit authored
* util tests * util tests * util tests + persistence tests
-
- Jun 02, 2020
-
-
Hee Tatt Ooi authored
* TracingStatusHelper unit test * removed duplicate
-
- May 30, 2020
-
-
Sebastian Wolf authored
-