Skip to content
Snippets Groups Projects
  1. Dec 23, 2020
    • Matthias Urhahn's avatar
      Improve risklevel result data access performance (DEV) #1953 · 665b6f21
      Matthias Urhahn authored
      
      * Don't log all exposure windows on `RiskLevelTaskResult.toString()` due to performance impact when logging.
      
      * Add RiskLevelResult flow optimized for just getting the latest two results.
      
      * Share risk level result subscriptions.
      The delay when switching from Home to RiskDetails fragment will be bridged and no re-loading necessary.
      
      * Fix test regressions
      
      * Remove test code.
      
      * Introduce specific query for "latestAndLastSuccessful".
      Add unit tests for SQL queries.
      
      * Fix test regressions due to missing mocking.
      
      * Address merge conflicts.
      
      * Fix instrumentation tests not building.
      
      Co-authored-by: default avatarRalf Gehrer <ralfgehrer@users.noreply.github.com>
      665b6f21
  2. Nov 25, 2020
    • Matthias Urhahn's avatar
      Persist ExposureWindow based risk level calculation results and update the UI... · 2547e10a
      Matthias Urhahn authored
      Persist ExposureWindow based risk level calculation results and update the UI (EXPOSUREAPP-3910,EXPOSUREAPP-3855) (#1705)
      
      * First draft to refactor `RiskRepository` away and persist risk level results produced by ExposureWindow calculations.
      
      TODO: Tests, Legacy data migration, Persist ExposureWindow's in tester builds.
      
      * Unit tests for refactored classes.
      
      * LINTs
      
      * First draft for legacy risk data migration.
      
      TODO: Tests.
      
      * Store exposure windows on device for tester builds and perform clean on them too after risk result deletions.
      Split RiskResultStorage such that the exposure window storage code is only available in deviceForTesters flavor builds.
      
      * simplification
      
      * no preference should return no value
      
      * Remove TODOs, singletons are refactored away ;)
      
      * Simplify RiskLevelTask interface
      
      * Split risk level storage implementations to let production (device flavor) have a NOOP for storing/deleting exposure windows.
      
      * Remove unused storage function.
      Add test skeletons.
      
      * unit test
      
      * unit test
      
      * Update risk card to show new window mode based information.
      
      * Fix test regressions.
      
      * Address PR comments.
      
      * LINTs
      
      * Everybody get's LINT for XMAS.
      
      * Finish unit tests and remove unused classes.
      
      Co-authored-by: default avatarchris-cwa <chris.cwa.sap@gmail.com>
      2547e10a
  3. Nov 24, 2020
  4. Oct 29, 2020
    • BMItter's avatar
      Improved crash logging & handling (EXPOSUREAPP-2572) (#1475) · be4c773d
      BMItter authored
      
      * FileLoggerPlus - RX added - preparation
      
      * Buffer config as constants
      
      * avoid empty lines
      
      * Reworked logging to file - wip
      
      * Collecting errors to dao - wip
      
      * Added crash report to app db and created module
      
      * do it
      
      * inject crashReportTree - wip
      
      * use dagger injection
      
      * retrieve short hash via gradle
      
      * removed todo
      
      * Updated database to version 2 for new ReportEntity - old base
      
      * deprecated old engagement - RX not allowed anymore
      
      * use global scope for coroutines in crash report tree - ktlint clean
      
      * added menu item - error reporter (replace later to new structure)
      
      * basic recylcerview and fragment added to menu - wip
      
      * deprecated data class
      
      * Delete CrashModel.kt
      
      * crash report list item to use data binding
      
      * separated Reporteradapter - klint clean
      
      * use separated Adapter in ReporterFragment - cleanup
      
      * Added ErrorReporterViewModel - connected data to list
      
      * dependency injection for crash report, better structure, todo cleanup
      
      * some refactoring, cleanup, ktlint
      
      * adjustments for 1.6.x
      
      * temp action to open crash report fragment
      
      * removed testcode
      
      * updated layout - wip
      
      * connected view & data
      
      * satisfy circle ci checks
      
      * plant reportingTree, testbutton, klint clean
      
      * updated layout for reporter - wip
      
      * better format and layout
      
      * better message handling
      
      * missing icons for errors on debug
      
      * Adjusted error report index
      
      * Removed ugly show button, report clickable
      
      * Added SettingsCrashReportDetailsFragment & corresponding files
      
      * fixed merge inconsistence
      
      * fixed injection overall
      
      * use livedata
      
      * details added to report - wip
      
      * beauty
      
      * share & layout root preparation
      
      * make error report shareable
      
      * removed Dispatcher.IO for example
      
      * Introduce skeleton classes for bugreporting
      
      * Refactoring, adjustments to be able to build again
      
      * Created BugEventEntity, Changed id to Long for more efficiency,  Removed unused events
      
      * refactored ui to deviceForTesters, testmenu etc
      
      * adjusted interfaces & related, better structure
      
      * uses own db, added converter, adjusted modules
      
      * adjusted bugrepo, defaultbugrepo
      
      * shared report, better visualisation
      
      * changed crash db name
      
      * Implemented DefaultBugRepository
      
      * Added device info to BugEvent, BugReporter collects Tag, Added default impl of BugEvent etc
      
      * corrected bug in RollingLogHistory
      
      * removed deprecated crash package
      
      * quickfix - wip
      
      * cleanup
      
      * cleanUp, adjusted simulation button to new structure
      
      * moved bug related layouts to deviceForTesters package
      
      * removed old RX dependenies and related context
      
      * fix build for deviceDebug
      
      * lint clean
      
      * current set of relevant exceptions as before
      
      * attach log to output
      
      * improved output
      
      * Delete obsolet ic_bug in main
      
      * Delete ic_coffee.xml
      
      * changed shortID to shortCommitHash for better transparency
      
      * companion to bottom
      
      * removed string encapsulation
      
      * cleanup unused import and blank line - PR Comment
      
      * typo fixed
      
      * rm empty line
      
      * removed relict module
      
      * layout fix
      
      * adjusted unrelated method call
      
      * fixed package inkonsistence
      
      * Use flow instead of livedata in non-ui
      
      * better fun naming
      
      * Replaced interface with inline listener
      
      * Improved SettingsCrashReportDetailsFragment and SettingsCrashReportViewModel, formatting adjusted
      
      * cleaned converter
      
      * Delete Project.xml
      
      * added log statement to DefaultBugRepository
      
      * adjusted magical number
      
      * Use CommonConverters instead of unique Converters in BugDatabase
      
      * Extension function for the resuce -defaultBugRepository
      
      * removed FormatterCrashReport completly
      
      * changed long to UUID
      
      * satisfy buggy ktlint checks
      
      * Update SettingsCrashReportViewModel.kt
      
      use postvalue
      
      * avoid passing viewmodel
      
      * store appVersionCode as Long for beeing futuresave
      
      * Update SettingsCrashReportViewModel.kt
      
      removed lazy init
      
      * Changed BugDatabase to factory pattern
      
      Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>
      Co-authored-by: default avatarharambasicluka <64483219+harambasicluka@users.noreply.github.com>
      be4c773d
  5. Oct 13, 2020
    • Matthias Urhahn's avatar
      Taskcontroller logic (EXPOSUREAPP-2743) (#1352) · 4ed675c8
      Matthias Urhahn authored
      
      * tasks wip
      
      * Additional work on task controller skeleton code.
      
      * Further refactoring iterations on the new task system interfaces.
      
      * Further refactoring iterations on the new task system interfaces.
      
      * Remove enum key type and replace with TaskRequest class
      
      * Move the config interface into the factory show make clear what the relation here is.
      
      * * Remove the task ID from the public interface, there is currently no need to expose it. Interested parties use the request's ID to find their task data.
      * Throw a defined exception (early) if we submit a task for which there is no factory hooked up.
      
      * Finished unit tests for TaskController
      * Small adjustments to the public TaskController interface
      * Task typing should not be based on the request types, this allows TaskRequests to be subclassed without shooting yourself in the foot by unexpectedly breaking the type checks.
      
      * Lints
      
      * Verify factory call order.
      
      * Lints
      
      * Add test menu entry for the TaskController
      
      * Address PR comments.
      
      * Fix flaky tests.
      
      * Address PR comments.
      
      * Fix dagger graph in deviceRelease mode, wrong file name ending.
      
      Co-authored-by: default avatarchris-cwa <chris.cwa.sap@gmail.com>
      Co-authored-by: default avatarharambasicluka <64483219+harambasicluka@users.noreply.github.com>
      4ed675c8
  6. Oct 02, 2020
    • Matthias Urhahn's avatar
      Reduce code duplication (EXPOSUREAPP-2844) (#1286) · d64a5825
      Matthias Urhahn authored
      * Remove code duplication between different flavors.
      Remove extra MainFragment and NavGraph.
      Introduce TestMenu indirection
      Add logic for splitting test code up into extra fragments.
      
      * Style list items a bit :)
      
      * fix lints
      
      * Detekt *hug*
      
      * We can only show the menu entry if we are actually on the right flavor,
      otherwise, in deviceDebug, we would not have access to the right resources.
      
      * Address PR comments
      
      * Fix wrong XML namespace.
      d64a5825
  7. Sep 29, 2020
  8. Sep 23, 2020
    • Mert Safter's avatar
      Interoperability Onboarding and Information (EXPOSUREAPP-2730, EXPOSUREAPP-2733) (#1202) · f85da39e
      Mert Safter authored
      
      * Import flag assets. Create init CountrySelectionList and Fragment
      
      * Implement missing components. Create ViewModel and Repository for Interop
      
      * fix wrong property usage
      
      * Implement storage of selected countries
      
      * Implement warn dialog
      
      * Added navigation from country selection to tracing fragment
      
      * Fixed lint errors
      
      * Fix typo and build error
      
      * Move navigation out of onResume
      
      * Implement Warning dialog and do some code cleanup
      
      * Begin of onboarding for Interoperability. Fix linting issues
      
      * Implement onboarding for Interoperability (#1976)
      
      * Implement skip path of interop screen in onboarding (#1976)
      
      * Implement navigation logic for onBoarding (#1976)
      
      * Fix linting issues
      
      * Adjust country list and view to new UI (#2667)
      
      * Merge OnboardingTracingFragment with country list (#2665)
      
      * UI adjustments (#2665)
      
      * Fix linting issues
      
      * Implement Delta Onboarding logic (#2665)
      
      * Adjust interoperability screens to new UI (#2730, #2733)
      
      * Added navigation from country selection to tracing fragment
      
      * Fix merge issues with interoperability branch
      
      * Fix merge issues with interoperability branch
      
      * Fix merge changes with 1.5.x branch
      
      * Remove unused Formatter
      
      * Remove import of unused Formatter
      
      * Remove import of unused Formatter
      
      * Fix linting issue
      
      * Adjust UI to mock changes (#2730)
      
      * Adjust fragment binding to new solution and code cleanup
      
      * Adjust layout ids to guidelines. Comment strings.xml
      
      * Moved back navigation event to ViewModel
      
      * Move to DI and ViewModel navigation
      
      * Improve accessibility
      
      * Improve accessibility
      
      * Adjusted UI to updated mockups. Clean-Up of InteroperabilityRepository and LocalData
      
      * Refactoring and ViewModel use.
      
      * Make detekt happy.
      
      * Fix PR comments, typos, inline getString.
      
      * Fix refactoring typo
      
      Co-authored-by: default avatarAlexandru.Paulescu <alexandru.paulescu@sap.com>
      Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>
      Co-authored-by: default avatarMatthias Urhahn <darken@darken.eu>
      f85da39e
  9. Sep 17, 2020
    • Matthias Urhahn's avatar
      Reduce boilerplate code for fragment view setup (#1161) · 0676ab79
      Matthias Urhahn authored
      
      * Reduce boilerplate code for fragment view setup.
      
      * Fix klint issue + change codestyle to match klint.
      
      * Fixed regressions in `MainFragment` in `device` buildflavor
      
      * Fix kotlin upgrade regression
      
      * Disable KotlinNothingValueException in Kotlin 1.4 until kotest/mockk can handle it.
      
      * Make "binding.lifecycleOwner = this" automatic.
      
      * Addressed PR comments.
      
      * build issue to due mixing branches
      
      Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>
      0676ab79
    • Matthias Urhahn's avatar
      Introduce ViewModel Injection (#1151) · e8320fdf
      Matthias Urhahn authored
      
      * DI: ViewModel (VDC) injection wiring + example in TestRiskLevelCalculation.kt
      
      * Refactoring the TestRiskLevel fragment to demo our new viewmodel approach. Part1
      
      * Refactoring the TestRiskLevel fragment to demo our new viewmodel approach. Part2
      
      * Fix `Unexpected indentation (expected 4, actual 8)`
      
      * Code fluff
      
      * klint
      
      * Remove empty test + klint
      
      * Rename VDC to CWAViewModel
      
      * Add example unit tests for the TestFragment's ViewModel.
      
      * Revert AppInjector renaming.
      
      * Comments explaining the code.
      
      * Rename class to make it's purpose less confusing.
      
      * Revert "Rename class to make it's purpose less confusing."
      
      This reverts commit c80298bb
      
      * Rename class to make it's purpose less confusing.
      
      * Simpler ViewModel Injection example.
      
      * klint <3
      
      Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>
      e8320fdf
    • Oliver Zimmerman's avatar
      Provide onset of symptoms before upload (EXPOSUREAPP-1605) (#1170) · 8c7e0501
      Oliver Zimmerman authored
      
      * initial commit of new fragment for symptom screen
      
      * Added relevant strings for symptom screen. Started editing xml of initial symptom screen
      
      * Addded 3 selection options within symptom screen
      
      * button id name change to something more relevant
      
      * ID changes to be something more relevant to symptom scenerio.
      
      * Implemented symptom initial screen logic. Temporary nav for testing.
      
      * CircleCI formatting
      
      * Adapted interoperability test provided by apopov
      
      * Added accessibilty announcement on resume, fixed navigation for main page
      
      * circleCI indentation fix
      
      * removed ar & ru and updated default strings
      
      * Adaption to ViewModel logic. Not yet complete
      
      Adaption to ViewModel logic, attempting to align with implementation done with some interoporibility tasks: reusable layout files, etc.
      
      * More ViewModel transformation additions
      
      * revert nav from test. Circle CI formatting changes
      
      * Update SubmissionSymptomIntroductionFragment.kt
      
      * Removed old fragment based test
      
      * Will implement navigation during marry session.
      
      * Update SubmissionViewModel.kt
      
      * Calendar button selection screen + required strings
      
      * Custom calendar view
      
      * Accessibility improved
      
      * introduced data types for symptoms
      
      * represent date by long in millis
      
      * new TransmissionRiskVector
      
      * Constants and formatting
      
      * Naming changes requested
      
      * Better event naming
      
      * Update fragment_submission_symptom_intro.xml
      
      * Finishing calendar implementation - still need to implement calendar widget
      
      Surrounding calendar submission UI - minus calednar widget
      Necessary strings
      
      * Merged introduction and calendar screen.
      
      Created calendar fragment screen,
      Finished calendar XML view
      Added required entries for choices in SubmissionViewModel
      Adjusted Formatters for button selection.
      Changed nav graph.
      
      * + todo
      
      * CircleCI code style changes
      
      * EXPERT STUFF
      
      * Latest push for marry session
      
      * replaced transaction risk vector
      
      * update textcolor on symptom indication change
      
      * update buttons by code
      
      * code formatting
      
      * Added logic for Negative and No Information buttons and adjusted xml view to be more aligned with design
      
      Added logic for Negative and No Information buttons and adjusted xml view to be more aligned with design
      
      * disable next button when state is null.
      
      * + readability
      
      * Calendar screen logic adapted for button selection
      
      * extracted domain logic from prototype and from transaction
      
      * - not used events
      
      * joint improvements
      
      * removed unused events
      
      * Calendar unsetSelection added
      
      * detekt rules changed and formatting
      
      * - calendar view refactor: CalendarCalculator singleton introduced for batter testing capacity
      - unit tests added
      
      * detekt issues
      
      * Colors and styles cleared
      
      * fixed strings
      
      * maintained unit tests
      
      * adopted changes from main nav graph to device for testers nav graph
      
      * reverted comment
      
      * made start of symptoms nullable
      
      * tests
      
      * Adjusted navigation, fixed dark theme
      
      * Update Project.xml
      
      * use of postValue() in SubmissionViewModel.kt
      
      * Added direction in tester nav graph
      
      * improvements required by review
      
      * moving companion
      
      * moving companion
      
      * moving companion
      
      * fixed issues from partner review
      
      * fixed issues from partner review
      
      * fixed issues from partner review
      
      * fixed issues from partner review
      
      * fixed issues from partner review
      
      * using utc
      
      * edge case tests
      
      * made inner class
      
      * Refactored Symptoms Class Name (+data class)
      
      * Change SubmissionViewModel scope to ensure that the same viewmodel is used to store submission data.
      
      * extracted null check + log
      
      Co-authored-by: default avatarLuka Harambasic <luka.harambasic@sap.com>
      Co-authored-by: default avatarchris-cwa <chris.cwa.sap@gmail.com>
      Co-authored-by: default avatarAlexander Alferov <a.alferov@sap.com>
      Co-authored-by: default avatarharambasicluka <64483219+harambasicluka@users.noreply.github.com>
      Co-authored-by: default avatarMatthias Urhahn <darken@darken.eu>
      Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>
      8c7e0501
  10. Sep 14, 2020
  11. Jul 30, 2020
    • Kolya Opahle's avatar
      Fix looping background restricition notification in onboarding (EXPOSUREAPP-1962) (#950) · 22c9702a
      Kolya Opahle authored
      
      * added call to navigateToMain before opening the app settings
      
      * Moved checks for background job notification to main activity
      
      * refined background dialogs
      
      Co-authored-by: default avatarPhilipp Woessner <philipp.woessner@sap.com>
      22c9702a
    • Oliver Zimmerman's avatar
      Energy optimized and manual check warning dialogs (EXPOSUREAPP-1853) (#944) · a5505ba8
      Oliver Zimmerman authored
      
      * Check for battery saver mode
      
      added a check for battery saver mode in connectivity helper
      created sample dialog to appear if battery saver is enabled - string values to be confirmed.
      
      * Implemented the energy saving warning dialog in main screen
      
      - Created a Dialog in MainFragment that shows once (shared pref boolean check), and if energy saver mode is enabled
      - Created a shared pref in local data to store if the energy saving warning has been shown
      - Added strings required for dialog (Only DE confirmed)
      - Added a method in ExternalActionHelper that will open energy saver settings
      - Adjusted existing dialog in onboarding process
      
      * Change from battery saver check to battery optimized check
      
      - Change from battery saver check to battery optimized check
      - Added second dialog explaining manual checks
      
      * Update strings.xml
      
      Text changes as provided on JIRA ticket
      
      * Dialog will now only appear once in tracing settings.
      
      * removed unused imports
      
      * Update SettingsTracingFragment.kt
      
      * Update SettingsTracingFragment.kt
      
      * code formatting
      
      * formatting
      
      * Update ConnectivityHelper.kt
      
      * Update SettingsTracingFragment.kt
      
      * Lint and string file changes
      
      1. Small corrections of brackets and lines
      2. Keeping order of the elements in string files uniform across languages
      
      * Update strings.xml
      
      * Update strings.xml
      
      Co-authored-by: default avatarRituraj Sambherao <git.rituraj.sambherao@gmail.com>
      a5505ba8
  12. Jul 15, 2020
    • Philipp Woessner's avatar
      Hotfix into dev (#877) · f8c4157d
      Philipp Woessner authored
      
      * remove all files from the cache if they are no longer present in the server date index
      
      * version bump to 1.0.5 for hotfix
      
      * changed version to 1.0.41 for hotfix
      
      * Set version to 1.0.5 for hotfix release
      
      * added text change in risk card activeTracingDaysInRetentionPeriod and added turkish language tag to information hotline
      
      * fixed build issues, magic number removed
      
      * risk details string resource updated
      
      * added onetime dialog explaining the risk calculation
      
      * ktlint fixes
      
      * initila commit
      
      * ui adjustment and pipeline fixes
      
      * pipeline fix
      
      * logic simplified
      
      * Version bump to 1.0.6
      
      Co-authored-by: default avatarMuschko <marc.muschko@sap.com>
      Co-authored-by: default avatarRituraj Sambherao <git.rituraj.sambherao@gmail.com>
      f8c4157d
  13. Jul 14, 2020
  14. Jun 12, 2020
  15. Jun 11, 2020
Loading