Skip to content

Resolve: "Refactor get_birthplace.R to get_nationality.R"

Lukas Gehrke requested to merge 46-enhancing-r-optimize-getbirthplace-r into master

Done

  • Renames get_birthplace.R to get_nationality.R in all places

  • get_nationality tries to extract nationality as first NORP-entity in text

  • Adds Unit test

  • Adds check for date returned instead of place from inbox

ToDo

  • Remove Use of infobox because that's structured data3

  • Rename to get_nationality

  • Refactor bot utterances 🤖

Closes #46 (closed)

Edited by Lukas Gehrke

Merge request reports