Skip to content
Snippets Groups Projects
  1. Nov 25, 2020
    • Matthias Urhahn's avatar
      Persist ExposureWindow based risk level calculation results and update the UI... · 2547e10a
      Matthias Urhahn authored
      Persist ExposureWindow based risk level calculation results and update the UI (EXPOSUREAPP-3910,EXPOSUREAPP-3855) (#1705)
      
      * First draft to refactor `RiskRepository` away and persist risk level results produced by ExposureWindow calculations.
      
      TODO: Tests, Legacy data migration, Persist ExposureWindow's in tester builds.
      
      * Unit tests for refactored classes.
      
      * LINTs
      
      * First draft for legacy risk data migration.
      
      TODO: Tests.
      
      * Store exposure windows on device for tester builds and perform clean on them too after risk result deletions.
      Split RiskResultStorage such that the exposure window storage code is only available in deviceForTesters flavor builds.
      
      * simplification
      
      * no preference should return no value
      
      * Remove TODOs, singletons are refactored away ;)
      
      * Simplify RiskLevelTask interface
      
      * Split risk level storage implementations to let production (device flavor) have a NOOP for storing/deleting exposure windows.
      
      * Remove unused storage function.
      Add test skeletons.
      
      * unit test
      
      * unit test
      
      * Update risk card to show new window mode based information.
      
      * Fix test regressions.
      
      * Address PR comments.
      
      * LINTs
      
      * Everybody get's LINT for XMAS.
      
      * Finish unit tests and remove unused classes.
      
      Co-authored-by: default avatarchris-cwa <chris.cwa.sap@gmail.com>
      Unverified
      2547e10a
  2. Nov 23, 2020
  3. Nov 20, 2020
  4. Nov 19, 2020
  5. Nov 18, 2020
    • chris-cwa's avatar
      Removed enf v1 exposure summary and tokens (EXPOSUREAPP-3538) (#1644) · a96bb279
      chris-cwa authored
      
      * activate WindowExposure mode
      
      * extirpated tokens!
      
      * detekt, ktlint
      
      * fixed tests
      
      * - v1 methods
      
      * - get v1 exposure summary
      
      * - fixme
      
      * updated exposure summary repo
      
      * Adding mock dependencies that are required to instantiate the worker factories in our binding test.
      
      * Added numberOfDaysWithHighRisk and numberOfDaysWithLowRisk
      
      according to new tech spec
      
      * Transformed minimumDistinctEncountersForRisk and mostRecentDateForRisk into extension fun
      
      * make sure list of windows and aggregated result belong together
      
      * sending values for current UI
      
      * fixed ktlint
      
      * renamed ExposureResultStore
      
      * fixed tests
      
      Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>
      Co-authored-by: default avatarBMItter <berndus@gmx.de>
      Unverified
      a96bb279
  6. Nov 16, 2020
  7. Nov 11, 2020
  8. Nov 04, 2020
  9. Nov 02, 2020
  10. Oct 29, 2020
    • Ralf Gehrer's avatar
    • BMItter's avatar
      Improved crash logging & handling (EXPOSUREAPP-2572) (#1475) · be4c773d
      BMItter authored
      
      * FileLoggerPlus - RX added - preparation
      
      * Buffer config as constants
      
      * avoid empty lines
      
      * Reworked logging to file - wip
      
      * Collecting errors to dao - wip
      
      * Added crash report to app db and created module
      
      * do it
      
      * inject crashReportTree - wip
      
      * use dagger injection
      
      * retrieve short hash via gradle
      
      * removed todo
      
      * Updated database to version 2 for new ReportEntity - old base
      
      * deprecated old engagement - RX not allowed anymore
      
      * use global scope for coroutines in crash report tree - ktlint clean
      
      * added menu item - error reporter (replace later to new structure)
      
      * basic recylcerview and fragment added to menu - wip
      
      * deprecated data class
      
      * Delete CrashModel.kt
      
      * crash report list item to use data binding
      
      * separated Reporteradapter - klint clean
      
      * use separated Adapter in ReporterFragment - cleanup
      
      * Added ErrorReporterViewModel - connected data to list
      
      * dependency injection for crash report, better structure, todo cleanup
      
      * some refactoring, cleanup, ktlint
      
      * adjustments for 1.6.x
      
      * temp action to open crash report fragment
      
      * removed testcode
      
      * updated layout - wip
      
      * connected view & data
      
      * satisfy circle ci checks
      
      * plant reportingTree, testbutton, klint clean
      
      * updated layout for reporter - wip
      
      * better format and layout
      
      * better message handling
      
      * missing icons for errors on debug
      
      * Adjusted error report index
      
      * Removed ugly show button, report clickable
      
      * Added SettingsCrashReportDetailsFragment & corresponding files
      
      * fixed merge inconsistence
      
      * fixed injection overall
      
      * use livedata
      
      * details added to report - wip
      
      * beauty
      
      * share & layout root preparation
      
      * make error report shareable
      
      * removed Dispatcher.IO for example
      
      * Introduce skeleton classes for bugreporting
      
      * Refactoring, adjustments to be able to build again
      
      * Created BugEventEntity, Changed id to Long for more efficiency,  Removed unused events
      
      * refactored ui to deviceForTesters, testmenu etc
      
      * adjusted interfaces & related, better structure
      
      * uses own db, added converter, adjusted modules
      
      * adjusted bugrepo, defaultbugrepo
      
      * shared report, better visualisation
      
      * changed crash db name
      
      * Implemented DefaultBugRepository
      
      * Added device info to BugEvent, BugReporter collects Tag, Added default impl of BugEvent etc
      
      * corrected bug in RollingLogHistory
      
      * removed deprecated crash package
      
      * quickfix - wip
      
      * cleanup
      
      * cleanUp, adjusted simulation button to new structure
      
      * moved bug related layouts to deviceForTesters package
      
      * removed old RX dependenies and related context
      
      * fix build for deviceDebug
      
      * lint clean
      
      * current set of relevant exceptions as before
      
      * attach log to output
      
      * improved output
      
      * Delete obsolet ic_bug in main
      
      * Delete ic_coffee.xml
      
      * changed shortID to shortCommitHash for better transparency
      
      * companion to bottom
      
      * removed string encapsulation
      
      * cleanup unused import and blank line - PR Comment
      
      * typo fixed
      
      * rm empty line
      
      * removed relict module
      
      * layout fix
      
      * adjusted unrelated method call
      
      * fixed package inkonsistence
      
      * Use flow instead of livedata in non-ui
      
      * better fun naming
      
      * Replaced interface with inline listener
      
      * Improved SettingsCrashReportDetailsFragment and SettingsCrashReportViewModel, formatting adjusted
      
      * cleaned converter
      
      * Delete Project.xml
      
      * added log statement to DefaultBugRepository
      
      * adjusted magical number
      
      * Use CommonConverters instead of unique Converters in BugDatabase
      
      * Extension function for the resuce -defaultBugRepository
      
      * removed FormatterCrashReport completly
      
      * changed long to UUID
      
      * satisfy buggy ktlint checks
      
      * Update SettingsCrashReportViewModel.kt
      
      use postvalue
      
      * avoid passing viewmodel
      
      * store appVersionCode as Long for beeing futuresave
      
      * Update SettingsCrashReportViewModel.kt
      
      removed lazy init
      
      * Changed BugDatabase to factory pattern
      
      Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>
      Co-authored-by: default avatarharambasicluka <64483219+harambasicluka@users.noreply.github.com>
      Unverified
      be4c773d
  11. Oct 28, 2020
  12. Oct 27, 2020
  13. Oct 26, 2020
  14. Oct 23, 2020
  15. Oct 19, 2020
    • Matthias Urhahn's avatar
      Refactor missused ViewModels, support automated UI tests and screenshots (EXPOSUREAPP-2946) (#1415) · cec56fdb
      Matthias Urhahn authored
      
      * Introduced `TracingCardState` and `TracingDetailsState`.
      Removed all direct viewmodel/livedata access from all nested layouts for `TracingViewModel`.
      Removed `FormatterRiskHelper`.
      Introduced logic to reactively update the UI state if bluetooth, location or tracing state changes.
      
      TODO:
      * Finish tests in TracingCardStateTest.kt and TracingDetailsStateTest.kt
      * Finish TracingDetailsViewModel.kt and TracingCardViewModel.kt
      * Remove obsolete dependencies on TracingViewModel.kt and singletons RiskLevelRepository.kt, TracingRepository.kt
      
      * Breakthrough, cards update again.
      
      * Further cleanup of TracingViewModel.kt, TracingRepository.kt
      Still not quite there yet, too many calls going into every direction, back and forth, instead of just top->down, but we are getting there.
      We want data flow from business logic code to the UI, keep the UI KISS.
      
      * Update TracingCardState tests to account for changes
      
      * More refactoring, TracingViewModel.kt is now finally gone.
      
      * Fix risk details card, we reuse the cardviewmodel but need to overwrite the `showDetails` flag depending from where it's used.
      
      * Refactored several properties (notification related) out of SettingsViewModel/Repository
      
      * Fix injection
      
      * Refactoring submission related databinding code on the home fragment
      
      * Make TracingRepository.kt injectable and change viewmodel scoping for refresh calls to app scope.
      
      * Remove additional formatter calls from submission cards on home screen.
      
      * Refactored additional SubmissionViewModel logic into SubmissionRepository on the Homescreen.
      First UI Test is now passing.
      
      Simplified ViewModel instantiation related code.
      Prepared HomeFragment for smoother UI state changes, less reloading.
      
      * Improved home,tracing-details and tracing-settings loading behavior, less flickering.
      Fixed LiveData value assignment on background-thread.
      
      * New reactive provider for Bluetooth and Location status.
      Cleaned up ConnectivityHelper.kt partially.
      
      * Implement remaining tests, batch 1.
      
      * Implement remaining tests, batch 2.
      
      * Fix lint issues.
      
      * Removed a few codesmells and code duplication.
      Introduced Flow.shareLatest(...)
      
      * Removed unused parameters.
      
      * LINT fixes.
      
      * Fix unit test failing due to missing mocks.
      
      * Address PR comments.
      
      * Improve UI loading states, remove flickering.
      
      * Remove log spam due to polling values, add extra abort condition that checks for cancellation.
      
      Co-authored-by: default avatarralfgehrer <mail@ralfgehrer.com>
      Unverified
      cec56fdb
  16. Oct 15, 2020
  17. Oct 14, 2020
  18. Oct 13, 2020
  19. Oct 12, 2020
  20. Oct 09, 2020
  21. Oct 08, 2020
  22. Oct 07, 2020
  23. Oct 06, 2020
  24. Oct 02, 2020
    • Ralf Gehrer's avatar
      Translation delivery and default strings (DEV) (#1298) · b0b24ae1
      Ralf Gehrer authored
      
      * [INTERNAL] Translation delivery: commit by LX Lab (#1296)
      
      Change-Id: Ic1777f41c4667ffe4057f87dfb2d1415036688ba
      
      Co-authored-by: default avatarharambasicluka <64483219+harambasicluka@users.noreply.github.com>
      
      * Update default strings
      
      * Update Link language tag
      
      * Fix missing IDs
      
      * re-add placeholder
      
      * re-add placeholder
      
      Co-authored-by: default avatarSAP LX Lab Service Account <tmsatsls+github.com_service-tip-git@sap.com>
      Co-authored-by: default avatarharambasicluka <64483219+harambasicluka@users.noreply.github.com>
      Unverified
      b0b24ae1
    • Matthias Urhahn's avatar
      Reduce code duplication (EXPOSUREAPP-2844) (#1286) · d64a5825
      Matthias Urhahn authored
      * Remove code duplication between different flavors.
      Remove extra MainFragment and NavGraph.
      Introduce TestMenu indirection
      Add logic for splitting test code up into extra fragments.
      
      * Style list items a bit :)
      
      * fix lints
      
      * Detekt *hug*
      
      * We can only show the menu entry if we are actually on the right flavor,
      otherwise, in deviceDebug, we would not have access to the right resources.
      
      * Address PR comments
      
      * Fix wrong XML namespace.
      Unverified
      d64a5825
    • chris-cwa's avatar
      Legal Texts (EXPOSUREAPP-2954 , EXPOSUREAPP-2951, EXPOSUREAPP-2942,... · eb382edf
      chris-cwa authored
      Legal Texts (EXPOSUREAPP-2954 , EXPOSUREAPP-2951, EXPOSUREAPP-2942, EXPOSUREAPP-2938, EXPOSUREAPP-2931, EXPOSUREAPP-2925, EXPOSUREAPP-2924, EXPOSUREAPP-2923, EXPOSUREAPP-2922, EXPOSUREAPP-2920, EXPOSUREAPP-2919, EXPOSUREAPP-2918, EXPOSUREAPP-2917) (#1270)
      
      * text body from EXPOSURE_APP 2740
      
      * line breaks
      
      * - duplicate values
      
      * Interoperability: Make Changes to User Consent Text (Initial Onboarding) (EXPOSUREAPP-2938) (#1276)
      
      * 2938 updated legal strings in defaults, de & tr
      
      * added translatable false
      
      * updated german strings (#1278)
      
      * nex text for EXPOSUREAPP-2942
      
      * Legal Textchange: Exposure Logging Screen (EXPOSUREAPP-2923) (#1280)
      
      * Legal Textchange: Home Screen - FAQ Section (EXPOSUREAPP-2922) (#1281)
      
      * Legal Textchange: Initial Onboarding (EXPOSUREAPP-2920) (#1282)
      
      * Legal Textchange: Test Result Screen (EXPOSUREAPP-2918) (#1283)
      
      * Legal Textchange: Info Screen (EXPOSUREAPP-2917) (#1284)
      
      * update string (#1288)
      
      * kEA-2942
      
      * Legal Textchange: New Eula (Nutzungsbedingungen) (EXPOSUREAPP-2951) (#1285)
      
      * updated eula
      
      * updated tr & en eula with german
      
      * Interoperability: Changes to Data Privacy (EXPOSUREAPP-2954) (#1287)
      
      * Interoperability: Make Changes to User Consent Text (Key Upload) (EXPOSUREAPP-2942) (#1275)
      
      * 2942 - strings updated and added to new legal string file
      
      * removed tr strings, to fix circle ci error.
      
      * added translatable false
      
      * Follow up: Initital onboarding 3rd & 6th paragraph (EXPOSUREAPP-2920) (#1289)
      
      * updated & added strings
      
      * updated 6th paragraph
      
      * Legal Textchange: Cross Country Exposure Logging Screen (EXPOSUREAPP-2924) (#1279)
      
      * updated & added strings
      
      * text under countries added
      
      Co-authored-by: default avatarRituraj Sambherao <git.rituraj.sambherao@gmail.com>
      
      * Interoperability: Delta Onboarding (EXPOSUREAPP-2931, EXPOSUREAPP-2919) (#1277)
      
      * 2931 text update
      
      * move to legal text & update 2919
      
      * delta onboarding text changes for initial text
      
      Co-authored-by: default avatarOliver Zimmerman <oezimmerman@gmail.com>
      
      * Legal Textchange: Delta Interop Screen (EXPOSUREAPP-2919)  (#1294)
      
      * 2931 text update
      
      * delta onboarding text changes for initial text
      
      * Added new legal texts and navigation to terms.
      
      - adjused xml layout
      - added required strings
      - created navigation to legal terms in both nav graphs
      - created navigation in fragment
      
      * Update OnboardingDeltaInteroperabilityFragment.kt
      
      * Update OnboardingDeltaInteroperabilityFragment.kt
      
      Co-authored-by: default avatarLuka Harambasic <luka.harambasic@sap.com>
      
      * fixed wrong implementation regrading user consent in warn others
      
      Co-authored-by: default avatarharambasicluka <64483219+harambasicluka@users.noreply.github.com>
      Co-authored-by: default avatarRituraj Sambherao <git.rituraj.sambherao@gmail.com>
      Co-authored-by: default avatarOliver Zimmerman <oezimmerman@gmail.com>
      Co-authored-by: default avatarLuka Harambasic <luka.harambasic@sap.com>
      Unverified
      eb382edf
  25. Sep 29, 2020
  26. Sep 28, 2020
    • BMItter's avatar
      Interoperability: List of Countries can not be loaded for 1.5.x in new... · 4ed5be02
      BMItter authored
      Interoperability: List of Countries can not be loaded for 1.5.x in new onboarding / interop (EXPOSUREAPP-2744) (#1232)
      
      * interop nofetch riskdetails, corresponding layout and vector
      
      * updated res to new no country spec
      
      * nofetch fetch layouts
      
      * Create include_interoperability_old.xml
      
      * removed old stuff
      
      * fixed Fixed include_interop_participating_countries_fetch for 1.5.x
      
      * adjusted logic from old base to fit 1.5.x, Converted countryList to LiveData
      
      * showing fetch or no fetch view in include_interoperability.xml, use github name as author
      
      * cleanup & refactor, fixed layout switch issue, wip
      
      * ids cleanup
      
      * system settings delegation according to design spec
      
      * improved countrylist handling for interopConfig Connectivity Settings
      
      * updated string translation tags
      
      * satisfy lint
      
      * satisfy CircleCi
      
      * fixed wrong layout visibility
      
      * delta test disabled, referenced ids adjusted
      
      * FormatHelper as requested
      
      * fix capital letter
      Unverified
      4ed5be02
Loading