- Jan 25, 2021
-
-
Mohamed Metwalli authored
* Migrate to dagger2 assisted injection * bump version * Fix Worker test * Fix failing test * Remove Square AssistedInject from Technical file * Set nav-graph in Ui Thread to prevent crashing * bump dagger to 2.31.2
-
- Jan 11, 2021
-
-
Matthias Urhahn authored
-
- Jan 08, 2021
-
-
Chilja Gossow authored
Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
Matthias Urhahn authored
Remove @dimen/match_constraint as it will be replaced by tooling with 0dp whenever used and thus adds noise. (#2055)
-
- Jan 07, 2021
-
-
Matthias Urhahn authored
Long methods are not generally bad and should be decided on a case by case basis in PR reviews.
-
Matthias Urhahn authored
* Initial draft for user accessible debug logs in production. TODO: Sharing, Tests, Cleanup FileLoggerTree? * Ready strings for translation. * Log file compression for sharing (zip). * Add log sharing * Change how DebugLogger is initialized to make sure we can record issues that happen very early in the apps lifecycle. * Add missing toolbar back arrow navigation. * Fix initial delay for ui state emissions. * Censor registration token. * Adjust warning regarding sensitive data in debug logs. * Use property injection instead of component getters. * Hide option until greenlit. * Add test for RegistrationTokenCensor * Unit tests. * Make unit test without triggerfile more specific. * LINTs * Fix missing injection provider in release mode. * Fix regtoken censor if condition. * Fix typos. * Remove empty manifest specific to deviceForTesters build. * Wait until log job is canceled before deleting log files. Otherwise a race condition could lead to file creation after job cancellation. * Replace runBlockingTest with runBlocking we don't need scheduler control and runBlockingTest is sometimes unreliable. * Refactor FileSharing to use compat builder from androidx. * Handle exceptions on debug log start() * Print device infos when log is started. * Text changes requested by UA Co-authored-by:
ralfgehrer <mail@ralfgehrer.com>
-
- Jan 05, 2021
-
-
Matthias Urhahn authored
* Introduce lastSubmissionUserActivityUTC settings and use it as "skip condition" for the SubmissionTask * Introduce background submission. * Fix worker not being canceled. * Disable auto submission is consent is not given. * Cancel worker by tag. * Introduce per TaskRequest error-handling. Set SubmissionWorker deployed task requests to SILENT. * Fix test regressions due to api change. * Add SubmissionWorker test. * Add AutoSubmissionTest.kt * Don't reset retry attempt count and date when enabling MONITOR or SUBMIT_ASAP. Otherwise would loose that data when the app is restarted despite it still "trying". Only reset the data on DISABLED, i.e. when the task finishes or give sup. * Add additional SubmissionTaskTest.kt related to automatic submission behavior. * Remove unused value. * Fix typo * Return Result.retry() on exceptions. We retry until we are successful, any abort conditions will be handled by the task. * LINTs * Fix test regression.
-
- Dec 28, 2020
-
-
Matthias Urhahn authored
* Add state-aware illustrations for Settings>BackgroundModeStatus Refactor various background mode related functions into a common class that can be injected and observed. * Rename c to context * Use core-ktx extension to access system services * Fix wrong import statement and a typo * Add more test cases Co-authored-by:
Mohamed Metwalli <mohamed.metwalli@sap.com>
-
- Dec 23, 2020
-
-
Matthias Urhahn authored
* Let the AppConfig validity check use absolute values, to support device time check behavior. * Add mapping for "disable-device-time-check" to app config. * Show popup dialog if the device time is invalid. * Remove extra retrofit cache (use only LocalAppConfigSource.kt) * Exposure device time check * Reset user acknowledgement * LINTs * Add test menu option to disable device time check via affecting the config mapping. * Download, but don't submit keys if device time is incorrect. Abort risk level calculation if time is incorrect. * Due to multiple properties in ConfigData affecting `isDeviceTimeCorrect`, make it a body property and don't allow overriding via constructor. * Add unit test for test settings affecting the device config only in tester builds. * Show notification regarding incorrect time when device is in the background. * Fix test regressions and add additional test cases for download and risk task abort conditions on incorrect device time. * Fix merge regressions. * Add time unit to log statement. * Fix incorrect time dialog showing in a loop when entering leaving the home screen. * Remove unused code path for clear(). * Print additional timestamps to help debugging efforts in the future.
-
Matthias Urhahn authored
* Don't log all exposure windows on `RiskLevelTaskResult.toString()` due to performance impact when logging. * Add RiskLevelResult flow optimized for just getting the latest two results. * Share risk level result subscriptions. The delay when switching from Home to RiskDetails fragment will be bridged and no re-loading necessary. * Fix test regressions * Remove test code. * Introduce specific query for "latestAndLastSuccessful". Add unit tests for SQL queries. * Fix test regressions due to missing mocking. * Address merge conflicts. * Fix instrumentation tests not building. Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
Rituraj Sambherao authored
* Text Color changed * Text Color changed for calendar screen * removing build.gradle changes that carried over from 1.10 * lint fix * adapt color scheme to be consistent and high contrast * klint Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com> Co-authored-by:
Chilja Gossow <49635654+chiljamgossow@users.noreply.github.com> Co-authored-by:
chilja <chiljamgossow@gmail.com>
-
- Dec 22, 2020
-
-
Matthias Urhahn authored
* Refactor home-screen and tracing details fragment. * Use recycler view to display list items * Remove nested/included layouts and make Android Studio layout previews functional * Split list items into independent elements (positive/negative/pending) * Layout cleanups & flattening * Small padding and alignment fixes * Clean up tests and fix class names. * Move UI classes towards "package by feature", each feature has their own ui package. * LINTs * Fix log statements. * Only crash in tester builds. * Update Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/main/home/HomeAdapter.kt Co-authored-by:
fynngodau <fynngodau@mailbox.org> * Refactor adapter init. * LINT * Remove "card" from property name, the "TracingStateProvider" is UI agnostic. * LINTs * Don't show the risk card if there is a positive test result. * Fix crash on init with unknown resource IDs (before data binding is available). * Fix progress card not being colored in risk details fragment * LINTs * Prepare viewholders for payload use. * Update Corona-Warn-App/src/main/res/layout/home_fragment_layout.xml Co-authored-by:
fynngodau <fynngodau@mailbox.org> * Improve toolbar and tracing bar behavior, scrollable, fewer nested layouts. * Adjust popup theme. * Remove color state list for cards, click behavior is done via `selectableItemBackground` * Fix visual artifact when expanding toolbar menu. * Align box coloring in dark mode and click animation. * Fix flickering Test and FAQ card. * Fix missing "enable tracing" button in home card. * Fix risk/tracing details elevation/dividers in light and dark mode * Resolve merge regressions and include contact diary card via recyclerview. * Adjust toolbar background color to new mockups (diary mockups have lighter darkmode). * Update Corona-Warn-App/src/main/res/layout/home_card_container_layout.xml Co-authored-by:
fynngodau <fynngodau@mailbox.org> * Update Corona-Warn-App/src/main/res/layout/tracing_content_failed_view.xml Co-authored-by:
fynngodau <fynngodau@mailbox.org> * Tint card background color. Just replacing the background didn't ahve the desired effect. * Fix possible NPE on last encounter calculation. * LINTs and typos. Co-authored-by:
fynngodau <fynngodau@mailbox.org>
-
- Dec 17, 2020
-
-
Chilja Gossow authored
* Merge branch 'feature/4152-contact-diary' of https://github.com/corona-warn-app/cwa-app-android into feature/4152-contact-diary # Conflicts: # Corona-Warn-App/schemas/de.rki.coronawarnapp.contactdiary.storage.ContactDiaryDatabase/1.json # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/DataReset.kt * clean up DI * add recycler view * clean up * new texts * clean up * clean up * background, dialog * klint * klint * klint * review comments * review comments * review comments * Merge branch 'feature/4152-contact-diary' into feature/4161-4162-edit-person-location # Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/contactdiary/ui/onboarding/ContactDiaryOnboardingFragment.kt
-
AlexanderAlferov authored
* Data retention with test fragment and tests * Formatting * Minor fix * Removed unnecessary injection * Resolve merge conflicts * Adjusted Tasks with tests * Formatting * Refactoring
-
- Dec 14, 2020
-
-
Matthias Urhahn authored
* Fix crash when trying to update TEK history without tracing enabled. Refactor tracing permission requests and then re-use the tracing permission requests within the TEK updater logic. * Fix test regressions. * Implement additional unit tests for TEKHistoryUpdater.kt * Additional unit tests for ENF related permission requests. * Additional tests for TEKHistory Updater/TracingPermission callbacks. * Additional tests for TracingPermissionHelper.kt handleActivityResult calls.
-
- Dec 10, 2020
-
-
Matthias Urhahn authored
* Fix TEK Storage item sorting. * Remove legacy test fragment, add necessary features to other fragments. * LINTs Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
- Dec 08, 2020
-
-
Matthias Urhahn authored
* Add email share feature to submission test menu. * LINTs * Fix duplicate TEK history calls. * LINTs * Fix TEKStorage live update and adjust export format. * Fix LINT
-
- Dec 07, 2020
-
-
chris-cwa authored
* fixed: fields without values are visible; + logs * detect version update, force recalc on 1.7 -> 1.8 * detect version update in diagnosis keys task only * no connection type ignoring * Add test to ensure that parsing old configs from 1.7.x fails and the default fallback for 1.8.x is used. * Fix logging typo. * no wasLastDetectionPerformedRecently abort on app update * Fix lint issues * fixed condition * used shared settings * get last encounter at from enf v1 to display second line after app update while risk level calc is not finished * fixed di * fixed tests * fixed tests * fixed tests * Add unit tests for DownloadDiagnosisKeysTask.kt * fixed tests * Add tests for DownloadDiagnosisKeysSettingsTest Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
- Dec 03, 2020
-
-
Matthias Urhahn authored
* Submission upload, first draft. Storing Symptoms and TEKs. TODO: * Change upload task to use stored data. * Blocking upload task * Tests * Update symptoms on each screen. Integrate permission request and automatic TEK history update. TODO: * Cancel dialog * Blocking upload task * Tests * Add submission on cancel behavior. * LINTs and unit tests. * Hooking up navigation and first break through on TAN based submission. * Hook up navigation for QR Code to test result without consent. * Fix positive result consent given submission: Abort to Main Screen * Restore default environment. * Adjust notification target fragment. * Address LINTs * Clean up symptoms introduction nav actions. * Fix tests
-
- Dec 02, 2020
-
-
Rituraj Sambherao authored
* Andere Warnen screen added * Merge conflict resolve and screen stability improvement * string text header added to ensure translation * using submitTaskState instead of API request state * onDataPrivacyClick() function added in the relevant viewModel * long strings divided * legal strings updated * added navigation to mainfragment removed unnecessary cases fixed colors for under16 layout fixed country list in layout added onDataPrivacyClick method in own ViewModel refactored color value * minor changes in navigation
-
- Dec 01, 2020
-
-
Matthias Urhahn authored
* Remove "lastTimeDiagnosisKeysFromServerFetch" and replace it with less missleading data. While it was called "lastTimeDiagnosisKeysFromServerFetch" it was actually "last time we submitted keys to google". * To decide whether to refresh in "onResume", we now use "has there been any submission to the ENF?" * To display a timestamp on the risk card, we take the last successful submission to the ENF as the risk card displays the calculation results based on the latest submission. While we could use the last calculated risk level result timestamp, we currently also trigger risk calculations if there are no new submissions to the ENF, which would mean the timestamp is updated even though the result is not based on new data. I've also fixed the test fragment button behavior and added descriptions, the "Reset risk level" button surfaced the initial issue because it behaved like a "do a 75% data reset" button. * Tests and LINTs Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
Matthias Urhahn authored
Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
- Nov 30, 2020
-
-
Matthias Urhahn authored
* Fix displayed details in tracing inactive states. * Simplified UI states. Replaced RiskLevel and RiskLevelConstants with RiskState { LOW; HIGH, FAILED }. * Fix low risk card missing the encounters if there have been more than 0. * Fix missing card divider/border on error cards in light mode. * Fix merge regression. * LINTs * Fix progress card colors on white card background color. * Fix progress card colors on white card background color. * Don't allow negative active tracing days. * Revert sync behavior (extra PR) * Address PR comments. Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
- Nov 27, 2020
-
-
BMItter authored
* Use lastRiskResult from DB * use correct format for windows and timestamp * klint * Reduce RiskLevelResult Storage API and fill exposure windows in risk result if available. * Default exposure windows to null while mapping * Don't add empty exposure windows list to risk results * fix broken tests * Added tests for exposure windows Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
- Nov 26, 2020
-
-
Kolya Opahle authored
* Converted ExposureWindows to their json wrapper counterparts before exporting to give the json fields proper names instead of the obfuscated enf ones Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Added timestamp to exposure window export * Switched to a more file name compatible DateTimeFormat Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * ktlint says these are redundant, i don't like it but the overlords forced me to do it. Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * changed filename suffix to json Co-authored-by:
BMItter <berndus@gmx.de>
-
- Nov 25, 2020
-
-
Alex Paulescu authored
* Removed traces of grey risk card. * Removed UNKNOWN_RISK_INITIAL constant. * Removed unused method. * Removed old comments. * Introduce risklevel calculation failure state to get consistent card states. * Cleaned up the risk card states. Refactored "RiskLevel" to be calculated based on either result or failure reasons. Added the new "no internet" error card. * Updated color states. * Fixed card color issues. * Fixed detekt issues. * Remove test for deleted file. * Fix test regressions. * Fixed tests and LINTs. Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Kolya Opahle authored
Risk Calculation does not work because DiagnosisKeysDataMapping is not applied (EXPOSUREAPP-3895) (#1690) * We now check for the DiagnosisKeyDataMapping and apply it to the ENFClient if changed Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Moved diagnosisKeysDataMapping to windowProvider Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Renaming and linting Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Moved app config fetch to key provide task, added error handling, added logging to config replace Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Fixed old unit tests and implemented tests for config comparison, TestForAPIFragment is currently broken Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Linting * Added more unit testing for DefaultDiagnosisKeysDataMapper and fixed TestForAPIFragment Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Update default app config to latest version This includes a change for the default for reportTypeWhenMissing from 0 to 1, as 0 is not accepted by setDiagnosisKeysDataMapping. https://github.com/corona-warn-app/cwa-app-tech-spec/pull/10/commits/090801921f4a8581543a9f716fd0572c12901c71 https://github.com/corona-warn-app/cwa-protocol-buffers/commit/38a641e2a808c41d225e9fd09d27ec7959551412 * Fixed Unittests Co-authored-by:
Maximilian Lenkeit <maximilian.lenkeit@sap.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
BMItter authored
* preparation share exposureWindows via email etc. - wip * Exposure Windows can be shared if data is availabe * Manifest and provider path deviceForTesters only * fixed strange conflicts * klint * Pretty exposure window export * removed testlog * removed relicts
-
Matthias Urhahn authored
Persist ExposureWindow based risk level calculation results and update the UI (EXPOSUREAPP-3910,EXPOSUREAPP-3855) (#1705) * First draft to refactor `RiskRepository` away and persist risk level results produced by ExposureWindow calculations. TODO: Tests, Legacy data migration, Persist ExposureWindow's in tester builds. * Unit tests for refactored classes. * LINTs * First draft for legacy risk data migration. TODO: Tests. * Store exposure windows on device for tester builds and perform clean on them too after risk result deletions. Split RiskResultStorage such that the exposure window storage code is only available in deviceForTesters flavor builds. * simplification * no preference should return no value * Remove TODOs, singletons are refactored away ;) * Simplify RiskLevelTask interface * Split risk level storage implementations to let production (device flavor) have a NOOP for storing/deleting exposure windows. * Remove unused storage function. Add test skeletons. * unit test * unit test * Update risk card to show new window mode based information. * Fix test regressions. * Address PR comments. * LINTs * Everybody get's LINT for XMAS. * Finish unit tests and remove unused classes. Co-authored-by:
chris-cwa <chris.cwa.sap@gmail.com>
-
- Nov 24, 2020
-
-
Matthias Urhahn authored
-
Matthias Urhahn authored
-
Matthias Urhahn authored
-
- Nov 23, 2020
-
-
chilja authored
-
- Nov 20, 2020
-
-
BMItter authored
Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
chris-cwa authored
* updated test api fragment to display exposure windows * do not show dummy text on device * removed it
- Nov 19, 2020
-
-
Matthias Urhahn authored
-
BMItter authored
* Show aggregated risk result in testmenu riskCalculationFragment * Use extention fun to build string for aggregated result * Show exposure window count and exposure windows as json + fixed a layoutbug with cut off * satisfy lint * Use real values * Connected ExposureResultStore * ENF v2 Calculation adjusted Testmenu Entry for v2 * Adjusted to ExposureResultStore changes * Added logs * Removed and adjusted some old stuff * Made backend parameters a little bit better readable * its better this way * Created additional risk calc info * Refactoring * sourcecheck clean
-
chris-cwa authored
* inject enf client and exposure result store * Fix klint. Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Kolya Opahle authored
-