- Oct 05, 2020
-
-
Matthias Urhahn authored
* Add coroutine dispatcher injection to deal with flaky tests. We need to be able to replace Dispatchers.IO in tests, and that requires providing the dispatcher via injection. * Linting * Replace remaining static access of Dispatchers.IO.
-
Matthias Urhahn authored
* Better handling of unexpected supportedCountryData from the server. Perform sanity checks on country data. Map values to known `Country` enum. * Fix unit test regression. * Fix unit test regression.
-
- Oct 02, 2020
-
-
Matthias Urhahn authored
* Support for EUR key packages depending on the enabled environment. * Refactor names and fix tests. * Refactoring names and added missing enum key test. * Additional refactoring. Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
Matthias Urhahn authored
* Define environment for each flavor and build type. * Add smart LiveData class that does async initialization (not on the main thread). * View extensions setGone/setInvisible * Refactor test for api fragment. * Replace ALT environment with a list to select from. * klint * Fix tests * Fix tests * Further flaky test fixes. * Move the debug check for isLast3HourModeEnabled to the settings. The KeyFileDownloader.kt shouldn't be aware of that detail. The settings are what is affected by the build flavors/modes. * Code cleanup and UI improvement of fragment_test_for_a_p_i.xml * Code that retries flaky tests until we found a better solution. Not great, Not terrible... Co-authored-by:
Mert Safter <mert.safter@sap.com>
-
chris-cwa authored
Interoperability: Submit days since onset of symptoms, Add 15th key to transmission risk vector (EXPOSUREAPP-2748, EXPOSUREAPP-2686) (#1223) * Update proto file to generate TemporaryExposureKey and fix visibility * Introduce placeholder and model for days since onset of symptoms * EXPOSURE_APP_2686 (wip) * fixed annotation * fixed compile error * Implement determinator for days since onset of symptoms in accordance with the risk vector determinator * extracted index calc * add 15th key * get index * Reverse order of days since onset of symptoms vector to align index with risk vector * updated behaviour * fixed today * - false thinking * implemented days ago * detekt + ktlint * not needed * fixed index into vectors * https://github.com/corona-warn-app/cwa-app-android/pull/1223#discussion_r494957683 * tests * Move vector length to determinator and fix test * Fix test and ktlint * improvements suggested in PR * use UTC, improved tests * tests with gap and several keys in one day * more unit tests + fixed a bug in age of days * test transmission risk vector * Improve test readabilty and switch to Junit5 * inject it * End of class please. * fixed tests * remove magic number * fixed tests * fixed test * fixed test * Fix lint issues * Add java doc with link to the documentation. * Fix tests * fixed test * ktlint Co-authored-by:
ralfgehrer <mail@ralfgehrer.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Matthias Urhahn authored
If there is no fallback appconfig yet, abort early to show a more accurate error (download error vs "no app config" error). (#1293) Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
- Oct 01, 2020
-
-
chris-cwa authored
-
Matthias Urhahn authored
* Fix unreliable test. Random could be randomly 0 which would fail the test. * Create types for buildflavors to prevent string comparison. Use these build variants for specific tests. * Don't assign the times variable to a final value as it breaks tests. Until refactored, it's okay to recalculate this. * Remove a few sonar code smells. * Fix broken instrumentation test for key verification. Add matching binary, signature and pubkey from pod.
-
- Sep 30, 2020
-
-
Matthias Urhahn authored
* Update protobuf format * Addition of contentToFederation and visistedCountries/supportedCountries. TODO: Unit tests, pull supportedCountries from AppConfig (waiting for #1213) * Fix invalid package being assigned. This would break daggers annotation processing as the class could not be resolved. * Improved existing and implemented new tests. * Fixed test regression due to refactoring. * Integrate pulling the supportedCountries data from the AppConfig for the submission transaction. (Previously wasn't implemented yet, now it's merged) * Address merge conflicts, and a little refactoring, and a bit more tests. * Revert file change to Project.xml * AppConfigProvider should insert "DE" as fallback if the supportedCountry list is empty/not supplied. * Don't insert the fallback country at application config provider level. The UI requires the list to be empty, if it is empty in the config. I've moved the fallback country insertion into the transaction. * Make detekt happy. * Make klint happy.
-
- Sep 29, 2020
-
-
Matthias Urhahn authored
* Move AppConfig related code into it's own package. * Use "files" instead of "cache" for storing our AppConfigApiTest. * Add "files" to "cache" migration. * Refactor CDN related code into an independent "environment module". TODO: UnitTests, Fallback behavior even if cached AppConfig is stale. * Further structure refactoring and unit test for app config cache migration. * Added config fallback behavior for all cases + additional tests. * Improve code readability. * First POC for multi-environment support. * logic for ACME test Countries toggle button in Dev menu * ACME Test Countries dev menu * Additional clean up and refactoring on build constants. * Cleaned up the test fragment a bit. * Fixed detekt issue * Fix flaky test that depends on build variant. * Let the test fragment show us the actual environment we toggled to. * Changes upon review * Address PR comments. Co-authored-by:
Rituraj Sambherao <git.rituraj.sambherao@gmail.com>
-
Matthias Urhahn authored
Perform data reset for users already affected by the encryption issues (EXPOSUREAPP-1851/EXPOSUREAPP-2958) (#1256) * A reset mechanism that performs a data reset for those (and just those) already affected by the pre 1.4.0 encryption error. If encountered the preference and database file will be deleted, then we will retry to generate an EncryptedSharedPreferences instance, and show the user a popup about what happened. TODO: This still has placeholders for the popup dialog. * Change detekt config. Early returns help code readability if used as guard closes. * Add final texts and fix missing dialog in other build flavors. * Additional test that we also match nested exceptions. * Fix incorrect shared preferences path. * Make klint happy. * Address PR comments. Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
BMItter authored
* test enhancement for interop and countrylist, added liveDataTestExtension * better test naming, removed one assert Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
Alex Paulescu authored
* Added country list to submission of keys screen * Ktlint changes * Added missing s * Added text changes * Removed file from wrong location * Reverted back to old way of instantiating countryList in SubmissionViewModel * Removed hardcoded spacing * Changed country list text style from bold to paragraph size * Added dimen everywhere and added back en string Co-authored-by:
Alexandru.Paulescu <alexandru.paulescu@sap.com>
-
- Sep 28, 2020
-
-
Matthias Urhahn authored
* Add retry mechanism with backoff to EncryptedSharedPreferences creation. * Increase default delays and make the actual delay a randomized value between the last and the new delay. * Upgrade to "androidx.security:security-crypto:1.0.0-rc03" * Further space retry delays. * Unit tests for retry mechanism and factory init. * klint * Fixed flaky test. Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
Matthias Urhahn authored
* Move AppConfig related code into it's own package. * Use "files" instead of "cache" for storing our AppConfigApiTest. * Add "files" to "cache" migration. * Refactor CDN related code into an independent "environment module". TODO: UnitTests, Fallback behavior even if cached AppConfig is stale. * Further structure refactoring and unit test for app config cache migration. * Added config fallback behavior for all cases + additional tests. * Improve code readability. * Remove test TODO
-
- Sep 24, 2020
-
-
Matthias Urhahn authored
-
- Sep 22, 2020
-
-
Matthias Urhahn authored
* QuotaCalculator V2 * Add extra logging for transaction and worker exceptions. (#1195) (EXPOSUREAPP-2640) * Remove QuotaCalculation due to unexpected sideeffects. (#1196) (EXPOUSREAPP-2640) * Fix klint/sourceCheck. * Add test for first initialization. * Add visibility modifier * Simplify quota reset time calculation and extend tests for edge cases. * Reduce impact of quota check to a warning for 1.4. Add tests for silent quota check and configuration fallback behavior. * Addressed PR comments.
-
- Sep 18, 2020
-
-
Matthias Urhahn authored
Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Matthias Urhahn authored
Refactor MD5 extraction to be part of `DiagnosisKeyServer`'s responsibility. Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Matthias Urhahn authored
This reverts commit 6054bf57.
-
Jakob Möller authored
* Added first set of country flags Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Added first implementation of Submission Country Selection Screen. (Currently not part of nav graph). Moved stuff inside of submission package into subpackages Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Added missing changes to nav_graph file * Test Menu options for Country selection and Measurement (EXPOSUREAPP-2229) (#1086) * Implement country filter (#2229) * Implement measure for Risk calculation and Key Retrieval (#2229) * Some code cleanup for measureRiskLevelAndKeyRetrieval * Some code cleanup (#2229) * Implement usage of AppConfig usage for country codes (#2229) * change CURRENT_COUNTRY val to var * Suppress "LongMethod" warning (#2229) * Adjust unit tests to respect new country filter * Align with backend for app config country property name * Display total file size of keys in results (#2229) * Fix linting issue * Update strings.xml files * Do refactoring and some code clean up * Move RiskLevel and Key retrieval measurement in own class * Move code in logical classes. Remove translation in test fragment * Fix linting and Unit tests * Remove 3hour boolean check from debug class. * Refactor CountryWrapper and missing dates check. * Fix linting and Unit tests * Add Unit test for getMissingDates * Code cleanup * Hide keyboard on action * Extend statistics for api submission * Set callback to null after invoked Co-authored-by:
Mert Safter <mert.safter@sap.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> * Overhaul of DiagnosisKey related Download and Caching Mechanisms (EXPOSUREAPP-2469) (#1136) * Rework of keyfile download and caching. * Supports interop * More modular for better testing and build flavour based behavior adjustments * More resilient handling of failed downloads * Preperations for future hourly download and serverside checksums TODO: Finish unit tests, keycache migration and cache health check * First batch of unit tests and some fixes for incorrect behavior that the tests surfaced. * Added unit tests for the KeyCacheRepository TODO: Tests for downloader and migration. * Implemented POC for migration old key files. * Fixed legacy file migration and cleanup, improved logging. * Added unit tests for legacy key file migration. * Add fallback for different file hashes in the header. * Yes kLint, we know it's a long method, but for this it's better to read it in one block vs jumping to extra methods. * More linting issues, adjusting project code style prevent a few of these in the future. * Added missing unit tests for `KeyFileDownloader` and fixed faulty behavior that was noticed during testing. * CRUD (instrumentation) test for `KeyCacheDatabase` * Remove unused `FileStorageHelper` and related constants+tests. * Fix last3Hours unit test in deviceRelease mode, we need to explicitly enable debug for these tests. * Until we have more information about the hashsum's format in the header, default to `ETag * Split app config server API from diagnosis key download API, and reintroduce caching for the app config download. * Add test to check that the cache is used on flaky connections. * Code changes based on PR comment, part #1. * Code fluff, formatting. * Handle download errors correctly. * Refactoring: * Remove unnecessary `currentDate` we always start with the newest date from the servers index. * Make a specialised class for header validation * Let legacy cache migration abort early, depending on whether the key dir exists. * If we can't create the base directory for the key repo, throw an exception. * Delete cache entry if a download fails. * Fixed test regression due to refactoring. * Consolidate staleness check into `getStale` * Consolidate clean up for failed downloads into the download method. Added tests to check that we delete the keycache entry if the download fails (which we didn't for hours :O!) * Because the hour-mode uses caching too, we add an explicit button to the test menu that clears the cache. * Add comment with reference to ticket regarding follow up on the other headers. * Move expected storage size per country into a named constant. Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> * Implementation of tests for the interoperability countries selection screen (EXPOSUREAPP-2439) (#1140) * Added initial set of viewModel tests Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Fail tests on unexpected null. Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> Co-authored-by:
Kolya Opahle <k.opahle@sap.com> Co-authored-by:
apopovsap <66370584+apopovsap@users.noreply.github.com> Co-authored-by:
Mert Safter <69803294+MertSafter@users.noreply.github.com> Co-authored-by:
Mert Safter <mert.safter@sap.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> Co-authored-by:
Matthias Urhahn <darken@darken.eu>
-
- Sep 17, 2020
-
-
Matthias Urhahn authored
* DI: ViewModel (VDC) injection wiring + example in TestRiskLevelCalculation.kt * Refactoring the TestRiskLevel fragment to demo our new viewmodel approach. Part1 * Refactoring the TestRiskLevel fragment to demo our new viewmodel approach. Part2 * Fix `Unexpected indentation (expected 4, actual 8)` * Code fluff * klint * Remove empty test + klint * Rename VDC to CWAViewModel * Add example unit tests for the TestFragment's ViewModel. * Revert AppInjector renaming. * Comments explaining the code. * Rename class to make it's purpose less confusing. * Revert "Rename class to make it's purpose less confusing." This reverts commit c80298bb * Rename class to make it's purpose less confusing. * Simpler ViewModel Injection example. * klint <3 Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Matthias Urhahn authored
* New Scan Confirmation Texts Change (EXPOSUREAPP-2427) (#1097) Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by:
Jakob Möller <jakob.moeller@sap.com> * New Strings for Risikobegegnung mit niedrigem Risiko (EXPOSUREAPP-2462) (#1106) * + new strings * let the app not crash on other languages than DE * values for lint and tests * made bad test a comment * removed unnecessary strings * more string fixes Co-authored-by:
Jakob Möller <jakob.moeller@sap.com> Co-authored-by:
Luka Harambasic <luka.harambasic@sap.com> * Remove Cache Clearing to reduce CDN load on failing devices (EXPOSUREAPP-2405) (#1108) * Remove Cache Clearing to reduce CDN load on failing devices. This ideally needs to be accompanied by a way to clear the cache manually and a way to identify more root causes of Transaction Failures. Signed-off-by:
d067928 <jakob.moeller@sap.com> * Remove Files that failed for Key Retrieval Only Remove Files from Cache that failed to download, instead of every file. This is accompanied ideally by no rollback in the Key Retrieval. We only delete the cache ref, the file will not be deleted as it is considered not present Signed-off-by:
d067928 <jakob.moeller@sap.com> * Introduce dedicated QuotaCalculator for Unit Testing Signed-off-by:
d067928 <jakob.moeller@sap.com> * Refactor QuotaCalculator for LocalData Property Access and Write Tests Signed-off-by:
d067928 <jakob.moeller@sap.com> * Use Instant on the Device Read since this is not timezone specific Signed-off-by:
d067928 <jakob.moeller@sap.com> * Add specific state for the quota calculation and dedicated rollback Signed-off-by:
d067928 <jakob.moeller@sap.com> * PR Comments Signed-off-by:
d067928 <jakob.moeller@sap.com> * Feature: Update low risk string (EXPOSUREAPP-1971) (#1125) * Improve Explanation for "Risikobegegnung mit niedrigem Risiko" (EXPOSUREAPP-1971) (#1112) * Adapt QuotaCalculatorTest to old JUnit4 API Signed-off-by:
d067928 <jakob.moeller@sap.com> * [INTERNAL] Translation delivery: commit by LX Lab (#1132) Change-Id: Ib76a9ea2b03163a05dd8b6acf2179262f9bcf5bf * Removed ar & ru and updated defaults (#1133) * Throw Exception in case we have a failed entry to ensure Abortion of the Transaction (EXPOSUREAPP-2405) (#1134) * Throw Exception in case we have a failed entry to ensure Abortion of the Transaction. Signed-off-by:
d067928 <jakob.moeller@sap.com> * Adjust test to not expect call to clear cache files Signed-off-by:
d067928 <jakob.moeller@sap.com> * version bump to 1.3.1 * Reverted replaced wording (EXPOSUREAPP-2638) (#1153) * Fix: No exposure with low risk so far * Fixed klint issues (#1144) * restored reverted replaced wording for lint * https://github.com/corona-warn-app/cwa-app-android/pull/1153#discussion_r487801724 * fixed term * Align TestFragment Crash behavior with background transaction crash behavior. * Add logging mechanism to debug hotfix issue. * Lint Resolvement, Nav Graph Issue clean, Enable Log for deviceForTesters, Correct Quota Tests due to now lacking exception Signed-off-by:
d067928 <jakob.moeller@sap.com> Co-authored-by:
Philipp Woessner <64482866+pwoessner@users.noreply.github.com> Co-authored-by:
Jakob Möller <jakob.moeller@sap.com> Co-authored-by:
Rituraj Sambherao <54317407+ritsam@users.noreply.github.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by:
chris-cwa <69595386+chris-cwa@users.noreply.github.com> Co-authored-by:
Luka Harambasic <luka.harambasic@sap.com> Co-authored-by:
SAP LX Lab Service Account <tmsatsls+github.com_service-tip-git@sap.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Oliver Zimmerman authored
* initial commit of new fragment for symptom screen * Added relevant strings for symptom screen. Started editing xml of initial symptom screen * Addded 3 selection options within symptom screen * button id name change to something more relevant * ID changes to be something more relevant to symptom scenerio. * Implemented symptom initial screen logic. Temporary nav for testing. * CircleCI formatting * Adapted interoperability test provided by apopov * Added accessibilty announcement on resume, fixed navigation for main page * circleCI indentation fix * removed ar & ru and updated default strings * Adaption to ViewModel logic. Not yet complete Adaption to ViewModel logic, attempting to align with implementation done with some interoporibility tasks: reusable layout files, etc. * More ViewModel transformation additions * revert nav from test. Circle CI formatting changes * Update SubmissionSymptomIntroductionFragment.kt * Removed old fragment based test * Will implement navigation during marry session. * Update SubmissionViewModel.kt * Calendar button selection screen + required strings * Custom calendar view * Accessibility improved * introduced data types for symptoms * represent date by long in millis * new TransmissionRiskVector * Constants and formatting * Naming changes requested * Better event naming * Update fragment_submission_symptom_intro.xml * Finishing calendar implementation - still need to implement calendar widget Surrounding calendar submission UI - minus calednar widget Necessary strings * Merged introduction and calendar screen. Created calendar fragment screen, Finished calendar XML view Added required entries for choices in SubmissionViewModel Adjusted Formatters for button selection. Changed nav graph. * + todo * CircleCI code style changes * EXPERT STUFF * Latest push for marry session * replaced transaction risk vector * update textcolor on symptom indication change * update buttons by code * code formatting * Added logic for Negative and No Information buttons and adjusted xml view to be more aligned with design Added logic for Negative and No Information buttons and adjusted xml view to be more aligned with design * disable next button when state is null. * + readability * Calendar screen logic adapted for button selection * extracted domain logic from prototype and from transaction * - not used events * joint improvements * removed unused events * Calendar unsetSelection added * detekt rules changed and formatting * - calendar view refactor: CalendarCalculator singleton introduced for batter testing capacity - unit tests added * detekt issues * Colors and styles cleared * fixed strings * maintained unit tests * adopted changes from main nav graph to device for testers nav graph * reverted comment * made start of symptoms nullable * tests * Adjusted navigation, fixed dark theme * Update Project.xml * use of postValue() in SubmissionViewModel.kt * Added direction in tester nav graph * improvements required by review * moving companion * moving companion * moving companion * fixed issues from partner review * fixed issues from partner review * fixed issues from partner review * fixed issues from partner review * fixed issues from partner review * using utc * edge case tests * made inner class * Refactored Symptoms Class Name (+data class) * Change SubmissionViewModel scope to ensure that the same viewmodel is used to store submission data. * extracted null check + log Co-authored-by:
Luka Harambasic <luka.harambasic@sap.com> Co-authored-by:
chris-cwa <chris.cwa.sap@gmail.com> Co-authored-by:
Alexander Alferov <a.alferov@sap.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by:
Matthias Urhahn <darken@darken.eu> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
- Sep 15, 2020
-
-
Matthias Urhahn authored
* Fix: No exposure with low risk so far * Fixed klint issues (#1144) * restored reverted replaced wording for lint * https://github.com/corona-warn-app/cwa-app-android/pull/1153#discussion_r487801724 * fixed term Co-authored-by:
chris-cwa <69595386+chris-cwa@users.noreply.github.com>
-
- Sep 14, 2020
-
-
Matthias Urhahn authored
Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Rituraj Sambherao authored
* test for OnboardingFragment * QR code stricter validations * regex pattern improvement * removed Obsolete test * lint changes to fix pipeline issue * logic refinement and test coverage improvement * pipeline related fixes * piepline related fixes : unnecessary test removed * pipeline fixes and increased tests coverage * QR code validation logic improvement * detekt pipeline issue resolved * pipeline issue Fix * logic ovehaul and improvement for QRCode scans / validations 1, Data object for ScanResults 2. new Test for ScanResults 3. logic simplified * removing unused imports from tests * Small refactoring together with Rituraj. * Adjust detekt, early abort via return is GOOD! Co-authored-by:
Matthias Urhahn <darken@darken.eu> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Jakob Möller authored
Version Checker with Branching for Checks on provideDiagnosisKeys below v16 of ENF (EXPOSUREAPP-2213) (#1150) * Add Version Check Signed-off-by:
d067928 <jakob.moeller@sap.com> * Version Checker Update Signed-off-by:
d067928 <jakob.moeller@sap.com> * Testing for Version Check Signed-off-by:
d067928 <jakob.moeller@sap.com> * Remove Expiremental Annotation for method and add on Class and pull tearDown below setUp Signed-off-by:
d067928 <jakob.moeller@sap.com> * add GoogleAPIVersion via DI Signed-off-by:
d067928 <jakob.moeller@sap.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
- Sep 11, 2020
-
-
Kolya Opahle authored
Implementation of tests for the interoperability countries selection screen (EXPOSUREAPP-2439) (#1140) * Added initial set of viewModel tests Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Fail tests on unexpected null. Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Matthias Urhahn authored
* Rework of keyfile download and caching. * Supports interop * More modular for better testing and build flavour based behavior adjustments * More resilient handling of failed downloads * Preperations for future hourly download and serverside checksums TODO: Finish unit tests, keycache migration and cache health check * First batch of unit tests and some fixes for incorrect behavior that the tests surfaced. * Added unit tests for the KeyCacheRepository TODO: Tests for downloader and migration. * Implemented POC for migration old key files. * Fixed legacy file migration and cleanup, improved logging. * Added unit tests for legacy key file migration. * Add fallback for different file hashes in the header. * Yes kLint, we know it's a long method, but for this it's better to read it in one block vs jumping to extra methods. * More linting issues, adjusting project code style prevent a few of these in the future. * Added missing unit tests for `KeyFileDownloader` and fixed faulty behavior that was noticed during testing. * CRUD (instrumentation) test for `KeyCacheDatabase` * Remove unused `FileStorageHelper` and related constants+tests. * Fix last3Hours unit test in deviceRelease mode, we need to explicitly enable debug for these tests. * Until we have more information about the hashsum's format in the header, default to `ETag * Split app config server API from diagnosis key download API, and reintroduce caching for the app config download. * Add test to check that the cache is used on flaky connections. * Code changes based on PR comment, part #1. * Code fluff, formatting. * Handle download errors correctly. * Refactoring: * Remove unnecessary `currentDate` we always start with the newest date from the servers index. * Make a specialised class for header validation * Let legacy cache migration abort early, depending on whether the key dir exists. * If we can't create the base directory for the key repo, throw an exception. * Delete cache entry if a download fails. * Fixed test regression due to refactoring. * Consolidate staleness check into `getStale` * Consolidate clean up for failed downloads into the download method. Added tests to check that we delete the keycache entry if the download fails (which we didn't for hours :O!) * Because the hour-mode uses caching too, we add an explicit button to the test menu that clears the cache. * Add comment with reference to ticket regarding follow up on the other headers. * Move expected storage size per country into a named constant. Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
chris-cwa authored
-
- Sep 10, 2020
-
-
Jakob Möller authored
Double Timeout Variables for HTTP Requests and Triple the Timeout for the Transaction to ensure less timeouts are received with bad networking. (EXPOSUREAPP-2190) (#1138) Signed-off-by:
d067928 <jakob.moeller@sap.com>
-
Oliver Zimmerman authored
* removed button announcement entirely * removed assosciated test * removed unneccesarry tests Co-authored-by:
Jakob Möller <jakob.moeller@sap.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
- Sep 09, 2020
-
-
Jakob Möller authored
Throw Exception in case we have a failed entry to ensure Abortion of the Transaction (EXPOSUREAPP-2405) (#1134) * Throw Exception in case we have a failed entry to ensure Abortion of the Transaction. Signed-off-by:
d067928 <jakob.moeller@sap.com> * Adjust test to not expect call to clear cache files Signed-off-by:
d067928 <jakob.moeller@sap.com>
-
- Sep 07, 2020
-
-
Jakob Möller authored
* Remove Cache Clearing to reduce CDN load on failing devices. This ideally needs to be accompanied by a way to clear the cache manually and a way to identify more root causes of Transaction Failures. Signed-off-by:
d067928 <jakob.moeller@sap.com> * Remove Files that failed for Key Retrieval Only Remove Files from Cache that failed to download, instead of every file. This is accompanied ideally by no rollback in the Key Retrieval. We only delete the cache ref, the file will not be deleted as it is considered not present Signed-off-by:
d067928 <jakob.moeller@sap.com> * Introduce dedicated QuotaCalculator for Unit Testing Signed-off-by:
d067928 <jakob.moeller@sap.com> * Refactor QuotaCalculator for LocalData Property Access and Write Tests Signed-off-by:
d067928 <jakob.moeller@sap.com> * Use Instant on the Device Read since this is not timezone specific Signed-off-by:
d067928 <jakob.moeller@sap.com> * Add specific state for the quota calculation and dedicated rollback Signed-off-by:
d067928 <jakob.moeller@sap.com> * PR Comments Signed-off-by:
d067928 <jakob.moeller@sap.com>
-
chris-cwa authored
-
- Sep 03, 2020
-
-
Mert Safter authored
* Implement country filter (#2229) * Implement measure for Risk calculation and Key Retrieval (#2229) * Some code cleanup for measureRiskLevelAndKeyRetrieval * Some code cleanup (#2229) * Implement usage of AppConfig usage for country codes (#2229) * change CURRENT_COUNTRY val to var * Suppress "LongMethod" warning (#2229) * Adjust unit tests to respect new country filter * Align with backend for app config country property name * Display total file size of keys in results (#2229) * Fix linting issue * Update strings.xml files * Do refactoring and some code clean up * Move RiskLevel and Key retrieval measurement in own class * Move code in logical classes. Remove translation in test fragment * Fix linting and Unit tests * Remove 3hour boolean check from debug class. * Refactor CountryWrapper and missing dates check. * Fix linting and Unit tests * Add Unit test for getMissingDates * Code cleanup * Hide keyboard on action * Extend statistics for api submission * Set callback to null after invoked Co-authored-by:
Mert Safter <mert.safter@sap.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
- Sep 02, 2020
-
-
chris-cwa authored
* + new strings * let the app not crash on other languages than DE * values for lint and tests * made bad test a comment * removed unnecessary strings * more string fixes Co-authored-by:
Jakob Möller <jakob.moeller@sap.com> Co-authored-by:
Luka Harambasic <luka.harambasic@sap.com>
-
- Sep 01, 2020
-
-
chris-cwa authored
* made power management injectable interface * same behaviour every where * - unnecessary tests * Integrate DI with workarounds until singletons are gone. * house keeping * unnecessary import * house keeping * fixed typo Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> Co-authored-by:
Jakob Möller <jakob.moeller@sap.com>
-
Oliver Zimmerman authored
* Removed blanked internet connection UI state. New Dev base for pipeline issues Removed the blanket internet connection status: Removed the connection state from TracingStatusHelper Adjusted formatters which use the adjusted TracingStatusHelper Removed connection logic from various fragments (SettingsTracingFragment, etc.) Adjusted XML views (Settings Fragment: no connection card, etc.) Adjusted automated tests that previously included the connection state. Closes JIRA task EXPOSUREAPP-1572 * Update FormatterSettingsHelperTest.kt * Update fragment_main.xml deviceForTesters was still using connection state. * Update Project.xml * Update FormatterSettingsHelperTest.kt Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-