- Jan 07, 2021
-
-
Matthias Urhahn authored
-
Oliver Zimmerman authored
No illustration description for image on Background Priority settings screen (EXPOSUREAPP-4097) (#2031) * added getter for illustration description in BackgroundPriorityState * Added new string to other string files * Removed unnecessary string entries * Added actual string values. Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Matthias Urhahn authored
Long methods are not generally bad and should be decided on a case by case basis in PR reviews.
-
Philipp Nowak authored
- Get rid of windows backslash path warning for ENF aar dependency Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
Matthias Urhahn authored
* Initial draft for user accessible debug logs in production. TODO: Sharing, Tests, Cleanup FileLoggerTree? * Ready strings for translation. * Log file compression for sharing (zip). * Add log sharing * Change how DebugLogger is initialized to make sure we can record issues that happen very early in the apps lifecycle. * Add missing toolbar back arrow navigation. * Fix initial delay for ui state emissions. * Censor registration token. * Adjust warning regarding sensitive data in debug logs. * Use property injection instead of component getters. * Hide option until greenlit. * Add test for RegistrationTokenCensor * Unit tests. * Make unit test without triggerfile more specific. * LINTs * Fix missing injection provider in release mode. * Fix regtoken censor if condition. * Fix typos. * Remove empty manifest specific to deviceForTesters build. * Wait until log job is canceled before deleting log files. Otherwise a race condition could lead to file creation after job cancellation. * Replace runBlockingTest with runBlocking we don't need scheduler control and runBlockingTest is sometimes unreliable. * Refactor FileSharing to use compat builder from androidx. * Handle exceptions on debug log start() * Print device infos when log is started. * Text changes requested by UA Co-authored-by:
ralfgehrer <mail@ralfgehrer.com>
-
- Jan 06, 2021
-
-
Chilja Gossow authored
-
Chilja Gossow authored
* fix crash
-
fynngodau authored
* Use ContextCompat when accessing color resources #1924 * Update tests for #1924 * Fix incorrect color A previous commit changed a color incorrectly, related to some mistake made when merging changes. * Add compat extension to Context * Replace ContextCompat calls with Context extension functions * Update tests * Add missing imports * Fix tests * Fix lint Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Ralf Gehrer authored
-
Philipp Nowak authored
* - Removed Kotlin Android Extensions plugin - Replaced usages of Kotlin Synthetics by Jetpack view binding - Added Kotlin Parcelize standalone plugin (#2022) * Fix detekt issue (#2022) * Use view binding for TestResultSectionView (EXPOSUREAPP-4495) (#2022) * Use bind() instead of inflate() for view binding in TestResultSectionView (EXPOSUREAPP-4495) (#2022) Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
fynngodau authored
Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
- Jan 05, 2021
-
-
Mohamed Metwalli authored
* Add tooling layout tag for better overview * Ignore error for ProtectedPermissions * Add instrumentation tests to capture screenshots in Onboarding flow * Specify java version to avoid assembling APK failure * Define custom annotation for tests * Use fastlane Screengrab * ignore screenshots folder * Remove redundant imports and rules * Add View assertion to make sure Fragment is already displaying its views to avoid capturing blank screenshots * List some configurations for fastlane * Add TODO for locale change * Allow timestamp suffix to have different screenshots names * Scroll and grab another screenshot in OnboardingFragment * Delete import * Filter tests using Screenshot annotation * Add locale change rule in UI tests * Limit screenshots only for DE locale * Enable screenshots for all locales * Enable screenshot test * lint cleaning * Use JavaVersion to specify java version * Add an inline function that defaults to AppTheme * Update dcos for launchFragmentInContainer2 * lint * Define generic apk_path * Support cleaning device status bar before taking screenshot * Correct docs Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
Mohamed Metwalli authored
* Setup fastlane * Correct todo statment * Delete fastlane files * Add Gemfile lock * Change bundler version to v2. Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
Philipp Nowak authored
* Localize dates in contact diary (EXPOSUREAPP-4485) (#2009) * Add additional unit test to cover US and UK for english date formatting (EXPOSUREAPP-4485) (#2009) * Adjust expected date strings (EXPOSUREAPP-4485) (#2009) * Correct the suffix for "year" for bulgarian dates in unit tests (EXPOSUREAPP-4485) (#2009) * Use SystemInfoProvider implementation instead of static Locale.getDefault (EXPOSUREAPP-4485) (#2009) * - Revert usage of SystemInfoProvider - Introduce Context.getLocale() extension function - Adjust unit tests to use kotest matchers (EXPOSUREAPP-4485) (#2009) * (Add accidentally missing files of the previous commit) - Revert usage of SystemInfoProvider - Introduce Context.getLocale() extension function - Adjust unit tests to use kotest matchers (EXPOSUREAPP-4485) (#2009) Co-authored-by:
I502720 <axel.herbstreith@sap.com>
-
Matthias Urhahn authored
* Introduce lastSubmissionUserActivityUTC settings and use it as "skip condition" for the SubmissionTask * Introduce background submission. * Fix worker not being canceled. * Disable auto submission is consent is not given. * Cancel worker by tag. * Introduce per TaskRequest error-handling. Set SubmissionWorker deployed task requests to SILENT. * Fix test regressions due to api change. * Add SubmissionWorker test. * Add AutoSubmissionTest.kt * Don't reset retry attempt count and date when enabling MONITOR or SUBMIT_ASAP. Otherwise would loose that data when the app is restarted despite it still "trying". Only reset the data on DISABLED, i.e. when the task finishes or give sup. * Add additional SubmissionTaskTest.kt related to automatic submission behavior. * Remove unused value. * Fix typo * Return Result.retry() on exceptions. We retry until we are successful, any abort conditions will be handled by the task. * LINTs * Fix test regression.
-
Chilja Gossow authored
* accessibilty announcement for list items person and location * Merge branch 'release/1.11.x' into feature/4459-accessibility-loc-person # Conflicts: # Corona-Warn-App/src/main/res/layout/contact_diary_location_list_item.xml # Corona-Warn-App/src/main/res/layout/contact_diary_person_list_item.xml * Merge branch 'release/1.11.x' into feature/4459-accessibility-loc-person # Conflicts: # Corona-Warn-App/src/main/res/layout/contact_diary_location_list_item.xml # Corona-Warn-App/src/main/res/layout/contact_diary_person_list_item.xml * add selection announcements * lint * lint * screen announcement * screen announcement * klint * klint * strings correction * strings * refactoring string access * allow spread operator Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Philipp Nowak authored
Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
- Jan 04, 2021
-
-
Philipp Nowak authored
Fix sorting of persons and places to be case insensitive for names (EXPOSUREAPP-4488)(closes #2012) (#2017) * Fix sorting of persons and places to be case insensitive for names and add some unit tests for both parts (#2012) * Address code review comments (EXPOSUREAPP-4488) (#2012) Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Matthias Urhahn authored
* If maxExposureDetectionsPerDay is 0, return a saner value than 99 days. maxExposureDetectionsPerDay is checked separately and will abort the download task if necessary. * When checking whether the last detection was recent, add a sanity check that causes it to not skip, if the last detection was in our future. Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
Matthias Urhahn authored
* Change primary key for risk result database to a monotonic ID. This prevents time travel from breaking "get latest" as we will get the latest by monotonic ID, instead of "calculatedAt". * We don't need `fallbackToDestructiveMigrationFrom(3)` until we actually upgrade the schema to 3. * Fix database test (missing monotonicId) * Catch exceptions during migrations and recreate the table. * Add check for result size after recreating+insertion. Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
Chilja Gossow authored
* accessibility announcement renaming
-
Matthias Urhahn authored
-
- Dec 29, 2020
-
-
Alex Paulescu authored
Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
- Dec 28, 2020
-
-
Matthias Urhahn authored
* Downgrade R8 to 2.0.74. https://issuetracker.google.com/issues/176381203 * Update gradle version in unrelated task. * Align gradle wrapper task formatting. (No change, just formatting).
-
Matthias Urhahn authored
Co-authored-by:
Mohamed Metwalli <mohamed.metwalli@sap.com>
-
Matthias Urhahn authored
* Add state-aware illustrations for Settings>BackgroundModeStatus Refactor various background mode related functions into a common class that can be injected and observed. * Rename c to context * Use core-ktx extension to access system services * Fix wrong import statement and a typo * Add more test cases Co-authored-by:
Mohamed Metwalli <mohamed.metwalli@sap.com>
-
Matthias Urhahn authored
* Fix deadman notification text not being expandable and clean up code. * Further notification code cleanup. * Use core-ktx extension to access system services Co-authored-by:
Mohamed Metwalli <mohamed.metwalli@sap.com> Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
Matthias Urhahn authored
* Fix icon in settings when bluetooth is disabled. * Rename c to context Co-authored-by:
Mohamed Metwalli <mohamed.metwalli@sap.com> Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
Matthias Urhahn authored
* Fix failed tracing state having the wrong text color for "last update". * The tracing details box had no visible background in nightmode. * Fix "Restart" button visibility being reversed on the "Tracing failed" card. * Code fluff * Fix "Tracing in progress" switching the color, we need to use the latest, not the latestSuccessful risk state for coloring the progress state. Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
Matthias Urhahn authored
Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
- Dec 23, 2020
-
-
Matthias Urhahn authored
* Let the AppConfig validity check use absolute values, to support device time check behavior. * Add mapping for "disable-device-time-check" to app config. * Show popup dialog if the device time is invalid. * Remove extra retrofit cache (use only LocalAppConfigSource.kt) * Exposure device time check * Reset user acknowledgement * LINTs * Add test menu option to disable device time check via affecting the config mapping. * Download, but don't submit keys if device time is incorrect. Abort risk level calculation if time is incorrect. * Due to multiple properties in ConfigData affecting `isDeviceTimeCorrect`, make it a body property and don't allow overriding via constructor. * Add unit test for test settings affecting the device config only in tester builds. * Show notification regarding incorrect time when device is in the background. * Fix test regressions and add additional test cases for download and risk task abort conditions on incorrect device time. * Fix merge regressions. * Add time unit to log statement. * Fix incorrect time dialog showing in a loop when entering leaving the home screen. * Remove unused code path for clear(). * Print additional timestamps to help debugging efforts in the future.
-
Matthias Urhahn authored
Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
Matthias Urhahn authored
* Don't log all exposure windows on `RiskLevelTaskResult.toString()` due to performance impact when logging. * Add RiskLevelResult flow optimized for just getting the latest two results. * Share risk level result subscriptions. The delay when switching from Home to RiskDetails fragment will be bridged and no re-loading necessary. * Fix test regressions * Remove test code. * Introduce specific query for "latestAndLastSuccessful". Add unit tests for SQL queries. * Fix test regressions due to missing mocking. * Address merge conflicts. * Fix instrumentation tests not building. Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
axelherbstreith authored
* Removed rounded corners from onboarding screen background * Changed naming of xml * Changed behavior of placeholder in day screen * Changed behaviour of placeholder in edit screen * Changed naming of overview screen list items * Updated layout of over view list items * Updated Overview screen list items * Added dimens * Updated list item size * Changed item layout * Added ripple to list items in overview screen * Removed scroll bar from overview list * Linting * removed unused overview screen list item * Simplified expressions * Reformatted contact diary xml files * Added dimens * removed unused layout tag
-
Matthias Urhahn authored
* Update gradlew wrapper and plugin. * Update binary (via ./gradlew wrapper --gradle-version=6.3 --distribution-type=all)
-
Matthias Urhahn authored
Adjust layout margins to have a cleaner look (whitespace wise) and prevent cut off text on row items. (#1991)
-
Chilja Gossow authored
* adapt colors to match design * elevation Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
Matthias Urhahn authored
Prevent IllegalStateException when orphaned Fragments try to popBackStack() (EXPOSUREAPP-4430) #1987 * Prevent IllegalStateException if a fragment that's not added to an Activity tries to popBackStack() * Typo
-
Mohamed Metwalli authored
* Rely on native `observe` from LiveDate instead of `oberve2 * Remove extra blank line * Revert chnages for Fragments * Remove unused imports Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> Co-authored-by:
Mohamed Metwalli <mohamed.metwalli@sap.com>
-
Chilja Gossow authored
* adjust margins to match design use selectable item background add animated list updates * move logic to contact diary specific element * change style * use stableIds
-