Skip to content
Snippets Groups Projects
  1. Oct 23, 2020
  2. Oct 19, 2020
    • Matthias Urhahn's avatar
      Refactor missused ViewModels, support automated UI tests and screenshots (EXPOSUREAPP-2946) (#1415) · cec56fdb
      Matthias Urhahn authored
      
      * Introduced `TracingCardState` and `TracingDetailsState`.
      Removed all direct viewmodel/livedata access from all nested layouts for `TracingViewModel`.
      Removed `FormatterRiskHelper`.
      Introduced logic to reactively update the UI state if bluetooth, location or tracing state changes.
      
      TODO:
      * Finish tests in TracingCardStateTest.kt and TracingDetailsStateTest.kt
      * Finish TracingDetailsViewModel.kt and TracingCardViewModel.kt
      * Remove obsolete dependencies on TracingViewModel.kt and singletons RiskLevelRepository.kt, TracingRepository.kt
      
      * Breakthrough, cards update again.
      
      * Further cleanup of TracingViewModel.kt, TracingRepository.kt
      Still not quite there yet, too many calls going into every direction, back and forth, instead of just top->down, but we are getting there.
      We want data flow from business logic code to the UI, keep the UI KISS.
      
      * Update TracingCardState tests to account for changes
      
      * More refactoring, TracingViewModel.kt is now finally gone.
      
      * Fix risk details card, we reuse the cardviewmodel but need to overwrite the `showDetails` flag depending from where it's used.
      
      * Refactored several properties (notification related) out of SettingsViewModel/Repository
      
      * Fix injection
      
      * Refactoring submission related databinding code on the home fragment
      
      * Make TracingRepository.kt injectable and change viewmodel scoping for refresh calls to app scope.
      
      * Remove additional formatter calls from submission cards on home screen.
      
      * Refactored additional SubmissionViewModel logic into SubmissionRepository on the Homescreen.
      First UI Test is now passing.
      
      Simplified ViewModel instantiation related code.
      Prepared HomeFragment for smoother UI state changes, less reloading.
      
      * Improved home,tracing-details and tracing-settings loading behavior, less flickering.
      Fixed LiveData value assignment on background-thread.
      
      * New reactive provider for Bluetooth and Location status.
      Cleaned up ConnectivityHelper.kt partially.
      
      * Implement remaining tests, batch 1.
      
      * Implement remaining tests, batch 2.
      
      * Fix lint issues.
      
      * Removed a few codesmells and code duplication.
      Introduced Flow.shareLatest(...)
      
      * Removed unused parameters.
      
      * LINT fixes.
      
      * Fix unit test failing due to missing mocks.
      
      * Address PR comments.
      
      * Improve UI loading states, remove flickering.
      
      * Remove log spam due to polling values, add extra abort condition that checks for cancellation.
      
      Co-authored-by: default avatarralfgehrer <mail@ralfgehrer.com>
      cec56fdb
  3. Oct 15, 2020
  4. Oct 14, 2020
  5. Oct 13, 2020
  6. Oct 08, 2020
  7. Oct 07, 2020
  8. Oct 06, 2020
  9. Oct 05, 2020
  10. Oct 02, 2020
    • Ralf Gehrer's avatar
      Translation delivery and default strings (DEV) (#1298) · b0b24ae1
      Ralf Gehrer authored
      
      * [INTERNAL] Translation delivery: commit by LX Lab (#1296)
      
      Change-Id: Ic1777f41c4667ffe4057f87dfb2d1415036688ba
      
      Co-authored-by: default avatarharambasicluka <64483219+harambasicluka@users.noreply.github.com>
      
      * Update default strings
      
      * Update Link language tag
      
      * Fix missing IDs
      
      * re-add placeholder
      
      * re-add placeholder
      
      Co-authored-by: default avatarSAP LX Lab Service Account <tmsatsls+github.com_service-tip-git@sap.com>
      Co-authored-by: default avatarharambasicluka <64483219+harambasicluka@users.noreply.github.com>
      b0b24ae1
    • Matthias Urhahn's avatar
      Reduce code duplication (EXPOSUREAPP-2844) (#1286) · d64a5825
      Matthias Urhahn authored
      * Remove code duplication between different flavors.
      Remove extra MainFragment and NavGraph.
      Introduce TestMenu indirection
      Add logic for splitting test code up into extra fragments.
      
      * Style list items a bit :)
      
      * fix lints
      
      * Detekt *hug*
      
      * We can only show the menu entry if we are actually on the right flavor,
      otherwise, in deviceDebug, we would not have access to the right resources.
      
      * Address PR comments
      
      * Fix wrong XML namespace.
      d64a5825
    • chris-cwa's avatar
      Legal Texts (EXPOSUREAPP-2954 , EXPOSUREAPP-2951, EXPOSUREAPP-2942,... · eb382edf
      chris-cwa authored
      Legal Texts (EXPOSUREAPP-2954 , EXPOSUREAPP-2951, EXPOSUREAPP-2942, EXPOSUREAPP-2938, EXPOSUREAPP-2931, EXPOSUREAPP-2925, EXPOSUREAPP-2924, EXPOSUREAPP-2923, EXPOSUREAPP-2922, EXPOSUREAPP-2920, EXPOSUREAPP-2919, EXPOSUREAPP-2918, EXPOSUREAPP-2917) (#1270)
      
      * text body from EXPOSURE_APP 2740
      
      * line breaks
      
      * - duplicate values
      
      * Interoperability: Make Changes to User Consent Text (Initial Onboarding) (EXPOSUREAPP-2938) (#1276)
      
      * 2938 updated legal strings in defaults, de & tr
      
      * added translatable false
      
      * updated german strings (#1278)
      
      * nex text for EXPOSUREAPP-2942
      
      * Legal Textchange: Exposure Logging Screen (EXPOSUREAPP-2923) (#1280)
      
      * Legal Textchange: Home Screen - FAQ Section (EXPOSUREAPP-2922) (#1281)
      
      * Legal Textchange: Initial Onboarding (EXPOSUREAPP-2920) (#1282)
      
      * Legal Textchange: Test Result Screen (EXPOSUREAPP-2918) (#1283)
      
      * Legal Textchange: Info Screen (EXPOSUREAPP-2917) (#1284)
      
      * update string (#1288)
      
      * kEA-2942
      
      * Legal Textchange: New Eula (Nutzungsbedingungen) (EXPOSUREAPP-2951) (#1285)
      
      * updated eula
      
      * updated tr & en eula with german
      
      * Interoperability: Changes to Data Privacy (EXPOSUREAPP-2954) (#1287)
      
      * Interoperability: Make Changes to User Consent Text (Key Upload) (EXPOSUREAPP-2942) (#1275)
      
      * 2942 - strings updated and added to new legal string file
      
      * removed tr strings, to fix circle ci error.
      
      * added translatable false
      
      * Follow up: Initital onboarding 3rd & 6th paragraph (EXPOSUREAPP-2920) (#1289)
      
      * updated & added strings
      
      * updated 6th paragraph
      
      * Legal Textchange: Cross Country Exposure Logging Screen (EXPOSUREAPP-2924) (#1279)
      
      * updated & added strings
      
      * text under countries added
      
      Co-authored-by: default avatarRituraj Sambherao <git.rituraj.sambherao@gmail.com>
      
      * Interoperability: Delta Onboarding (EXPOSUREAPP-2931, EXPOSUREAPP-2919) (#1277)
      
      * 2931 text update
      
      * move to legal text & update 2919
      
      * delta onboarding text changes for initial text
      
      Co-authored-by: default avatarOliver Zimmerman <oezimmerman@gmail.com>
      
      * Legal Textchange: Delta Interop Screen (EXPOSUREAPP-2919)  (#1294)
      
      * 2931 text update
      
      * delta onboarding text changes for initial text
      
      * Added new legal texts and navigation to terms.
      
      - adjused xml layout
      - added required strings
      - created navigation to legal terms in both nav graphs
      - created navigation in fragment
      
      * Update OnboardingDeltaInteroperabilityFragment.kt
      
      * Update OnboardingDeltaInteroperabilityFragment.kt
      
      Co-authored-by: default avatarLuka Harambasic <luka.harambasic@sap.com>
      
      * fixed wrong implementation regrading user consent in warn others
      
      Co-authored-by: default avatarharambasicluka <64483219+harambasicluka@users.noreply.github.com>
      Co-authored-by: default avatarRituraj Sambherao <git.rituraj.sambherao@gmail.com>
      Co-authored-by: default avatarOliver Zimmerman <oezimmerman@gmail.com>
      Co-authored-by: default avatarLuka Harambasic <luka.harambasic@sap.com>
      eb382edf
  11. Sep 29, 2020
  12. Sep 23, 2020
  13. Sep 18, 2020
  14. Sep 15, 2020
  15. Sep 14, 2020
  16. Sep 09, 2020
  17. Sep 08, 2020
  18. Sep 02, 2020
  19. Sep 01, 2020
  20. Aug 27, 2020
  21. Aug 19, 2020
  22. Aug 12, 2020
  23. Aug 11, 2020
  24. Aug 04, 2020
  25. Jul 31, 2020
  26. Jul 30, 2020
  27. Jul 27, 2020
Loading