- Oct 29, 2020
-
-
BMItter authored
* FileLoggerPlus - RX added - preparation * Buffer config as constants * avoid empty lines * Reworked logging to file - wip * Collecting errors to dao - wip * Added crash report to app db and created module * do it * inject crashReportTree - wip * use dagger injection * retrieve short hash via gradle * removed todo * Updated database to version 2 for new ReportEntity - old base * deprecated old engagement - RX not allowed anymore * use global scope for coroutines in crash report tree - ktlint clean * added menu item - error reporter (replace later to new structure) * basic recylcerview and fragment added to menu - wip * deprecated data class * Delete CrashModel.kt * crash report list item to use data binding * separated Reporteradapter - klint clean * use separated Adapter in ReporterFragment - cleanup * Added ErrorReporterViewModel - connected data to list * dependency injection for crash report, better structure, todo cleanup * some refactoring, cleanup, ktlint * adjustments for 1.6.x * temp action to open crash report fragment * removed testcode * updated layout - wip * connected view & data * satisfy circle ci checks * plant reportingTree, testbutton, klint clean * updated layout for reporter - wip * better format and layout * better message handling * missing icons for errors on debug * Adjusted error report index * Removed ugly show button, report clickable * Added SettingsCrashReportDetailsFragment & corresponding files * fixed merge inconsistence * fixed injection overall * use livedata * details added to report - wip * beauty * share & layout root preparation * make error report shareable * removed Dispatcher.IO for example * Introduce skeleton classes for bugreporting * Refactoring, adjustments to be able to build again * Created BugEventEntity, Changed id to Long for more efficiency, Removed unused events * refactored ui to deviceForTesters, testmenu etc * adjusted interfaces & related, better structure * uses own db, added converter, adjusted modules * adjusted bugrepo, defaultbugrepo * shared report, better visualisation * changed crash db name * Implemented DefaultBugRepository * Added device info to BugEvent, BugReporter collects Tag, Added default impl of BugEvent etc * corrected bug in RollingLogHistory * removed deprecated crash package * quickfix - wip * cleanup * cleanUp, adjusted simulation button to new structure * moved bug related layouts to deviceForTesters package * removed old RX dependenies and related context * fix build for deviceDebug * lint clean * current set of relevant exceptions as before * attach log to output * improved output * Delete obsolet ic_bug in main * Delete ic_coffee.xml * changed shortID to shortCommitHash for better transparency * companion to bottom * removed string encapsulation * cleanup unused import and blank line - PR Comment * typo fixed * rm empty line * removed relict module * layout fix * adjusted unrelated method call * fixed package inkonsistence * Use flow instead of livedata in non-ui * better fun naming * Replaced interface with inline listener * Improved SettingsCrashReportDetailsFragment and SettingsCrashReportViewModel, formatting adjusted * cleaned converter * Delete Project.xml * added log statement to DefaultBugRepository * adjusted magical number * Use CommonConverters instead of unique Converters in BugDatabase * Extension function for the resuce -defaultBugRepository * removed FormatterCrashReport completly * changed long to UUID * satisfy buggy ktlint checks * Update SettingsCrashReportViewModel.kt use postvalue * avoid passing viewmodel * store appVersionCode as Long for beeing futuresave * Update SettingsCrashReportViewModel.kt removed lazy init * Changed BugDatabase to factory pattern Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
- Oct 28, 2020
-
-
Matthias Urhahn authored
-
Alex Paulescu authored
* Added logic for showing notification on risk level change * Got rid of magic number * Fixed ktlint issue * Notification only shows up when risk card goes from red to green * Showing dialog onResume * Added static string for preference key and renamed method to better reflect usage * Whether not weather * Showing dialog is handled by the VM * Fixed ktlint error * Fixed an issue where the dialog would be shown only after navigating back to the home fragment. * Move decision logic for showing the lowered risk into the viewmodel. * Make the lowered risk level score event observable. * Fix wrong init value used for testing. * Update strings.xml * Fix test regressions due to static LocalData access. Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Alex Paulescu authored
* Refactored DataRetentionHelper class to use injection * Added ViewModel to SettingsReset * Add a clear cache method to AppConfigProvider.kt * Fixed repository live data containing stale data after app reset. * Moved logic from fragment to view model. * Adjusted tests to accommodate AppConfigProvider changes * Reverted back last 2 commits and downgraded ktlint plugin * Fixed DI issue * Put the scope in the hands of the VM * Deleted unused imports * Removed unused imports from VM * Use injected dispatcher provider to simplify testing. Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> Co-authored-by:
AlexanderAlferov <64849422+AlexanderAlferov@users.noreply.github.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
Matthias Urhahn authored
Retry the reset for v1.6.0+ as the failed reset attempt in 1.5.0 may have consumed the reset attempt already. (#1492)
-
Matthias Urhahn authored
* Cleaner log and remove superfluos removal, if we replace the entry anyways, we don't have to remove it. * Only propagate changes if the data actually changed. Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
Ralf Gehrer authored
-
SAP LX Lab Service Account authored
Change-Id: Ie90db444d051c7d37eadfbe1f1e1e5205804eab1 Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
- Oct 27, 2020
-
-
Kolya Opahle authored
Homescreen Notifications, even though keys were submitted (EXPOSUREAPP-3181, EXPOSUREAPP-3182) (#1418) * Added additional checks to notification of exposure/test-result to check for finished submission Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Small changes to code style Signed-off-by:
Kolya Opahle <k.opahle@sap.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
Matthias Urhahn authored
* Two new progress states for the risk card+details. * Add unit tests for new card states. * Flatten UI of risk card to improve layouting performance on slow devices. * Remove stale strings from other translations. * UX wants the ... ¯\_(ツ)_/¯ Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
janetback authored
-
Ralf Gehrer authored
* ProtoBuf Update at Wed Oct 21 13:15:13 UTC 2020 #1448 * Switch to centralized ProtoBuf format (EXPOSUREAPP-3404) (#1455) * Switch to centralized ProtoBuf format and fix imports (EXPOSUREAPP-3404) * Fix ktlint issues Co-authored-by:
Maximilian Lenkeit <mlenkeit@users.noreply.github.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
- Oct 26, 2020
-
-
Matthias Urhahn authored
* Add a `CalcluationTracker` class that can tell us about the ENF's calcluations. * Introduces new reactive data provider "HotData" that allows lazy init and safe updates. * Add calculation time out enforcer (60min), check every 5min. * Show `isRefreshing` when we are either downloading keys or the ENF is still calculating. * Rename "token" to "identifier", we'll likely keep using this class for ENF Window Mode, which has no more "tokens". * Remove "state", we can only know whether it's running and that can be based on the `finishedAt` timestamp. Also improve test readability a bit and added more edge cases when checking timeouts. * Additional test cases for ENF calculation edge cases * We are fine with tracking the last 5 calculations. * Exclude timeouts from `latestFinishedCalculation` * HotData should be named HotDataFlow * Clean up coroutine/flow packages. * Remove additional combineTransform instances, to prevent accidental casting errors in the future. * We should only forward calls to the provider and the calculation tracker if the list of key files is non-empty. * Add unit test to check for GSON data class restoration behavior with transient fields. GSON sets it to false, and does not eval the properties to set them. * Lints, Lints, Lints * Only check the calculation status of the newest submission. The chance for overlapping calculations is rare with batched key submission, and if gives us a lower chance of actually being affected by timeouts. * Reduce timeout for tracked calculations to 15 minutes after discussion with Maximilian. In worst case scenarios no calculation exceeded 7 minutes. * Reduce timeout check interval to 3 minutes, due to lowered overall timeout limit. * Add additional test case that checks that a late result, past timeout, overwrites the timeout. * Create `BaseGson` instance within the DI graph use it. Allows use to later set global settings (pretty print for testers?), or hook up custom serializers app-wide.
-
Kolya Opahle authored
Cannot delete tests older than 21 days - DE: Tests die älter als 21 Tage sind, können nicht gelöscht werden (EXPOSUREAPP-2398) (#1481) * Added new card to show redeemed tests on the home screen Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Fixed linting and unit tests Signed-off-by:
Kolya Opahle <k.opahle@sap.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
Ralf Gehrer authored
-
janetback authored
Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
Matthias Urhahn authored
Typo. Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
AlexanderAlferov authored
* Deadman notification text for translation * Fixed typo
-
Kolya Opahle authored
* Removed background priority settings from the settings ui * Revert "Removed background priority settings from the settings ui" This reverts commit c0447a1a52da6a4bc33aac01ceb28afce049cf98. * Removed background priority switch from settings ui and replaced with intent to open settings, also replaced in notification on first launch Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Card is now always visible and changed text Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Revert "Card is now always visible and changed text" This reverts commit cae7c0fcc4575c67fb1a3d12b8a304a2416543f0. * Added new german strings to status card and made it permanently visible * Removed unnecessary constraint layout from xml file Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Removed additional unneeded constraint layout Signed-off-by:
Kolya Opahle <k.opahle@sap.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
Ralf Gehrer authored
* Fix text issues for low risk with 0/1+ encounters (EXPOSUREAPP-3193) * revert deletion of default string Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
Ralf Gehrer authored
-
janetback authored
-
Ralf Gehrer authored
-
- Oct 23, 2020
-
-
BMItter authored
Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
harambasicluka authored
* move strings * added default strings * fixed comment indention
-
- Oct 22, 2020
-
-
janetback authored
Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
AlexanderAlferov authored
* Build.gradle signing fix * Test config.yml * Clean up Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
vaubaehn authored
-
- Oct 21, 2020
-
-
AlexanderAlferov authored
Version bump
-
chris-cwa authored
Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
Matthias Urhahn authored
* Increase transaction timeout to 8 minutes. * Fix timeout variable test. * Adjust code comment to mention the 10min limit. Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
Matthias Urhahn authored
Fix automatic data reset on for users affected by encryption issues (EXPOSUREAPP-3313, EXPOSUREAPP-3335) (#1433) * I overlooked that `KeyException` is a subclass of `GeneralSecurityException`. This causes us to continue with `KeyException` which then fails the message matching test. As the underlying Tink code throws the GeneralSecurityException first, we check the type of the last exception. * Add additional specific test cases for nested exceptions. * The dialog shouldn't automatically dismiss when the user clicks details. They may not have read the dialog message completely or want to re-read it.
-
- Oct 20, 2020
-
-
AlexanderAlferov authored
* Added conditions for apk signing * Update testers flavour * Config fix * Disable assemble job skip * Create separate workflow * Fix config.yml * Clean up
-
- Oct 19, 2020
-
-
Matthias Urhahn authored
* Introduced `TracingCardState` and `TracingDetailsState`. Removed all direct viewmodel/livedata access from all nested layouts for `TracingViewModel`. Removed `FormatterRiskHelper`. Introduced logic to reactively update the UI state if bluetooth, location or tracing state changes. TODO: * Finish tests in TracingCardStateTest.kt and TracingDetailsStateTest.kt * Finish TracingDetailsViewModel.kt and TracingCardViewModel.kt * Remove obsolete dependencies on TracingViewModel.kt and singletons RiskLevelRepository.kt, TracingRepository.kt * Breakthrough, cards update again. * Further cleanup of TracingViewModel.kt, TracingRepository.kt Still not quite there yet, too many calls going into every direction, back and forth, instead of just top->down, but we are getting there. We want data flow from business logic code to the UI, keep the UI KISS. * Update TracingCardState tests to account for changes * More refactoring, TracingViewModel.kt is now finally gone. * Fix risk details card, we reuse the cardviewmodel but need to overwrite the `showDetails` flag depending from where it's used. * Refactored several properties (notification related) out of SettingsViewModel/Repository * Fix injection * Refactoring submission related databinding code on the home fragment * Make TracingRepository.kt injectable and change viewmodel scoping for refresh calls to app scope. * Remove additional formatter calls from submission cards on home screen. * Refactored additional SubmissionViewModel logic into SubmissionRepository on the Homescreen. First UI Test is now passing. Simplified ViewModel instantiation related code. Prepared HomeFragment for smoother UI state changes, less reloading. * Improved home,tracing-details and tracing-settings loading behavior, less flickering. Fixed LiveData value assignment on background-thread. * New reactive provider for Bluetooth and Location status. Cleaned up ConnectivityHelper.kt partially. * Implement remaining tests, batch 1. * Implement remaining tests, batch 2. * Fix lint issues. * Removed a few codesmells and code duplication. Introduced Flow.shareLatest(...) * Removed unused parameters. * LINT fixes. * Fix unit test failing due to missing mocks. * Address PR comments. * Improve UI loading states, remove flickering. * Remove log spam due to polling values, add extra abort condition that checks for cancellation. Co-authored-by:
ralfgehrer <mail@ralfgehrer.com>
-
- Oct 18, 2020
-
-
Oliver Zimmerman authored
* converted SubmissionTanFragment to assisted inject * removed unused import * Refactored submission dispatcher * lint fixes * removed unnecessary companion object * Submission Test Result refactored * Submission Contact refactored * Submission Done Refactored and lint fixes * more lint fixes * Submission Intro refactored * interface fix * Submission QR Codde Scan refactored * SubmissionResultPositiveOtherWarning refactored * Adapted Navigation style to use SubmissionNavigationEvent - aligns with Onboarding refactoring. * Submission Symptom Introduction refactored and fragment restructure * SymptomCalendar refactor and ktlint * ktlint * deleted unnecessary extra line * ktlint * removed directions declaration that was causing issues * navigation fix * Move companion object to end of class * Migrated submission modules to SubmissionActivityModule, and included in MainActivityModule * Use nav util instead of findNavController + ktlint fixes * more lint fixes * refactor name of SubmissionActivityModule to SubmissionFragmentModule Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
- Oct 16, 2020
-
-
janetback authored
* Update legal_strings.xml * Update Corona-Warn-App/src/main/res/values-de/legal_strings.xml Co-authored-by:
Sabine Loss <44154356+SabineLoss@users.noreply.github.com> Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com> Co-authored-by:
Sabine Loss <44154356+SabineLoss@users.noreply.github.com>
-
- Oct 15, 2020
-
-
Matthias Urhahn authored
* Switch 3 to 24 hour mode * Fix incorrect toast message. * Create `TestSettings` class. * Adjust test to handle 24 hour mode. * Adjust test to check for day rollover in hourly keypkg mode. Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
Matthias Urhahn authored
* + timeout field * updated the example * Add support for Timeout logic to the TaskController (+tests ofc). Co-authored-by:
chris-cwa <chris.cwa.sap@gmail.com>
-
janetback authored
Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
- Oct 14, 2020
-
-
Matthias Urhahn authored
* Increase transaction timeout to 8 minutes. * Fix timeout variable test. * Adjust code comment to mention the 10min limit. Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-