Skip to content
Snippets Groups Projects
  1. Nov 12, 2020
  2. Nov 10, 2020
  3. Nov 03, 2020
  4. Oct 30, 2020
  5. Oct 29, 2020
    • Alexander Alferov's avatar
      Test flavour build with extract native libs flag set to true · 6f036b05
      Alexander Alferov authored
      Test pipeline config
      6f036b05
    • BMItter's avatar
      Improved crash logging & handling (EXPOSUREAPP-2572) (#1475) · be4c773d
      BMItter authored
      
      * FileLoggerPlus - RX added - preparation
      
      * Buffer config as constants
      
      * avoid empty lines
      
      * Reworked logging to file - wip
      
      * Collecting errors to dao - wip
      
      * Added crash report to app db and created module
      
      * do it
      
      * inject crashReportTree - wip
      
      * use dagger injection
      
      * retrieve short hash via gradle
      
      * removed todo
      
      * Updated database to version 2 for new ReportEntity - old base
      
      * deprecated old engagement - RX not allowed anymore
      
      * use global scope for coroutines in crash report tree - ktlint clean
      
      * added menu item - error reporter (replace later to new structure)
      
      * basic recylcerview and fragment added to menu - wip
      
      * deprecated data class
      
      * Delete CrashModel.kt
      
      * crash report list item to use data binding
      
      * separated Reporteradapter - klint clean
      
      * use separated Adapter in ReporterFragment - cleanup
      
      * Added ErrorReporterViewModel - connected data to list
      
      * dependency injection for crash report, better structure, todo cleanup
      
      * some refactoring, cleanup, ktlint
      
      * adjustments for 1.6.x
      
      * temp action to open crash report fragment
      
      * removed testcode
      
      * updated layout - wip
      
      * connected view & data
      
      * satisfy circle ci checks
      
      * plant reportingTree, testbutton, klint clean
      
      * updated layout for reporter - wip
      
      * better format and layout
      
      * better message handling
      
      * missing icons for errors on debug
      
      * Adjusted error report index
      
      * Removed ugly show button, report clickable
      
      * Added SettingsCrashReportDetailsFragment & corresponding files
      
      * fixed merge inconsistence
      
      * fixed injection overall
      
      * use livedata
      
      * details added to report - wip
      
      * beauty
      
      * share & layout root preparation
      
      * make error report shareable
      
      * removed Dispatcher.IO for example
      
      * Introduce skeleton classes for bugreporting
      
      * Refactoring, adjustments to be able to build again
      
      * Created BugEventEntity, Changed id to Long for more efficiency,  Removed unused events
      
      * refactored ui to deviceForTesters, testmenu etc
      
      * adjusted interfaces & related, better structure
      
      * uses own db, added converter, adjusted modules
      
      * adjusted bugrepo, defaultbugrepo
      
      * shared report, better visualisation
      
      * changed crash db name
      
      * Implemented DefaultBugRepository
      
      * Added device info to BugEvent, BugReporter collects Tag, Added default impl of BugEvent etc
      
      * corrected bug in RollingLogHistory
      
      * removed deprecated crash package
      
      * quickfix - wip
      
      * cleanup
      
      * cleanUp, adjusted simulation button to new structure
      
      * moved bug related layouts to deviceForTesters package
      
      * removed old RX dependenies and related context
      
      * fix build for deviceDebug
      
      * lint clean
      
      * current set of relevant exceptions as before
      
      * attach log to output
      
      * improved output
      
      * Delete obsolet ic_bug in main
      
      * Delete ic_coffee.xml
      
      * changed shortID to shortCommitHash for better transparency
      
      * companion to bottom
      
      * removed string encapsulation
      
      * cleanup unused import and blank line - PR Comment
      
      * typo fixed
      
      * rm empty line
      
      * removed relict module
      
      * layout fix
      
      * adjusted unrelated method call
      
      * fixed package inkonsistence
      
      * Use flow instead of livedata in non-ui
      
      * better fun naming
      
      * Replaced interface with inline listener
      
      * Improved SettingsCrashReportDetailsFragment and SettingsCrashReportViewModel, formatting adjusted
      
      * cleaned converter
      
      * Delete Project.xml
      
      * added log statement to DefaultBugRepository
      
      * adjusted magical number
      
      * Use CommonConverters instead of unique Converters in BugDatabase
      
      * Extension function for the resuce -defaultBugRepository
      
      * removed FormatterCrashReport completly
      
      * changed long to UUID
      
      * satisfy buggy ktlint checks
      
      * Update SettingsCrashReportViewModel.kt
      
      use postvalue
      
      * avoid passing viewmodel
      
      * store appVersionCode as Long for beeing futuresave
      
      * Update SettingsCrashReportViewModel.kt
      
      removed lazy init
      
      * Changed BugDatabase to factory pattern
      
      Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>
      Co-authored-by: default avatarharambasicluka <64483219+harambasicluka@users.noreply.github.com>
      be4c773d
  6. Oct 23, 2020
  7. Oct 22, 2020
  8. Oct 21, 2020
  9. Oct 20, 2020
  10. Oct 19, 2020
    • Matthias Urhahn's avatar
      Refactor missused ViewModels, support automated UI tests and screenshots (EXPOSUREAPP-2946) (#1415) · cec56fdb
      Matthias Urhahn authored
      
      * Introduced `TracingCardState` and `TracingDetailsState`.
      Removed all direct viewmodel/livedata access from all nested layouts for `TracingViewModel`.
      Removed `FormatterRiskHelper`.
      Introduced logic to reactively update the UI state if bluetooth, location or tracing state changes.
      
      TODO:
      * Finish tests in TracingCardStateTest.kt and TracingDetailsStateTest.kt
      * Finish TracingDetailsViewModel.kt and TracingCardViewModel.kt
      * Remove obsolete dependencies on TracingViewModel.kt and singletons RiskLevelRepository.kt, TracingRepository.kt
      
      * Breakthrough, cards update again.
      
      * Further cleanup of TracingViewModel.kt, TracingRepository.kt
      Still not quite there yet, too many calls going into every direction, back and forth, instead of just top->down, but we are getting there.
      We want data flow from business logic code to the UI, keep the UI KISS.
      
      * Update TracingCardState tests to account for changes
      
      * More refactoring, TracingViewModel.kt is now finally gone.
      
      * Fix risk details card, we reuse the cardviewmodel but need to overwrite the `showDetails` flag depending from where it's used.
      
      * Refactored several properties (notification related) out of SettingsViewModel/Repository
      
      * Fix injection
      
      * Refactoring submission related databinding code on the home fragment
      
      * Make TracingRepository.kt injectable and change viewmodel scoping for refresh calls to app scope.
      
      * Remove additional formatter calls from submission cards on home screen.
      
      * Refactored additional SubmissionViewModel logic into SubmissionRepository on the Homescreen.
      First UI Test is now passing.
      
      Simplified ViewModel instantiation related code.
      Prepared HomeFragment for smoother UI state changes, less reloading.
      
      * Improved home,tracing-details and tracing-settings loading behavior, less flickering.
      Fixed LiveData value assignment on background-thread.
      
      * New reactive provider for Bluetooth and Location status.
      Cleaned up ConnectivityHelper.kt partially.
      
      * Implement remaining tests, batch 1.
      
      * Implement remaining tests, batch 2.
      
      * Fix lint issues.
      
      * Removed a few codesmells and code duplication.
      Introduced Flow.shareLatest(...)
      
      * Removed unused parameters.
      
      * LINT fixes.
      
      * Fix unit test failing due to missing mocks.
      
      * Address PR comments.
      
      * Improve UI loading states, remove flickering.
      
      * Remove log spam due to polling values, add extra abort condition that checks for cancellation.
      
      Co-authored-by: default avatarralfgehrer <mail@ralfgehrer.com>
      cec56fdb
  11. Oct 13, 2020
  12. Oct 12, 2020
  13. Oct 09, 2020
  14. Oct 08, 2020
  15. Oct 07, 2020
    • AlexanderAlferov's avatar
      Version bump (DEV) (#1347) · 899a5bdd
      AlexanderAlferov authored
      899a5bdd
    • Matthias Urhahn's avatar
      Introduce VM injection for home screen and enable screen testing... · b4f32951
      Matthias Urhahn authored
      Introduce VM injection for home screen and enable screen testing (EXPOSUREAPP-2946, EXPOSUREAPP-2948) (#1320)
      
      * Rename "MainFragment" to "HomeFragment"
      Add VM injection.
      Move initial logic into VM.
      
      TODO: Move more code, write more tests.
      
      * Additional refactoring, moving logic out of the Fragment.
      Moving code into their own encapsulated routines/components.
      Use composition to reuse TracingViewModel, SettingsViewModel and SubmissionViewModel
      
      * Introduce @AppContext annotation to prevent anyone mistaking it for something else.
      
      * Add VM to RiskDetailsFragment
      
      * Simplify nested viewmodels, here: TracingViewModel.kt
      
      * Add skeletons instrumentation test skeleton for single fragments with injection and mocking.
      
      * Address PR comments.
      
      * Introduce sealed events class, + some refactoring.
      
      * Make the linter happy.
      b4f32951
  16. Oct 06, 2020
  17. Oct 02, 2020
    • AlexanderAlferov's avatar
      Version bump (#1297) · fcc8ceb2
      AlexanderAlferov authored
      
      1.5.0 version code and name bump
      
      Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>
    • Matthias Urhahn's avatar
      Reduce code duplication (EXPOSUREAPP-2844) (#1286) · d64a5825
      Matthias Urhahn authored
      * Remove code duplication between different flavors.
      Remove extra MainFragment and NavGraph.
      Introduce TestMenu indirection
      Add logic for splitting test code up into extra fragments.
      
      * Style list items a bit :)
      
      * fix lints
      
      * Detekt *hug*
      
      * We can only show the menu entry if we are actually on the right flavor,
      otherwise, in deviceDebug, we would not have access to the right resources.
      
      * Address PR comments
      
      * Fix wrong XML namespace.
      d64a5825
    • Matthias Urhahn's avatar
      Improve API test fragment and environment switching (DEV) (#1269) · a9ae4ad8
      Matthias Urhahn authored
      
      * Define environment for each flavor and build type.
      
      * Add smart LiveData class that does async initialization (not on the main thread).
      
      * View extensions setGone/setInvisible
      
      * Refactor test for api fragment.
      
      * Replace ALT environment with a list to select from.
      
      * klint
      
      * Fix tests
      
      * Fix tests
      
      * Further flaky test fixes.
      
      * Move the debug check for isLast3HourModeEnabled to the settings.
      The KeyFileDownloader.kt shouldn't be aware of that detail.
      The settings are what is affected by the build flavors/modes.
      
      * Code cleanup and UI improvement of fragment_test_for_a_p_i.xml
      
      * Code that retries flaky tests until we found a better solution.
      Not great, Not terrible...
      
      Co-authored-by: default avatarMert Safter <mert.safter@sap.com>
      a9ae4ad8
  18. Sep 29, 2020
    • Matthias Urhahn's avatar
      Alternative environment setup (#1246) · b6815dc6
      Matthias Urhahn authored
      
      * Move AppConfig related code into it's own package.
      * Use "files" instead of "cache" for storing our AppConfigApiTest.
      * Add "files" to "cache" migration.
      * Refactor CDN related code into an independent "environment module".
      
      TODO: UnitTests, Fallback behavior even if cached AppConfig is stale.
      
      * Further structure refactoring and unit test for app config cache migration.
      
      * Added config fallback behavior for all cases + additional tests.
      
      * Improve code readability.
      
      * First POC for multi-environment support.
      
      * logic for ACME test Countries toggle button in Dev menu
      
      * ACME Test Countries dev menu
      
      * Additional clean up and refactoring on build constants.
      
      * Cleaned up the test fragment a bit.
      
      * Fixed detekt issue
      
      * Fix flaky test that depends on build variant.
      
      * Let the test fragment show us the actual environment we toggled to.
      
      * Changes upon review
      
      * Address PR comments.
      
      Co-authored-by: default avatarRituraj Sambherao <git.rituraj.sambherao@gmail.com>
      b6815dc6
    • AlexanderAlferov's avatar
      Version code bump (#1259) · 7ff340f6
      AlexanderAlferov authored
      Version code bump to 42
      7ff340f6
    • AlexanderAlferov's avatar
  19. Sep 28, 2020
  20. Sep 18, 2020
    • Matthias Urhahn's avatar
      Revert "Interoperability to 1.5.X (#1173)" · c419ae66
      Matthias Urhahn authored
      This reverts commit 6054bf57.
      c419ae66
    • Jakob Möller's avatar
      Interoperability to 1.5.X (#1173) · 6054bf57
      Jakob Möller authored
      
      * Added first set of country flags
      
      Signed-off-by: default avatarKolya Opahle <k.opahle@sap.com>
      
      * Added first implementation of Submission Country Selection Screen. (Currently not part of nav graph).
      Moved stuff inside of submission package into subpackages
      
      Signed-off-by: default avatarKolya Opahle <k.opahle@sap.com>
      
      * Added missing changes to nav_graph file
      
      * Test Menu options for Country selection and Measurement (EXPOSUREAPP-2229) (#1086)
      
      * Implement country filter (#2229)
      
      * Implement measure for Risk calculation and Key Retrieval (#2229)
      
      * Some code cleanup for measureRiskLevelAndKeyRetrieval
      
      * Some code cleanup (#2229)
      
      * Implement usage of AppConfig usage for country codes (#2229)
      
      * change CURRENT_COUNTRY val to var
      
      * Suppress "LongMethod" warning (#2229)
      
      * Adjust unit tests to respect new country filter
      
      * Align with backend for app config country property name
      
      * Display total file size of keys in results (#2229)
      
      * Fix linting issue
      
      * Update strings.xml files
      
      * Do refactoring and some code clean up
      
      * Move RiskLevel and Key retrieval measurement in own class
      
      * Move code in logical classes. Remove translation in test fragment
      
      * Fix linting and Unit tests
      
      * Remove 3hour boolean check from debug class.
      
      * Refactor CountryWrapper and missing dates check.
      
      * Fix linting and Unit tests
      
      * Add Unit test for getMissingDates
      
      * Code cleanup
      
      * Hide keyboard on action
      
      * Extend statistics for api submission
      
      * Set callback to null after invoked
      
      Co-authored-by: default avatarMert Safter <mert.safter@sap.com>
      Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>
      
      * Overhaul of DiagnosisKey related Download and Caching Mechanisms (EXPOSUREAPP-2469) (#1136)
      
      * Rework of keyfile download and caching.
      * Supports interop
      * More modular for better testing and build flavour based behavior adjustments
      * More resilient handling of failed downloads
      * Preperations for future hourly download and serverside checksums
      
      TODO: Finish unit tests, keycache migration and cache health check
      
      * First batch of unit tests and some fixes for incorrect behavior that the tests surfaced.
      
      * Added unit tests for the KeyCacheRepository
      
      TODO: Tests for downloader and migration.
      
      * Implemented POC for migration old key files.
      
      * Fixed legacy file migration and cleanup, improved logging.
      
      * Added unit tests for legacy key file migration.
      
      * Add fallback for different file hashes in the header.
      
      * Yes kLint, we know it's a long method,
      but for this it's better to read it in one block vs jumping to extra methods.
      
      * More linting issues, adjusting project code style prevent a few of these in the future.
      
      * Added missing unit tests for `KeyFileDownloader` and fixed faulty behavior that was noticed during testing.
      
      * CRUD (instrumentation) test for `KeyCacheDatabase`
      
      * Remove unused `FileStorageHelper` and related constants+tests.
      
      * Fix last3Hours unit test in deviceRelease mode, we need to explicitly enable debug for these tests.
      
      * Until we have more information about the hashsum's format in the header, default to `ETag
      
      * Split app config server API from diagnosis key download API,
      and reintroduce caching for the app config download.
      
      * Add test to check that the cache is used on flaky connections.
      
      * Code changes based on PR comment, part #1.
      
      * Code fluff, formatting.
      
      * Handle download errors correctly.
      
      * Refactoring:
      * Remove unnecessary `currentDate` we always start with the newest date from the servers index.
      * Make a specialised class for header validation
      
      * Let legacy cache migration abort early, depending on whether the key dir exists.
      
      * If we can't create the base directory for the key repo, throw an exception.
      
      * Delete cache entry if a download fails.
      
      * Fixed test regression due to refactoring.
      
      * Consolidate staleness check into `getStale`
      
      * Consolidate clean up for failed downloads into the download method.
      Added tests to check that we delete the keycache entry if the download fails (which we didn't for hours :O!)
      
      * Because the hour-mode uses caching too, we add an explicit button to the test menu that clears the cache.
      
      * Add comment with reference to ticket regarding follow up on the other headers.
      
      * Move expected storage size per country into a named constant.
      
      Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>
      
      * Implementation of tests for the interoperability countries selection screen (EXPOSUREAPP-2439) (#1140)
      
      * Added initial set of viewModel tests
      
      Signed-off-by: default avatarKolya Opahle <k.opahle@sap.com>
      
      * Fail tests on unexpected null.
      
      Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>
      
      Co-authored-by: default avatarKolya Opahle <k.opahle@sap.com>
      Co-authored-by: default avatarapopovsap <66370584+apopovsap@users.noreply.github.com>
      Co-authored-by: default avatarMert Safter <69803294+MertSafter@users.noreply.github.com>
      Co-authored-by: default avatarMert Safter <mert.safter@sap.com>
      Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>
      Co-authored-by: default avatarMatthias Urhahn <darken@darken.eu>
      6054bf57
  21. Sep 17, 2020
    • Matthias Urhahn's avatar
      Reduce boilerplate code for fragment view setup (#1161) · 0676ab79
      Matthias Urhahn authored
      
      * Reduce boilerplate code for fragment view setup.
      
      * Fix klint issue + change codestyle to match klint.
      
      * Fixed regressions in `MainFragment` in `device` buildflavor
      
      * Fix kotlin upgrade regression
      
      * Disable KotlinNothingValueException in Kotlin 1.4 until kotest/mockk can handle it.
      
      * Make "binding.lifecycleOwner = this" automatic.
      
      * Addressed PR comments.
      
      * build issue to due mixing branches
      
      Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>
      0676ab79
    • Matthias Urhahn's avatar
      Introduce ViewModel Injection (#1151) · e8320fdf
      Matthias Urhahn authored
      
      * DI: ViewModel (VDC) injection wiring + example in TestRiskLevelCalculation.kt
      
      * Refactoring the TestRiskLevel fragment to demo our new viewmodel approach. Part1
      
      * Refactoring the TestRiskLevel fragment to demo our new viewmodel approach. Part2
      
      * Fix `Unexpected indentation (expected 4, actual 8)`
      
      * Code fluff
      
      * klint
      
      * Remove empty test + klint
      
      * Rename VDC to CWAViewModel
      
      * Add example unit tests for the TestFragment's ViewModel.
      
      * Revert AppInjector renaming.
      
      * Comments explaining the code.
      
      * Rename class to make it's purpose less confusing.
      
      * Revert "Rename class to make it's purpose less confusing."
      
      This reverts commit c80298bb
      
      * Rename class to make it's purpose less confusing.
      
      * Simpler ViewModel Injection example.
      
      * klint <3
      
      Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>
      e8320fdf
    • Oliver Zimmerman's avatar
      Provide onset of symptoms before upload (EXPOSUREAPP-1605) (#1170) · 8c7e0501
      Oliver Zimmerman authored
      
      * initial commit of new fragment for symptom screen
      
      * Added relevant strings for symptom screen. Started editing xml of initial symptom screen
      
      * Addded 3 selection options within symptom screen
      
      * button id name change to something more relevant
      
      * ID changes to be something more relevant to symptom scenerio.
      
      * Implemented symptom initial screen logic. Temporary nav for testing.
      
      * CircleCI formatting
      
      * Adapted interoperability test provided by apopov
      
      * Added accessibilty announcement on resume, fixed navigation for main page
      
      * circleCI indentation fix
      
      * removed ar & ru and updated default strings
      
      * Adaption to ViewModel logic. Not yet complete
      
      Adaption to ViewModel logic, attempting to align with implementation done with some interoporibility tasks: reusable layout files, etc.
      
      * More ViewModel transformation additions
      
      * revert nav from test. Circle CI formatting changes
      
      * Update SubmissionSymptomIntroductionFragment.kt
      
      * Removed old fragment based test
      
      * Will implement navigation during marry session.
      
      * Update SubmissionViewModel.kt
      
      * Calendar button selection screen + required strings
      
      * Custom calendar view
      
      * Accessibility improved
      
      * introduced data types for symptoms
      
      * represent date by long in millis
      
      * new TransmissionRiskVector
      
      * Constants and formatting
      
      * Naming changes requested
      
      * Better event naming
      
      * Update fragment_submission_symptom_intro.xml
      
      * Finishing calendar implementation - still need to implement calendar widget
      
      Surrounding calendar submission UI - minus calednar widget
      Necessary strings
      
      * Merged introduction and calendar screen.
      
      Created calendar fragment screen,
      Finished calendar XML view
      Added required entries for choices in SubmissionViewModel
      Adjusted Formatters for button selection.
      Changed nav graph.
      
      * + todo
      
      * CircleCI code style changes
      
      * EXPERT STUFF
      
      * Latest push for marry session
      
      * replaced transaction risk vector
      
      * update textcolor on symptom indication change
      
      * update buttons by code
      
      * code formatting
      
      * Added logic for Negative and No Information buttons and adjusted xml view to be more aligned with design
      
      Added logic for Negative and No Information buttons and adjusted xml view to be more aligned with design
      
      * disable next button when state is null.
      
      * + readability
      
      * Calendar screen logic adapted for button selection
      
      * extracted domain logic from prototype and from transaction
      
      * - not used events
      
      * joint improvements
      
      * removed unused events
      
      * Calendar unsetSelection added
      
      * detekt rules changed and formatting
      
      * - calendar view refactor: CalendarCalculator singleton introduced for batter testing capacity
      - unit tests added
      
      * detekt issues
      
      * Colors and styles cleared
      
      * fixed strings
      
      * maintained unit tests
      
      * adopted changes from main nav graph to device for testers nav graph
      
      * reverted comment
      
      * made start of symptoms nullable
      
      * tests
      
      * Adjusted navigation, fixed dark theme
      
      * Update Project.xml
      
      * use of postValue() in SubmissionViewModel.kt
      
      * Added direction in tester nav graph
      
      * improvements required by review
      
      * moving companion
      
      * moving companion
      
      * moving companion
      
      * fixed issues from partner review
      
      * fixed issues from partner review
      
      * fixed issues from partner review
      
      * fixed issues from partner review
      
      * fixed issues from partner review
      
      * using utc
      
      * edge case tests
      
      * made inner class
      
      * Refactored Symptoms Class Name (+data class)
      
      * Change SubmissionViewModel scope to ensure that the same viewmodel is used to store submission data.
      
      * extracted null check + log
      
      Co-authored-by: default avatarLuka Harambasic <luka.harambasic@sap.com>
      Co-authored-by: default avatarchris-cwa <chris.cwa.sap@gmail.com>
      Co-authored-by: default avatarAlexander Alferov <a.alferov@sap.com>
      Co-authored-by: default avatarharambasicluka <64483219+harambasicluka@users.noreply.github.com>
      Co-authored-by: default avatarMatthias Urhahn <darken@darken.eu>
      Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>
      8c7e0501
Loading