- Sep 23, 2020
-
-
chris-cwa authored
* texts for interop user consent * default values Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
SAP LX Lab Service Account authored
* [INTERNAL] Translation delivery: commit by LX Lab Change-Id: I819e9a5a620221a7267bb9737396fbb966852bb0 * [INTERNAL] Translation delivery: commit by LX Lab Change-Id: I932bc1aa24d4ebe65681cf78c1f109266e695980 Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
- Sep 22, 2020
-
-
Matthias Urhahn authored
* Improve error message and add logic for future display of formatted error messages. * Address PR review comments.
-
- Sep 18, 2020
-
-
Matthias Urhahn authored
We need to hook into `viewLifecycleOwner` not `lifeCycleOwner` otherwise the DataBinding is not correctly recreated whe fragments are reattached. (#1182) Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Matthias Urhahn authored
Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Matthias Urhahn authored
Refactor MD5 extraction to be part of `DiagnosisKeyServer`'s responsibility. Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Matthias Urhahn authored
Fix interop squash commit
-
Matthias Urhahn authored
-
Matthias Urhahn authored
This reverts commit 6054bf57.
-
Jakob Möller authored
* Added first set of country flags Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Added first implementation of Submission Country Selection Screen. (Currently not part of nav graph). Moved stuff inside of submission package into subpackages Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Added missing changes to nav_graph file * Test Menu options for Country selection and Measurement (EXPOSUREAPP-2229) (#1086) * Implement country filter (#2229) * Implement measure for Risk calculation and Key Retrieval (#2229) * Some code cleanup for measureRiskLevelAndKeyRetrieval * Some code cleanup (#2229) * Implement usage of AppConfig usage for country codes (#2229) * change CURRENT_COUNTRY val to var * Suppress "LongMethod" warning (#2229) * Adjust unit tests to respect new country filter * Align with backend for app config country property name * Display total file size of keys in results (#2229) * Fix linting issue * Update strings.xml files * Do refactoring and some code clean up * Move RiskLevel and Key retrieval measurement in own class * Move code in logical classes. Remove translation in test fragment * Fix linting and Unit tests * Remove 3hour boolean check from debug class. * Refactor CountryWrapper and missing dates check. * Fix linting and Unit tests * Add Unit test for getMissingDates * Code cleanup * Hide keyboard on action * Extend statistics for api submission * Set callback to null after invoked Co-authored-by:
Mert Safter <mert.safter@sap.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> * Overhaul of DiagnosisKey related Download and Caching Mechanisms (EXPOSUREAPP-2469) (#1136) * Rework of keyfile download and caching. * Supports interop * More modular for better testing and build flavour based behavior adjustments * More resilient handling of failed downloads * Preperations for future hourly download and serverside checksums TODO: Finish unit tests, keycache migration and cache health check * First batch of unit tests and some fixes for incorrect behavior that the tests surfaced. * Added unit tests for the KeyCacheRepository TODO: Tests for downloader and migration. * Implemented POC for migration old key files. * Fixed legacy file migration and cleanup, improved logging. * Added unit tests for legacy key file migration. * Add fallback for different file hashes in the header. * Yes kLint, we know it's a long method, but for this it's better to read it in one block vs jumping to extra methods. * More linting issues, adjusting project code style prevent a few of these in the future. * Added missing unit tests for `KeyFileDownloader` and fixed faulty behavior that was noticed during testing. * CRUD (instrumentation) test for `KeyCacheDatabase` * Remove unused `FileStorageHelper` and related constants+tests. * Fix last3Hours unit test in deviceRelease mode, we need to explicitly enable debug for these tests. * Until we have more information about the hashsum's format in the header, default to `ETag * Split app config server API from diagnosis key download API, and reintroduce caching for the app config download. * Add test to check that the cache is used on flaky connections. * Code changes based on PR comment, part #1. * Code fluff, formatting. * Handle download errors correctly. * Refactoring: * Remove unnecessary `currentDate` we always start with the newest date from the servers index. * Make a specialised class for header validation * Let legacy cache migration abort early, depending on whether the key dir exists. * If we can't create the base directory for the key repo, throw an exception. * Delete cache entry if a download fails. * Fixed test regression due to refactoring. * Consolidate staleness check into `getStale` * Consolidate clean up for failed downloads into the download method. Added tests to check that we delete the keycache entry if the download fails (which we didn't for hours :O!) * Because the hour-mode uses caching too, we add an explicit button to the test menu that clears the cache. * Add comment with reference to ticket regarding follow up on the other headers. * Move expected storage size per country into a named constant. Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> * Implementation of tests for the interoperability countries selection screen (EXPOSUREAPP-2439) (#1140) * Added initial set of viewModel tests Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Fail tests on unexpected null. Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> Co-authored-by:
Kolya Opahle <k.opahle@sap.com> Co-authored-by:
apopovsap <66370584+apopovsap@users.noreply.github.com> Co-authored-by:
Mert Safter <69803294+MertSafter@users.noreply.github.com> Co-authored-by:
Mert Safter <mert.safter@sap.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> Co-authored-by:
Matthias Urhahn <darken@darken.eu>
-
Matthias Urhahn authored
# Conflicts: # .idea/codeStyles/Project.xml # Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/TestRiskLevelCalculationFragment.kt # Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/api/ui/TestForAPIFragment.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/submission/fragment/SubmissionQRCodeScanFragment.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/submission/fragment/SubmissionResultPositiveOtherWarningFragment.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/submission/fragment/SubmissionTanFragment.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/di/ApplicationComponent.kt
-
- Sep 17, 2020
-
-
Matthias Urhahn authored
* Reduce boilerplate code for fragment view setup. * Fix klint issue + change codestyle to match klint. * Fixed regressions in `MainFragment` in `device` buildflavor * Fix kotlin upgrade regression * Disable KotlinNothingValueException in Kotlin 1.4 until kotest/mockk can handle it. * Make "binding.lifecycleOwner = this" automatic. * Addressed PR comments. * build issue to due mixing branches Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Matthias Urhahn authored
* DI: ViewModel (VDC) injection wiring + example in TestRiskLevelCalculation.kt * Refactoring the TestRiskLevel fragment to demo our new viewmodel approach. Part1 * Refactoring the TestRiskLevel fragment to demo our new viewmodel approach. Part2 * Fix `Unexpected indentation (expected 4, actual 8)` * Code fluff * klint * Remove empty test + klint * Rename VDC to CWAViewModel * Add example unit tests for the TestFragment's ViewModel. * Revert AppInjector renaming. * Comments explaining the code. * Rename class to make it's purpose less confusing. * Revert "Rename class to make it's purpose less confusing." This reverts commit c80298bb * Rename class to make it's purpose less confusing. * Simpler ViewModel Injection example. * klint <3 Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
- Sep 16, 2020
-
-
Matthias Urhahn authored
# Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/submission/fragment/SubmissionQRCodeScanFragment.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/submission/fragment/SubmissionResultPositiveOtherWarningFragment.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/submission/fragment/SubmissionTanFragment.kt
-
- Sep 15, 2020
-
-
harambasicluka authored
* update string * update string * update string
-
harambasicluka authored
* updates location text and activated autolink * updated string * own layout for location to set the url * added fallback if label isn't found in string Co-authored-by:
chris-cwa <chris.cwa.sap@gmail.com>
-
Mert Safter authored
Co-authored-by:
Mert Safter <mert.safter@sap.com>
-
BMItter authored
Error Messages after scanning incorrect QR codes fixed Co-authored-by:
Jakob Möller <jakob.moeller@sap.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
chris-cwa authored
* fixed duplicate use of string * klint * + message for translators * + message for translators * fixed submission tan error dialog strings * update string Co-authored-by:
Luka Harambasic <luka.harambasic@sap.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
janetback authored
* Update strings.xml * Update strings.xml * Update privacy_de.html
-
Matthias Urhahn authored
* Fix: No exposure with low risk so far * Fixed klint issues (#1144) * restored reverted replaced wording for lint * https://github.com/corona-warn-app/cwa-app-android/pull/1153#discussion_r487801724 * fixed term Co-authored-by:
chris-cwa <69595386+chris-cwa@users.noreply.github.com>
-
- Sep 14, 2020
-
-
Leo authored
Co-authored-by:
Matthias Urhahn <darken@darken.eu>
-
Kamil Bobrowski authored
Co-authored-by:
Matthias Urhahn <darken@darken.eu>
-
Henrique Faria authored
* Create delegated property to automatically handle Fragment view unbinding * Add new file at the end of file * Remove empty line * Update error message * Add missing imports for other flavors. Co-authored-by:
darken <darken@darken.eu> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Matthias Urhahn authored
Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Rituraj Sambherao authored
* user warning if keys submission flow is inturrpted / cancelled * default string values added for pipeline fix * Warning Dialog strings updated * applied the changes suggested in review Co-authored-by:
Matthias Urhahn <darken@darken.eu> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
Matthias Urhahn authored
# Conflicts: # Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/RiskLevelAndKeyRetrievalBenchmark.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/http/WebRequestBuilder.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/storage/keycache/KeyCacheDao.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/storage/keycache/KeyCacheRepository.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/transaction/RetrieveDiagnosisKeysTransaction.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/CachedKeyFileHolder.kt # Corona-Warn-App/src/test/java/de/rki/coronawarnapp/transaction/RetrieveDiagnosisKeysTransactionTest.kt
-
Rituraj Sambherao authored
* test for OnboardingFragment * QR code stricter validations * regex pattern improvement * removed Obsolete test * lint changes to fix pipeline issue * logic refinement and test coverage improvement * pipeline related fixes * piepline related fixes : unnecessary test removed * pipeline fixes and increased tests coverage * QR code validation logic improvement * detekt pipeline issue resolved * pipeline issue Fix * logic ovehaul and improvement for QRCode scans / validations 1, Data object for ScanResults 2. new Test for ScanResults 3. logic simplified * removing unused imports from tests * Small refactoring together with Rituraj. * Adjust detekt, early abort via return is GOOD! Co-authored-by:
Matthias Urhahn <darken@darken.eu> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Jakob Möller authored
Version Checker with Branching for Checks on provideDiagnosisKeys below v16 of ENF (EXPOSUREAPP-2213) (#1150) * Add Version Check Signed-off-by:
d067928 <jakob.moeller@sap.com> * Version Checker Update Signed-off-by:
d067928 <jakob.moeller@sap.com> * Testing for Version Check Signed-off-by:
d067928 <jakob.moeller@sap.com> * Remove Expiremental Annotation for method and add on Class and pull tearDown below setUp Signed-off-by:
d067928 <jakob.moeller@sap.com> * add GoogleAPIVersion via DI Signed-off-by:
d067928 <jakob.moeller@sap.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Matthias Urhahn authored
-
janetback authored
-
harambasicluka authored
* changes PR template, removed checkboxes and added new points * added: link issues * Update pull_request_template.md * Update pull_request_template.md * Update pull_request_template.md * added acceptance criteria for maintainers * fixed typo * + maintainers link github issues Co-authored-by:
Matthias Urhahn <darken@darken.eu>
-
- Sep 11, 2020
-
-
Matthias Urhahn authored
Remove unavailable test fragment from release navgraph and fix incorrect package/folder structure. (#1146) Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Kolya Opahle authored
Implementation of tests for the interoperability countries selection screen (EXPOSUREAPP-2439) (#1140) * Added initial set of viewModel tests Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Fail tests on unexpected null. Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Matthias Urhahn authored
* Rework of keyfile download and caching. * Supports interop * More modular for better testing and build flavour based behavior adjustments * More resilient handling of failed downloads * Preperations for future hourly download and serverside checksums TODO: Finish unit tests, keycache migration and cache health check * First batch of unit tests and some fixes for incorrect behavior that the tests surfaced. * Added unit tests for the KeyCacheRepository TODO: Tests for downloader and migration. * Implemented POC for migration old key files. * Fixed legacy file migration and cleanup, improved logging. * Added unit tests for legacy key file migration. * Add fallback for different file hashes in the header. * Yes kLint, we know it's a long method, but for this it's better to read it in one block vs jumping to extra methods. * More linting issues, adjusting project code style prevent a few of these in the future. * Added missing unit tests for `KeyFileDownloader` and fixed faulty behavior that was noticed during testing. * CRUD (instrumentation) test for `KeyCacheDatabase` * Remove unused `FileStorageHelper` and related constants+tests. * Fix last3Hours unit test in deviceRelease mode, we need to explicitly enable debug for these tests. * Until we have more information about the hashsum's format in the header, default to `ETag * Split app config server API from diagnosis key download API, and reintroduce caching for the app config download. * Add test to check that the cache is used on flaky connections. * Code changes based on PR comment, part #1. * Code fluff, formatting. * Handle download errors correctly. * Refactoring: * Remove unnecessary `currentDate` we always start with the newest date from the servers index. * Make a specialised class for header validation * Let legacy cache migration abort early, depending on whether the key dir exists. * If we can't create the base directory for the key repo, throw an exception. * Delete cache entry if a download fails. * Fixed test regression due to refactoring. * Consolidate staleness check into `getStale` * Consolidate clean up for failed downloads into the download method. Added tests to check that we delete the keycache entry if the download fails (which we didn't for hours :O!) * Because the hour-mode uses caching too, we add an explicit button to the test menu that clears the cache. * Add comment with reference to ticket regarding follow up on the other headers. * Move expected storage size per country into a named constant. Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Katharina Seiz authored
-
chris-cwa authored
-
harambasicluka authored
-
- Sep 10, 2020
-
-
Jakob Möller authored
Double Timeout Variables for HTTP Requests and Triple the Timeout for the Transaction to ensure less timeouts are received with bad networking. (EXPOSUREAPP-2190) (#1138) Signed-off-by:
d067928 <jakob.moeller@sap.com>
-
Oliver Zimmerman authored
* removed button announcement entirely * removed assosciated test * removed unneccesarry tests Co-authored-by:
Jakob Möller <jakob.moeller@sap.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-