- Jan 07, 2021
-
-
Matthias Urhahn authored
Long methods are not generally bad and should be decided on a case by case basis in PR reviews.
-
- Jan 06, 2021
-
-
Philipp Nowak authored
* - Removed Kotlin Android Extensions plugin - Replaced usages of Kotlin Synthetics by Jetpack view binding - Added Kotlin Parcelize standalone plugin (#2022) * Fix detekt issue (#2022) * Use view binding for TestResultSectionView (EXPOSUREAPP-4495) (#2022) * Use bind() instead of inflate() for view binding in TestResultSectionView (EXPOSUREAPP-4495) (#2022) Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
- Jan 05, 2021
-
-
Chilja Gossow authored
* accessibilty announcement for list items person and location * Merge branch 'release/1.11.x' into feature/4459-accessibility-loc-person # Conflicts: # Corona-Warn-App/src/main/res/layout/contact_diary_location_list_item.xml # Corona-Warn-App/src/main/res/layout/contact_diary_person_list_item.xml * Merge branch 'release/1.11.x' into feature/4459-accessibility-loc-person # Conflicts: # Corona-Warn-App/src/main/res/layout/contact_diary_location_list_item.xml # Corona-Warn-App/src/main/res/layout/contact_diary_person_list_item.xml * add selection announcements * lint * lint * screen announcement * screen announcement * klint * klint * strings correction * strings * refactoring string access * allow spread operator Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
- Nov 09, 2020
-
-
Matthias Urhahn authored
-
- Sep 29, 2020
-
-
Matthias Urhahn authored
Perform data reset for users already affected by the encryption issues (EXPOSUREAPP-1851/EXPOSUREAPP-2958) (#1256) * A reset mechanism that performs a data reset for those (and just those) already affected by the pre 1.4.0 encryption error. If encountered the preference and database file will be deleted, then we will retry to generate an EncryptedSharedPreferences instance, and show the user a popup about what happened. TODO: This still has placeholders for the popup dialog. * Change detekt config. Early returns help code readability if used as guard closes. * Add final texts and fix missing dialog in other build flavors. * Additional test that we also match nested exceptions. * Fix incorrect shared preferences path. * Make klint happy. * Address PR comments. Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by:
Ralf Gehrer <ralfgehrer@users.noreply.github.com>
-
- Sep 17, 2020
-
-
Oliver Zimmerman authored
* initial commit of new fragment for symptom screen * Added relevant strings for symptom screen. Started editing xml of initial symptom screen * Addded 3 selection options within symptom screen * button id name change to something more relevant * ID changes to be something more relevant to symptom scenerio. * Implemented symptom initial screen logic. Temporary nav for testing. * CircleCI formatting * Adapted interoperability test provided by apopov * Added accessibilty announcement on resume, fixed navigation for main page * circleCI indentation fix * removed ar & ru and updated default strings * Adaption to ViewModel logic. Not yet complete Adaption to ViewModel logic, attempting to align with implementation done with some interoporibility tasks: reusable layout files, etc. * More ViewModel transformation additions * revert nav from test. Circle CI formatting changes * Update SubmissionSymptomIntroductionFragment.kt * Removed old fragment based test * Will implement navigation during marry session. * Update SubmissionViewModel.kt * Calendar button selection screen + required strings * Custom calendar view * Accessibility improved * introduced data types for symptoms * represent date by long in millis * new TransmissionRiskVector * Constants and formatting * Naming changes requested * Better event naming * Update fragment_submission_symptom_intro.xml * Finishing calendar implementation - still need to implement calendar widget Surrounding calendar submission UI - minus calednar widget Necessary strings * Merged introduction and calendar screen. Created calendar fragment screen, Finished calendar XML view Added required entries for choices in SubmissionViewModel Adjusted Formatters for button selection. Changed nav graph. * + todo * CircleCI code style changes * EXPERT STUFF * Latest push for marry session * replaced transaction risk vector * update textcolor on symptom indication change * update buttons by code * code formatting * Added logic for Negative and No Information buttons and adjusted xml view to be more aligned with design Added logic for Negative and No Information buttons and adjusted xml view to be more aligned with design * disable next button when state is null. * + readability * Calendar screen logic adapted for button selection * extracted domain logic from prototype and from transaction * - not used events * joint improvements * removed unused events * Calendar unsetSelection added * detekt rules changed and formatting * - calendar view refactor: CalendarCalculator singleton introduced for batter testing capacity - unit tests added * detekt issues * Colors and styles cleared * fixed strings * maintained unit tests * adopted changes from main nav graph to device for testers nav graph * reverted comment * made start of symptoms nullable * tests * Adjusted navigation, fixed dark theme * Update Project.xml * use of postValue() in SubmissionViewModel.kt * Added direction in tester nav graph * improvements required by review * moving companion * moving companion * moving companion * fixed issues from partner review * fixed issues from partner review * fixed issues from partner review * fixed issues from partner review * fixed issues from partner review * using utc * edge case tests * made inner class * Refactored Symptoms Class Name (+data class) * Change SubmissionViewModel scope to ensure that the same viewmodel is used to store submission data. * extracted null check + log Co-authored-by:
Luka Harambasic <luka.harambasic@sap.com> Co-authored-by:
chris-cwa <chris.cwa.sap@gmail.com> Co-authored-by:
Alexander Alferov <a.alferov@sap.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by:
Matthias Urhahn <darken@darken.eu> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
- Sep 14, 2020
-
-
Rituraj Sambherao authored
* test for OnboardingFragment * QR code stricter validations * regex pattern improvement * removed Obsolete test * lint changes to fix pipeline issue * logic refinement and test coverage improvement * pipeline related fixes * piepline related fixes : unnecessary test removed * pipeline fixes and increased tests coverage * QR code validation logic improvement * detekt pipeline issue resolved * pipeline issue Fix * logic ovehaul and improvement for QRCode scans / validations 1, Data object for ScanResults 2. new Test for ScanResults 3. logic simplified * removing unused imports from tests * Small refactoring together with Rituraj. * Adjust detekt, early abort via return is GOOD! Co-authored-by:
Matthias Urhahn <darken@darken.eu> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
- Jun 09, 2020
-
-
Jakob Möller authored
* hard code prod urls Signed-off-by:
d067928 <jakob.moeller@sap.com> * Introduce Error Codes Signed-off-by:
d067928 <jakob.moeller@sap.com> * Introduce Error Codes Signed-off-by:
d067928 <jakob.moeller@sap.com> * Introduce Error Codes Signed-off-by:
d067928 <jakob.moeller@sap.com> * Introduce Error Codes Signed-off-by:
d067928 <jakob.moeller@sap.com> * Introduce Error Codes Signed-off-by:
d067928 <jakob.moeller@sap.com>
-
- Jun 06, 2020
-
-
Jakob Möller authored
* Complex HTTP Errors Signed-off-by:
d067928 <jakob.moeller@sap.com> * Correct Boolean Logic for Client/Server Error Check Signed-off-by:
d067928 <jakob.moeller@sap.com> * Moved error handling of submission flow to CwaWebExceptions (#220) Co-authored-by:
Kolya Opahle <k.opahle@sap.com>
-
- Jun 04, 2020
-
-
Jakob Möller authored
* Circle Hotfix For Build Signed-off-by:
d067928 <jakob.moeller@sap.com> * Replace Volley with Retrofit Signed-off-by:
d067928 <jakob.moeller@sap.com> * Prepare Security Requirements regarding TLS / Pinning Signed-off-by:
d067928 <jakob.moeller@sap.com> * Correct Hash Function Signed-off-by:
d067928 <jakob.moeller@sap.com> * Correct Submission TestResult Call Signed-off-by:
d067928 <jakob.moeller@sap.com> * Enhance Pinning Setup Signed-off-by:
d067928 <jakob.moeller@sap.com> * Enhance Cache Description and print Stack on Report Signed-off-by:
d067928 <jakob.moeller@sap.com> * Correct to 10 MB Signed-off-by:
d067928 <jakob.moeller@sap.com> * BuildConfig Debug for HTTP Output Signed-off-by:
d067928 <jakob.moeller@sap.com> * Lint Correction Signed-off-by:
d067928 <jakob.moeller@sap.com> * Correct AppConfig Request Signed-off-by:
d067928 <jakob.moeller@sap.com> * Lint Signed-off-by:
d067928 <jakob.moeller@sap.com> * Make Bluetooth Enabled Signed-off-by:
d067928 <jakob.moeller@sap.com>
-
- May 30, 2020
-
-
Sebastian Wolf authored
-