Skip to content
Snippets Groups Projects
Select Git revision
  • main default protected
  • changes-try-with-http
  • changes
  • feature/10632-check-in-for-2g-events
  • feature/10535-luca
  • fix/10609-crash-in-booster-rules-test-menu
  • release/2.16.x
  • release/2.15.x
  • fix/delete-duplicate-ids
  • fix/11016-max-limit
  • feature/10888-2g-events-person-overview-ui-changes
  • feature/10698-advanced-root-warning
  • fix/allowlist-navigation-issue
  • feature/10887-Determining_admission_state
  • Wrong-title-on-screen-Zertifikat-auswählen
  • feature/10738-http-logging
  • feature/10644-consent-navigation
  • feature/10635-certificate-pinning
  • feature/10651-selection-consent-II-skeleton
  • release/2.14.x
  • v2.15.1-RC2
  • v2.15.1-RC1
  • v2.15.1-RC0
  • v2.15.0-RC2
  • v2.15.0-RC1
  • v2.15.0-RC0
  • v2.14.1
  • v2.14.1-RC1
  • v2.14.1-RC0
  • v2.14.0-RC1
  • v2.13.3
  • v2.13.3-RC2
  • v2.13.3-RC1
  • v2.13.3-RC0
  • v2.13.2
  • v2.13.2-RC0
  • v2.14.0-RC0
  • v2.13.1
  • v2.13.1-RC1
  • v2.13.1-RC0
40 results
Search by author
  • Any Author
  • Felix Foertsch felixfoertsch
  • Lukas Gehrke Lukas Gehrke lg58weky
  • Martin Mehlhose mehlhose
3 authors
  1. Oct 19, 2020
    • Matthias Urhahn's avatar
      Refactor missused ViewModels, support automated UI tests and screenshots (EXPOSUREAPP-2946) (#1415) · cec56fdb
      Matthias Urhahn authored 
      
* Introduced `TracingCardState` and `TracingDetailsState`.
Removed all direct viewmodel/livedata access from all nested layouts for `TracingViewModel`.
Removed `FormatterRiskHelper`.
Introduced logic to reactively update the UI state if bluetooth, location or tracing state changes.

TODO:
* Finish tests in TracingCardStateTest.kt and TracingDetailsStateTest.kt
* Finish TracingDetailsViewModel.kt and TracingCardViewModel.kt
* Remove obsolete dependencies on TracingViewModel.kt and singletons RiskLevelRepository.kt, TracingRepository.kt

* Breakthrough, cards update again.

* Further cleanup of TracingViewModel.kt, TracingRepository.kt
Still not quite there yet, too many calls going into every direction, back and forth, instead of just top->down, but we are getting there.
We want data flow from business logic code to the UI, keep the UI KISS.

* Update TracingCardState tests to account for changes

* More refactoring, TracingViewModel.kt is now finally gone.

* Fix risk details card, we reuse the cardviewmodel but need to overwrite the `showDetails` flag depending from where it's used.

* Refactored several properties (notification related) out of SettingsViewModel/Repository

* Fix injection

* Refactoring submission related databinding code on the home fragment

* Make TracingRepository.kt injectable and change viewmodel scoping for refresh calls to app scope.

* Remove additional formatter calls from submission cards on home screen.

* Refactored additional SubmissionViewModel logic into SubmissionRepository on the Homescreen.
First UI Test is now passing.

Simplified ViewModel instantiation related code.
Prepared HomeFragment for smoother UI state changes, less reloading.

* Improved home,tracing-details and tracing-settings loading behavior, less flickering.
Fixed LiveData value assignment on background-thread.

* New reactive provider for Bluetooth and Location status.
Cleaned up ConnectivityHelper.kt partially.

* Implement remaining tests, batch 1.

* Implement remaining tests, batch 2.

* Fix lint issues.

* Removed a few codesmells and code duplication.
Introduced Flow.shareLatest(...)

* Removed unused parameters.

* LINT fixes.

* Fix unit test failing due to missing mocks.

* Address PR comments.

* Improve UI loading states, remove flickering.

* Remove log spam due to polling values, add extra abort condition that checks for cancellation.

Co-authored-by: default avatarralfgehrer <mail@ralfgehrer.com>
      Unverified
      cec56fdb
  3. Oct 18, 2020
    • Oliver Zimmerman's avatar
      Refactor submission flow fragments (EXPOSUREAPP-2746) (#1410) · 47af324b
      Oliver Zimmerman authored 
      
* converted SubmissionTanFragment to assisted inject

* removed unused import

* Refactored submission dispatcher

* lint fixes

* removed unnecessary companion  object

* Submission Test Result refactored

* Submission Contact refactored

* Submission Done Refactored and lint fixes

* more lint fixes

* Submission Intro refactored

* interface fix

* Submission QR Codde Scan refactored

* SubmissionResultPositiveOtherWarning refactored

* Adapted Navigation style to use SubmissionNavigationEvent - aligns with Onboarding refactoring.

* Submission Symptom Introduction refactored and fragment restructure

* SymptomCalendar refactor and ktlint

* ktlint

* deleted unnecessary extra line

* ktlint

* removed directions declaration that was causing issues

* navigation fix

* Move companion object to end of class

* Migrated submission modules to SubmissionActivityModule, and included in MainActivityModule

* Use nav util instead of findNavController + ktlint fixes

* more lint fixes

* refactor name of SubmissionActivityModule to SubmissionFragmentModule

Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>
      Unverified
      47af324b
  5. Oct 12, 2020
  7. Oct 07, 2020
    • Matthias Urhahn's avatar
      Introduce VM injection for home screen and enable screen testing... · b4f32951
      Matthias Urhahn authored 
      Introduce VM injection for home screen and enable screen testing (EXPOSUREAPP-2946, EXPOSUREAPP-2948) (#1320)

* Rename "MainFragment" to "HomeFragment"
Add VM injection.
Move initial logic into VM.

TODO: Move more code, write more tests.

* Additional refactoring, moving logic out of the Fragment.
Moving code into their own encapsulated routines/components.
Use composition to reuse TracingViewModel, SettingsViewModel and SubmissionViewModel

* Introduce @AppContext annotation to prevent anyone mistaking it for something else.

* Add VM to RiskDetailsFragment

* Simplify nested viewmodels, here: TracingViewModel.kt

* Add skeletons instrumentation test skeleton for single fragments with injection and mocking.

* Address PR comments.

* Introduce sealed events class, + some refactoring.

* Make the linter happy.
      Unverified
      b4f32951
  9. Oct 06, 2020
  11. Oct 02, 2020
    • Matthias Urhahn's avatar
      Reduce code duplication (EXPOSUREAPP-2844) (#1286) · d64a5825
      Matthias Urhahn authored 
      * Remove code duplication between different flavors.
Remove extra MainFragment and NavGraph.
Introduce TestMenu indirection
Add logic for splitting test code up into extra fragments.

* Style list items a bit :)

* fix lints

* Detekt *hug*

* We can only show the menu entry if we are actually on the right flavor,
otherwise, in deviceDebug, we would not have access to the right resources.

* Address PR comments

* Fix wrong XML namespace.
      Unverified
      d64a5825
    • chris-cwa's avatar
      Legal Texts (EXPOSUREAPP-2954 , EXPOSUREAPP-2951, EXPOSUREAPP-2942,... · eb382edf
      chris-cwa authored 
      Legal Texts (EXPOSUREAPP-2954 , EXPOSUREAPP-2951, EXPOSUREAPP-2942, EXPOSUREAPP-2938, EXPOSUREAPP-2931, EXPOSUREAPP-2925, EXPOSUREAPP-2924, EXPOSUREAPP-2923, EXPOSUREAPP-2922, EXPOSUREAPP-2920, EXPOSUREAPP-2919, EXPOSUREAPP-2918, EXPOSUREAPP-2917) (#1270)

* text body from EXPOSURE_APP 2740

* line breaks

* - duplicate values

* Interoperability: Make Changes to User Consent Text (Initial Onboarding) (EXPOSUREAPP-2938) (#1276)

* 2938 updated legal strings in defaults, de & tr

* added translatable false

* updated german strings (#1278)

* nex text for EXPOSUREAPP-2942

* Legal Textchange: Exposure Logging Screen (EXPOSUREAPP-2923) (#1280)

* Legal Textchange: Home Screen - FAQ Section (EXPOSUREAPP-2922) (#1281)

* Legal Textchange: Initial Onboarding (EXPOSUREAPP-2920) (#1282)

* Legal Textchange: Test Result Screen (EXPOSUREAPP-2918) (#1283)

* Legal Textchange: Info Screen (EXPOSUREAPP-2917) (#1284)

* update string (#1288)

* kEA-2942

* Legal Textchange: New Eula (Nutzungsbedingungen) (EXPOSUREAPP-2951) (#1285)

* updated eula

* updated tr & en eula with german

* Interoperability: Changes to Data Privacy (EXPOSUREAPP-2954) (#1287)

* Interoperability: Make Changes to User Consent Text (Key Upload) (EXPOSUREAPP-2942) (#1275)

* 2942 - strings updated and added to new legal string file

* removed tr strings, to fix circle ci error.

* added translatable false

* Follow up: Initital onboarding 3rd & 6th paragraph (EXPOSUREAPP-2920) (#1289)

* updated & added strings

* updated 6th paragraph

* Legal Textchange: Cross Country Exposure Logging Screen (EXPOSUREAPP-2924) (#1279)

* updated & added strings

* text under countries added

Co-authored-by: default avatarRituraj Sambherao <git.rituraj.sambherao@gmail.com>

* Interoperability: Delta Onboarding (EXPOSUREAPP-2931, EXPOSUREAPP-2919) (#1277)

* 2931 text update

* move to legal text & update 2919

* delta onboarding text changes for initial text

Co-authored-by: default avatarOliver Zimmerman <oezimmerman@gmail.com>

* Legal Textchange: Delta Interop Screen (EXPOSUREAPP-2919)  (#1294)

* 2931 text update

* delta onboarding text changes for initial text

* Added new legal texts and navigation to terms.

- adjused xml layout
- added required strings
- created navigation to legal terms in both nav graphs
- created navigation in fragment

* Update OnboardingDeltaInteroperabilityFragment.kt

* Update OnboardingDeltaInteroperabilityFragment.kt

Co-authored-by: default avatarLuka Harambasic <luka.harambasic@sap.com>

* fixed wrong implementation regrading user consent in warn others

Co-authored-by: default avatarharambasicluka <64483219+harambasicluka@users.noreply.github.com>
Co-authored-by: default avatarRituraj Sambherao <git.rituraj.sambherao@gmail.com>
Co-authored-by: default avatarOliver Zimmerman <oezimmerman@gmail.com>
Co-authored-by: default avatarLuka Harambasic <luka.harambasic@sap.com>
      Unverified
      eb382edf
  13. Sep 23, 2020
    • Mert Safter's avatar
      Interoperability Onboarding and Information (EXPOSUREAPP-2730, EXPOSUREAPP-2733) (#1202) · f85da39e
      Mert Safter authored 
      
* Import flag assets. Create init CountrySelectionList and Fragment

* Implement missing components. Create ViewModel and Repository for Interop

* fix wrong property usage

* Implement storage of selected countries

* Implement warn dialog

* Added navigation from country selection to tracing fragment

* Fixed lint errors

* Fix typo and build error

* Move navigation out of onResume

* Implement Warning dialog and do some code cleanup

* Begin of onboarding for Interoperability. Fix linting issues

* Implement onboarding for Interoperability (#1976)

* Implement skip path of interop screen in onboarding (#1976)

* Implement navigation logic for onBoarding (#1976)

* Fix linting issues

* Adjust country list and view to new UI (#2667)

* Merge OnboardingTracingFragment with country list (#2665)

* UI adjustments (#2665)

* Fix linting issues

* Implement Delta Onboarding logic (#2665)

* Adjust interoperability screens to new UI (#2730, #2733)

* Added navigation from country selection to tracing fragment

* Fix merge issues with interoperability branch

* Fix merge issues with interoperability branch

* Fix merge changes with 1.5.x branch

* Remove unused Formatter

* Remove import of unused Formatter

* Remove import of unused Formatter

* Fix linting issue

* Adjust UI to mock changes (#2730)

* Adjust fragment binding to new solution and code cleanup

* Adjust layout ids to guidelines. Comment strings.xml

* Moved back navigation event to ViewModel

* Move to DI and ViewModel navigation

* Improve accessibility

* Improve accessibility

* Adjusted UI to updated mockups. Clean-Up of InteroperabilityRepository and LocalData

* Refactoring and ViewModel use.

* Make detekt happy.

* Fix PR comments, typos, inline getString.

* Fix refactoring typo

Co-authored-by: default avatarAlexandru.Paulescu <alexandru.paulescu@sap.com>
Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>
Co-authored-by: default avatarMatthias Urhahn <darken@darken.eu>
      Unverified
      f85da39e
  15. Sep 18, 2020
    • Matthias Urhahn's avatar
      Revert "Interoperability to 1.5.X (#1173)" · c419ae66
      Matthias Urhahn authored 
      This reverts commit 6054bf57.
      c419ae66
    • Jakob Möller's avatar
      Interoperability to 1.5.X (#1173) · 6054bf57
      Jakob Möller authored 
      
* Added first set of country flags

Signed-off-by: default avatarKolya Opahle <k.opahle@sap.com>

* Added first implementation of Submission Country Selection Screen. (Currently not part of nav graph).
Moved stuff inside of submission package into subpackages

Signed-off-by: default avatarKolya Opahle <k.opahle@sap.com>

* Added missing changes to nav_graph file

* Test Menu options for Country selection and Measurement (EXPOSUREAPP-2229) (#1086)

* Implement country filter (#2229)

* Implement measure for Risk calculation and Key Retrieval (#2229)

* Some code cleanup for measureRiskLevelAndKeyRetrieval

* Some code cleanup (#2229)

* Implement usage of AppConfig usage for country codes (#2229)

* change CURRENT_COUNTRY val to var

* Suppress "LongMethod" warning (#2229)

* Adjust unit tests to respect new country filter

* Align with backend for app config country property name

* Display total file size of keys in results (#2229)

* Fix linting issue

* Update strings.xml files

* Do refactoring and some code clean up

* Move RiskLevel and Key retrieval measurement in own class

* Move code in logical classes. Remove translation in test fragment

* Fix linting and Unit tests

* Remove 3hour boolean check from debug class.

* Refactor CountryWrapper and missing dates check.

* Fix linting and Unit tests

* Add Unit test for getMissingDates

* Code cleanup

* Hide keyboard on action

* Extend statistics for api submission

* Set callback to null after invoked

Co-authored-by: default avatarMert Safter <mert.safter@sap.com>
Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>

* Overhaul of DiagnosisKey related Download and Caching Mechanisms (EXPOSUREAPP-2469) (#1136)

* Rework of keyfile download and caching.
* Supports interop
* More modular for better testing and build flavour based behavior adjustments
* More resilient handling of failed downloads
* Preperations for future hourly download and serverside checksums

TODO: Finish unit tests, keycache migration and cache health check

* First batch of unit tests and some fixes for incorrect behavior that the tests surfaced.

* Added unit tests for the KeyCacheRepository

TODO: Tests for downloader and migration.

* Implemented POC for migration old key files.

* Fixed legacy file migration and cleanup, improved logging.

* Added unit tests for legacy key file migration.

* Add fallback for different file hashes in the header.

* Yes kLint, we know it's a long method,
but for this it's better to read it in one block vs jumping to extra methods.

* More linting issues, adjusting project code style prevent a few of these in the future.

* Added missing unit tests for `KeyFileDownloader` and fixed faulty behavior that was noticed during testing.

* CRUD (instrumentation) test for `KeyCacheDatabase`

* Remove unused `FileStorageHelper` and related constants+tests.

* Fix last3Hours unit test in deviceRelease mode, we need to explicitly enable debug for these tests.

* Until we have more information about the hashsum's format in the header, default to `ETag

* Split app config server API from diagnosis key download API,
and reintroduce caching for the app config download.

* Add test to check that the cache is used on flaky connections.

* Code changes based on PR comment, part #1.

* Code fluff, formatting.

* Handle download errors correctly.

* Refactoring:
* Remove unnecessary `currentDate` we always start with the newest date from the servers index.
* Make a specialised class for header validation

* Let legacy cache migration abort early, depending on whether the key dir exists.

* If we can't create the base directory for the key repo, throw an exception.

* Delete cache entry if a download fails.

* Fixed test regression due to refactoring.

* Consolidate staleness check into `getStale`

* Consolidate clean up for failed downloads into the download method.
Added tests to check that we delete the keycache entry if the download fails (which we didn't for hours :O!)

* Because the hour-mode uses caching too, we add an explicit button to the test menu that clears the cache.

* Add comment with reference to ticket regarding follow up on the other headers.

* Move expected storage size per country into a named constant.

Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>

* Implementation of tests for the interoperability countries selection screen (EXPOSUREAPP-2439) (#1140)

* Added initial set of viewModel tests

Signed-off-by: default avatarKolya Opahle <k.opahle@sap.com>

* Fail tests on unexpected null.

Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>

Co-authored-by: default avatarKolya Opahle <k.opahle@sap.com>
Co-authored-by: default avatarapopovsap <66370584+apopovsap@users.noreply.github.com>
Co-authored-by: default avatarMert Safter <69803294+MertSafter@users.noreply.github.com>
Co-authored-by: default avatarMert Safter <mert.safter@sap.com>
Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>
Co-authored-by: default avatarMatthias Urhahn <darken@darken.eu>
      Unverified
      6054bf57
  17. Sep 17, 2020
    • Matthias Urhahn's avatar
      1.3.1 into 1.4.0 (#1177) · c6014d23
      Matthias Urhahn authored 
      
* New Scan Confirmation Texts Change (EXPOSUREAPP-2427) (#1097)

Co-authored-by: default avatarharambasicluka <64483219+harambasicluka@users.noreply.github.com>
Co-authored-by: default avatarJakob Möller <jakob.moeller@sap.com>

* New Strings for Risikobegegnung mit niedrigem Risiko (EXPOSUREAPP-2462) (#1106)

* + new strings

* let the app not crash on other languages than DE

* values for lint and tests

* made bad test a comment

* removed unnecessary strings

* more string fixes

Co-authored-by: default avatarJakob Möller <jakob.moeller@sap.com>
Co-authored-by: default avatarLuka Harambasic <luka.harambasic@sap.com>

* Remove Cache Clearing to reduce CDN load on failing devices (EXPOSUREAPP-2405) (#1108)

* Remove Cache Clearing to reduce CDN load on failing devices. This ideally needs to be accompanied by a way to clear the cache manually and a way to identify more root causes of Transaction Failures.

Signed-off-by: default avatard067928 <jakob.moeller@sap.com>

* Remove Files that failed for Key Retrieval

Only Remove Files from Cache that failed to download, instead of every file. This is accompanied ideally by no rollback in the Key Retrieval. We only delete the cache ref, the file will not be deleted as it is considered not present

Signed-off-by: default avatard067928 <jakob.moeller@sap.com>

* Introduce dedicated QuotaCalculator for Unit Testing

Signed-off-by: default avatard067928 <jakob.moeller@sap.com>

* Refactor QuotaCalculator for LocalData Property Access and Write Tests

Signed-off-by: default avatard067928 <jakob.moeller@sap.com>

* Use Instant on the Device Read since this is not timezone specific

Signed-off-by: default avatard067928 <jakob.moeller@sap.com>

* Add specific state for the quota calculation and dedicated rollback

Signed-off-by: default avatard067928 <jakob.moeller@sap.com>

* PR Comments

Signed-off-by: default avatard067928 <jakob.moeller@sap.com>

* Feature: Update low risk string (EXPOSUREAPP-1971) (#1125)

* Improve Explanation for "Risikobegegnung mit niedrigem Risiko" (EXPOSUREAPP-1971) (#1112)

* Adapt QuotaCalculatorTest to old JUnit4 API

Signed-off-by: default avatard067928 <jakob.moeller@sap.com>

* [INTERNAL] Translation delivery: commit by LX Lab (#1132)

Change-Id: Ib76a9ea2b03163a05dd8b6acf2179262f9bcf5bf

* Removed ar & ru and updated defaults (#1133)

* Throw Exception in case we have a failed entry to ensure Abortion of the Transaction (EXPOSUREAPP-2405) (#1134)

* Throw Exception in case we have a failed entry to ensure Abortion of the Transaction.

Signed-off-by: default avatard067928 <jakob.moeller@sap.com>

* Adjust test to not expect call to clear cache files

Signed-off-by: default avatard067928 <jakob.moeller@sap.com>

* version bump to 1.3.1

* Reverted replaced wording (EXPOSUREAPP-2638) (#1153)

* Fix: No exposure with low risk so far

* Fixed klint issues (#1144)

* restored reverted replaced wording for lint

* https://github.com/corona-warn-app/cwa-app-android/pull/1153#discussion_r487801724



* fixed term

* Align TestFragment Crash behavior with background transaction crash behavior.

* Add logging mechanism to debug hotfix issue.

* Lint Resolvement, Nav Graph Issue clean, Enable Log for deviceForTesters, Correct Quota Tests due to now lacking exception

Signed-off-by: default avatard067928 <jakob.moeller@sap.com>

Co-authored-by: default avatarPhilipp Woessner <64482866+pwoessner@users.noreply.github.com>
Co-authored-by: default avatarJakob Möller <jakob.moeller@sap.com>
Co-authored-by: default avatarRituraj Sambherao <54317407+ritsam@users.noreply.github.com>
Co-authored-by: default avatarharambasicluka <64483219+harambasicluka@users.noreply.github.com>
Co-authored-by: default avatarchris-cwa <69595386+chris-cwa@users.noreply.github.com>
Co-authored-by: default avatarLuka Harambasic <luka.harambasic@sap.com>
Co-authored-by: default avatarSAP LX Lab Service Account <tmsatsls+github.com_service-tip-git@sap.com>
Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>
      Unverified
      c6014d23
    • Oliver Zimmerman's avatar
      Provide onset of symptoms before upload (EXPOSUREAPP-1605) (#1170) · 8c7e0501
      Oliver Zimmerman authored 
      
* initial commit of new fragment for symptom screen

* Added relevant strings for symptom screen. Started editing xml of initial symptom screen

* Addded 3 selection options within symptom screen

* button id name change to something more relevant

* ID changes to be something more relevant to symptom scenerio.

* Implemented symptom initial screen logic. Temporary nav for testing.

* CircleCI formatting

* Adapted interoperability test provided by apopov

* Added accessibilty announcement on resume, fixed navigation for main page

* circleCI indentation fix

* removed ar & ru and updated default strings

* Adaption to ViewModel logic. Not yet complete

Adaption to ViewModel logic, attempting to align with implementation done with some interoporibility tasks: reusable layout files, etc.

* More ViewModel transformation additions

* revert nav from test. Circle CI formatting changes

* Update SubmissionSymptomIntroductionFragment.kt

* Removed old fragment based test

* Will implement navigation during marry session.

* Update SubmissionViewModel.kt

* Calendar button selection screen + required strings

* Custom calendar view

* Accessibility improved

* introduced data types for symptoms

* represent date by long in millis

* new TransmissionRiskVector

* Constants and formatting

* Naming changes requested

* Better event naming

* Update fragment_submission_symptom_intro.xml

* Finishing calendar implementation - still need to implement calendar widget

Surrounding calendar submission UI - minus calednar widget
Necessary strings

* Merged introduction and calendar screen.

Created calendar fragment screen,
Finished calendar XML view
Added required entries for choices in SubmissionViewModel
Adjusted Formatters for button selection.
Changed nav graph.

* + todo

* CircleCI code style changes

* EXPERT STUFF

* Latest push for marry session

* replaced transaction risk vector

* update textcolor on symptom indication change

* update buttons by code

* code formatting

* Added logic for Negative and No Information buttons and adjusted xml view to be more aligned with design

Added logic for Negative and No Information buttons and adjusted xml view to be more aligned with design

* disable next button when state is null.

* + readability

* Calendar screen logic adapted for button selection

* extracted domain logic from prototype and from transaction

* - not used events

* joint improvements

* removed unused events

* Calendar unsetSelection added

* detekt rules changed and formatting

* - calendar view refactor: CalendarCalculator singleton introduced for batter testing capacity
- unit tests added

* detekt issues

* Colors and styles cleared

* fixed strings

* maintained unit tests

* adopted changes from main nav graph to device for testers nav graph

* reverted comment

* made start of symptoms nullable

* tests

* Adjusted navigation, fixed dark theme

* Update Project.xml

* use of postValue() in SubmissionViewModel.kt

* Added direction in tester nav graph

* improvements required by review

* moving companion

* moving companion

* moving companion

* fixed issues from partner review

* fixed issues from partner review

* fixed issues from partner review

* fixed issues from partner review

* fixed issues from partner review

* using utc

* edge case tests

* made inner class

* Refactored Symptoms Class Name (+data class)

* Change SubmissionViewModel scope to ensure that the same viewmodel is used to store submission data.

* extracted null check + log

Co-authored-by: default avatarLuka Harambasic <luka.harambasic@sap.com>
Co-authored-by: default avatarchris-cwa <chris.cwa.sap@gmail.com>
Co-authored-by: default avatarAlexander Alferov <a.alferov@sap.com>
Co-authored-by: default avatarharambasicluka <64483219+harambasicluka@users.noreply.github.com>
Co-authored-by: default avatarMatthias Urhahn <darken@darken.eu>
Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>
      Unverified
      8c7e0501
    • Matthias Urhahn's avatar
      File Logger Introduction for Test Builds (EXPOSUREAPP-2640) (#1176) · 90ad5d36
      Matthias Urhahn authored 
      
* Align TestFragment Crash behavior with background transaction crash behavior.

* Add logging mechanism to debug hotfix issue.

* Lint Resolvement, Nav Graph Issue clean, Enable Log for deviceForTesters, Correct Quota Tests due to now lacking exception

Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>
Co-authored-by: default avatard067928 <jakob.moeller@sap.com>
      View commits for tag 1.3.1-SNAPSHOT-RC3 1.3.1-SNAPSHOT-RC3 Unverified
      90ad5d36
  19. Sep 11, 2020
  21. Sep 01, 2020
  23. Aug 27, 2020
    • Fabian-K's avatar
      [EXPOSUREAPP-2314] Include test result retrieval in playbook for initial registration (#1073) · 3db92539
      Fabian-K authored 
      
For plausible deniability, the test result retrieval after the initial registration (via QR or TeleTAN) needs to be part of the same playbook and not two playbooks executed sequentially. For this, this commit:
- updates the initial registration playbook to fetch the test result instead of a dummy request and returns the registration token as well as the test result
- adds an argument "skipInitialTestResultRefresh" to the SubmissionTestResultFragment to optionally skip the initial test result refresh
- includes the argument "skipInitialTestResultRefresh" when navigating from the QR Code scan or the TeleTAN input screen to the SubmissionTestResultFragment
- adds "updateTestResult" to the SubmissionRepository to be able to set the test result without having to refresh it every time from the server
- updates the SubmissionService to set the test result coming from the initial registration playbook

Co-authored-by: default avatarJakob Möller <jakob.moeller@sap.com>
      Unverified
      3db92539
  25. Jul 02, 2020
  27. Jun 11, 2020
  29. Jun 09, 2020
  31. Jun 08, 2020
    • Fabian-K's avatar
      Submission Design Review Adjustments (#277) · 7580932e
      Fabian-K authored 
      * Submission Status Cards
- fix interaction behavior (expand clickable target)
- unify inclusion into fragment_main.xml
- fix alignment of icons including hands
- fix spacing between text and icon
- simplify layout (remove unnecessary ConstraintLayout)
- remove unused string
- fixed unregistered text style

* Submission Styling
- increase spacing before "Info zum Ablauf"
- replace step icons used in submission contact
- fix wrong illustration for negative test result
- added rounded corners to test result card
- fixed spacing between text and illustration
- removed unused icon ic_icon_drilldowncard_dark.xml
- fixed button padding on test result screen

Main Fragment
- simplified using merge_guidelines_side

* Submission Styling
- replace illustration for positive tests on homescreen (different background)
- add pressed state to submission dispatcher cards
- fix missing spacing adjustment between text and icons
      Unverified
      7580932e
  33. Jun 06, 2020
    • Fabian-K's avatar
      Text Styles and others (#223) · e6d0b4b5
      Fabian-K authored 
      * - unused SubmissionSuccessDialogFragment.kt removed

* - remove merge_guidelines_common.xml
- fragment_submission_test_result.xml scrolling behavior

* - submission flow text styles replaced
- submission positive result card updated

* - submission status cards updated

* - remove old text styles
- lint error fixed
      Unverified
      e6d0b4b5
  35. Jun 05, 2020
    • Kolya Opahle's avatar
      Removing the registration fragment (#184) · 1853cac1
      Kolya Opahle authored 
      
* Added the TestAlreadyPairedException to the web request builder

* Added specific exceptions to all submission web requests

* Moved setting activity of DialogHelper to show call

* Re added the requestIDS to all listeners for later use

* Added Exception live data to view model

* Added error dialogs to RegisterDeviceFragment screen

* Added null check to networkResponse in VolleyError

* Added error dialogs to SubmissionTestResultFragment screen

* Fixed wrong view model call

* Added error dialogs to SubmissionResultPositiveOtherWarningFragment

* Added missing imports

* Revert "Added specific exceptions to all submission web requests"

This reverts commit 88d9027e24dd8b8c0baae7478c15cb23af403a0f.

* Revert "Added the TestAlreadyPairedException to the web request builder"

This reverts commit a4fb8272d89dd1e508a50002827fbc0dc7d86919.

* added specific error handing to services

* Switched error handlers to retrofit

* Extracted status code numbers to constants

* Added final strings for http error handling

* Removed RegisterDeviceFragment from app and added a Event helper

* Lint fixes

* removed error report for networking exceptions

* Added event wrapper to scan status to allow for rescanning of failed qrs

* linting

* Switched most view model LiveData to Event

Co-authored-by: default avatarmarcmuschko <marc.muschko@sap.com>
      Unverified
      1853cac1
    • Kolya Opahle's avatar
      Error handling for network requests in Submission Flow (#141) · bdac0f1b
      Kolya Opahle authored 
      * Added the TestAlreadyPairedException to the web request builder

* Added specific exceptions to all submission web requests

* Moved setting activity of DialogHelper to show call

* Re added the requestIDS to all listeners for later use

* Added Exception live data to view model

* Added error dialogs to RegisterDeviceFragment screen

* Added null check to networkResponse in VolleyError

* Added error dialogs to SubmissionTestResultFragment screen

* Fixed wrong view model call

* Added error dialogs to SubmissionResultPositiveOtherWarningFragment

* Added missing imports

* Revert "Added specific exceptions to all submission web requests"

This reverts commit 88d9027e24dd8b8c0baae7478c15cb23af403a0f.

* Revert "Added the TestAlreadyPairedException to the web request builder"

This reverts commit a4fb8272d89dd1e508a50002827fbc0dc7d86919.

* added specific error handing to services

* Switched error handlers to retrofit

* Extracted status code numbers to constants

* Added final strings for http error handling
      Unverified
      bdac0f1b
  37. Jun 04, 2020
    • Philipp Woessner's avatar
      Implement risk level calculation changes (#136) · 26c4cb50
      Philipp Woessner authored 
      * changed local config that a high match can be generated via QR code, integrated it with the UI

* added the minRiskScore parameter to the ExposureConfiguration

* moved the persistence of the exposure summary in a dedicated worker to ensure execution

* added new backend app config and custom risk score calculation

* fixed static code checks and refactoring

* deleted possibility to customise app config in the tests

* added test fragment for risk level calculation

* static code check fixes

* refactored risk level calculation and added tests

* added exception if calculated risk score is above the max of the high risk score class
      Unverified
      26c4cb50
  39. Jun 03, 2020
  41. Jun 02, 2020
  43. May 30, 2020