- Sep 30, 2020
-
-
Matthias Urhahn authored
* Fix various code smells and some refactoring to make SonarCloud happy. * Fix refactoring regression. * Additional log output to determine how long certain steps take on cold-start.
-
Matthias Urhahn authored
* Update protobuf format * Addition of contentToFederation and visistedCountries/supportedCountries. TODO: Unit tests, pull supportedCountries from AppConfig (waiting for #1213) * Fix invalid package being assigned. This would break daggers annotation processing as the class could not be resolved. * Improved existing and implemented new tests. * Fixed test regression due to refactoring. * Integrate pulling the supportedCountries data from the AppConfig for the submission transaction. (Previously wasn't implemented yet, now it's merged) * Address merge conflicts, and a little refactoring, and a bit more tests. * Revert file change to Project.xml * AppConfigProvider should insert "DE" as fallback if the supportedCountry list is empty/not supplied. * Don't insert the fallback country at application config provider level. The UI requires the list to be empty, if it is empty in the config. I've moved the fallback country insertion into the transaction. * Make detekt happy. * Make klint happy.
-
Mert Safter authored
-
- Sep 29, 2020
-
-
Matthias Urhahn authored
* Move AppConfig related code into it's own package. * Use "files" instead of "cache" for storing our AppConfigApiTest. * Add "files" to "cache" migration. * Refactor CDN related code into an independent "environment module". TODO: UnitTests, Fallback behavior even if cached AppConfig is stale. * Further structure refactoring and unit test for app config cache migration. * Added config fallback behavior for all cases + additional tests. * Improve code readability. * First POC for multi-environment support. * logic for ACME test Countries toggle button in Dev menu * ACME Test Countries dev menu * Additional clean up and refactoring on build constants. * Cleaned up the test fragment a bit. * Fixed detekt issue * Fix flaky test that depends on build variant. * Let the test fragment show us the actual environment we toggled to. * Changes upon review * Address PR comments. Co-authored-by:
Rituraj Sambherao <git.rituraj.sambherao@gmail.com>
-
BMItter authored
* test enhancement for interop and countrylist, added liveDataTestExtension * better test naming, removed one assert Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
Matthias Urhahn authored
Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
Kolya Opahle authored
Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
harambasicluka authored
* update text * added hyphen
-
Alex Paulescu authored
* Added country list to submission of keys screen * Ktlint changes * Added missing s * Added text changes * Removed file from wrong location * Reverted back to old way of instantiating countryList in SubmissionViewModel * Removed hardcoded spacing * Changed country list text style from bold to paragraph size * Added dimen everywhere and added back en string Co-authored-by:
Alexandru.Paulescu <alexandru.paulescu@sap.com>
-
- Sep 28, 2020
-
-
AlexanderAlferov authored
* New note on interoperability * Set new note only for onboarding delta interoperability
-
BMItter authored
Interoperability: List of Countries can not be loaded for 1.5.x in new onboarding / interop (EXPOSUREAPP-2744) (#1232) * interop nofetch riskdetails, corresponding layout and vector * updated res to new no country spec * nofetch fetch layouts * Create include_interoperability_old.xml * removed old stuff * fixed Fixed include_interop_participating_countries_fetch for 1.5.x * adjusted logic from old base to fit 1.5.x, Converted countryList to LiveData * showing fetch or no fetch view in include_interoperability.xml, use github name as author * cleanup & refactor, fixed layout switch issue, wip * ids cleanup * system settings delegation according to design spec * improved countrylist handling for interopConfig Connectivity Settings * updated string translation tags * satisfy lint * satisfy CircleCi * fixed wrong layout visibility * delta test disabled, referenced ids adjusted * FormatHelper as requested * fix capital letter
-
Oliver Zimmerman authored
* Made hotline number clickable - delcared textview clickable within xml layout - reused dial logic from button and used for now clickable text * removed synthetic import - now using binding instead. Co-authored-by:
Jakob Möller <jakob.moeller@sap.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
Matthias Urhahn authored
* Move AppConfig related code into it's own package. * Use "files" instead of "cache" for storing our AppConfigApiTest. * Add "files" to "cache" migration. * Refactor CDN related code into an independent "environment module". TODO: UnitTests, Fallback behavior even if cached AppConfig is stale. * Further structure refactoring and unit test for app config cache migration. * Added config fallback behavior for all cases + additional tests. * Improve code readability. * Remove test TODO
-
Oliver Zimmerman authored
Changed accessibility importance of switch to avoid overriding status announcement Co-authored-by:
Jakob Möller <jakob.moeller@sap.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
- Sep 25, 2020
-
-
Mert Safter authored
* Make transaction timeout settable per transaction. Increase Risk Level Calc transaction * Make timeout more readable
-
- Sep 24, 2020
-
-
Matthias Urhahn authored
-
chris-cwa authored
* text changes for existing user consent * fixed typo Co-authored-by:
Jakob Möller <jakob.moeller@sap.com>
-
- Sep 23, 2020
-
-
Rituraj Sambherao authored
Co-authored-by:
Jakob Möller <jakob.moeller@sap.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Matthias Urhahn authored
1.4.x into 1.5.x
-
Matthias Urhahn authored
# Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/storage/LocalData.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/di/ApplicationComponent.kt # Corona-Warn-App/src/main/res/navigation/nav_graph.xml # Corona-Warn-App/src/main/res/values/strings.xml
-
Mert Safter authored
* Import flag assets. Create init CountrySelectionList and Fragment * Implement missing components. Create ViewModel and Repository for Interop * fix wrong property usage * Implement storage of selected countries * Implement warn dialog * Added navigation from country selection to tracing fragment * Fixed lint errors * Fix typo and build error * Move navigation out of onResume * Implement Warning dialog and do some code cleanup * Begin of onboarding for Interoperability. Fix linting issues * Implement onboarding for Interoperability (#1976) * Implement skip path of interop screen in onboarding (#1976) * Implement navigation logic for onBoarding (#1976) * Fix linting issues * Adjust country list and view to new UI (#2667) * Merge OnboardingTracingFragment with country list (#2665) * UI adjustments (#2665) * Fix linting issues * Implement Delta Onboarding logic (#2665) * Adjust interoperability screens to new UI (#2730, #2733) * Added navigation from country selection to tracing fragment * Fix merge issues with interoperability branch * Fix merge issues with interoperability branch * Fix merge changes with 1.5.x branch * Remove unused Formatter * Remove import of unused Formatter * Remove import of unused Formatter * Fix linting issue * Adjust UI to mock changes (#2730) * Adjust fragment binding to new solution and code cleanup * Adjust layout ids to guidelines. Comment strings.xml * Moved back navigation event to ViewModel * Move to DI and ViewModel navigation * Improve accessibility * Improve accessibility * Adjusted UI to updated mockups. Clean-Up of InteroperabilityRepository and LocalData * Refactoring and ViewModel use. * Make detekt happy. * Fix PR comments, typos, inline getString. * Fix refactoring typo Co-authored-by:
Alexandru.Paulescu <alexandru.paulescu@sap.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> Co-authored-by:
Matthias Urhahn <darken@darken.eu>
-
chris-cwa authored
* texts for interop user consent * default values Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
harambasicluka authored
-
SAP LX Lab Service Account authored
* [INTERNAL] Translation delivery: commit by LX Lab Change-Id: I819e9a5a620221a7267bb9737396fbb966852bb0 * [INTERNAL] Translation delivery: commit by LX Lab Change-Id: I932bc1aa24d4ebe65681cf78c1f109266e695980 Co-authored-by:
harambasicluka <64483219+harambasicluka@users.noreply.github.com>
-
Matthias Urhahn authored
# Conflicts: # Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/TestRiskLevelCalculationFragment.kt # Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/api/ui/TestForAPIFragment.kt # Corona-Warn-App/src/deviceForTesters/res/layout/fragment_test_for_a_p_i.xml # Corona-Warn-App/src/deviceForTesters/res/navigation/nav_graph.xml # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/transaction/RetrieveDiagnosisKeysTransaction.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/di/ApplicationComponent.kt # Corona-Warn-App/src/test/java/de/rki/coronawarnapp/transaction/RetrieveDiagnosisKeysTransactionTest.kt
-
harambasicluka authored
* update privacy de & en * added html lists * updated user consent * fixed comment * update tr privacy text
-
Katharina Seiz authored
-
janetback authored
-
- Sep 22, 2020
-
-
harambasicluka authored
* update privacy de & en * added html lists * updated user consent * fixed comment
-
Matthias Urhahn authored
* Improve error message and add logic for future display of formatted error messages. * Address PR review comments.
-
Matthias Urhahn authored
* QuotaCalculator V2 * Add extra logging for transaction and worker exceptions. (#1195) (EXPOSUREAPP-2640) * Remove QuotaCalculation due to unexpected sideeffects. (#1196) (EXPOUSREAPP-2640) * Fix klint/sourceCheck. * Add test for first initialization. * Add visibility modifier * Simplify quota reset time calculation and extend tests for edge cases. * Reduce impact of quota check to a warning for 1.4. Add tests for silent quota check and configuration fallback behavior. * Addressed PR comments.
-
janetback authored
-
- Sep 18, 2020
-
-
Matthias Urhahn authored
We need to hook into `viewLifecycleOwner` not `lifeCycleOwner` otherwise the DataBinding is not correctly recreated whe fragments are reattached. (#1182) Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Matthias Urhahn authored
Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Matthias Urhahn authored
Refactor MD5 extraction to be part of `DiagnosisKeyServer`'s responsibility. Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com>
-
Matthias Urhahn authored
Fix interop squash commit
-
Matthias Urhahn authored
-
Matthias Urhahn authored
This reverts commit 6054bf57.
-
Jakob Möller authored
* Added first set of country flags Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Added first implementation of Submission Country Selection Screen. (Currently not part of nav graph). Moved stuff inside of submission package into subpackages Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Added missing changes to nav_graph file * Test Menu options for Country selection and Measurement (EXPOSUREAPP-2229) (#1086) * Implement country filter (#2229) * Implement measure for Risk calculation and Key Retrieval (#2229) * Some code cleanup for measureRiskLevelAndKeyRetrieval * Some code cleanup (#2229) * Implement usage of AppConfig usage for country codes (#2229) * change CURRENT_COUNTRY val to var * Suppress "LongMethod" warning (#2229) * Adjust unit tests to respect new country filter * Align with backend for app config country property name * Display total file size of keys in results (#2229) * Fix linting issue * Update strings.xml files * Do refactoring and some code clean up * Move RiskLevel and Key retrieval measurement in own class * Move code in logical classes. Remove translation in test fragment * Fix linting and Unit tests * Remove 3hour boolean check from debug class. * Refactor CountryWrapper and missing dates check. * Fix linting and Unit tests * Add Unit test for getMissingDates * Code cleanup * Hide keyboard on action * Extend statistics for api submission * Set callback to null after invoked Co-authored-by:
Mert Safter <mert.safter@sap.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> * Overhaul of DiagnosisKey related Download and Caching Mechanisms (EXPOSUREAPP-2469) (#1136) * Rework of keyfile download and caching. * Supports interop * More modular for better testing and build flavour based behavior adjustments * More resilient handling of failed downloads * Preperations for future hourly download and serverside checksums TODO: Finish unit tests, keycache migration and cache health check * First batch of unit tests and some fixes for incorrect behavior that the tests surfaced. * Added unit tests for the KeyCacheRepository TODO: Tests for downloader and migration. * Implemented POC for migration old key files. * Fixed legacy file migration and cleanup, improved logging. * Added unit tests for legacy key file migration. * Add fallback for different file hashes in the header. * Yes kLint, we know it's a long method, but for this it's better to read it in one block vs jumping to extra methods. * More linting issues, adjusting project code style prevent a few of these in the future. * Added missing unit tests for `KeyFileDownloader` and fixed faulty behavior that was noticed during testing. * CRUD (instrumentation) test for `KeyCacheDatabase` * Remove unused `FileStorageHelper` and related constants+tests. * Fix last3Hours unit test in deviceRelease mode, we need to explicitly enable debug for these tests. * Until we have more information about the hashsum's format in the header, default to `ETag * Split app config server API from diagnosis key download API, and reintroduce caching for the app config download. * Add test to check that the cache is used on flaky connections. * Code changes based on PR comment, part #1. * Code fluff, formatting. * Handle download errors correctly. * Refactoring: * Remove unnecessary `currentDate` we always start with the newest date from the servers index. * Make a specialised class for header validation * Let legacy cache migration abort early, depending on whether the key dir exists. * If we can't create the base directory for the key repo, throw an exception. * Delete cache entry if a download fails. * Fixed test regression due to refactoring. * Consolidate staleness check into `getStale` * Consolidate clean up for failed downloads into the download method. Added tests to check that we delete the keycache entry if the download fails (which we didn't for hours :O!) * Because the hour-mode uses caching too, we add an explicit button to the test menu that clears the cache. * Add comment with reference to ticket regarding follow up on the other headers. * Move expected storage size per country into a named constant. Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> * Implementation of tests for the interoperability countries selection screen (EXPOSUREAPP-2439) (#1140) * Added initial set of viewModel tests Signed-off-by:
Kolya Opahle <k.opahle@sap.com> * Fail tests on unexpected null. Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> Co-authored-by:
Kolya Opahle <k.opahle@sap.com> Co-authored-by:
apopovsap <66370584+apopovsap@users.noreply.github.com> Co-authored-by:
Mert Safter <69803294+MertSafter@users.noreply.github.com> Co-authored-by:
Mert Safter <mert.safter@sap.com> Co-authored-by:
Matthias Urhahn <matthias.urhahn@sap.com> Co-authored-by:
Matthias Urhahn <darken@darken.eu>
-
Matthias Urhahn authored
# Conflicts: # .idea/codeStyles/Project.xml # Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/TestRiskLevelCalculationFragment.kt # Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/api/ui/TestForAPIFragment.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/submission/fragment/SubmissionQRCodeScanFragment.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/submission/fragment/SubmissionResultPositiveOtherWarningFragment.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/submission/fragment/SubmissionTanFragment.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/di/ApplicationComponent.kt
-