Skip to content
Snippets Groups Projects
  1. Oct 27, 2020
  2. Oct 26, 2020
  3. Oct 23, 2020
  4. Oct 22, 2020
  5. Oct 19, 2020
    • Matthias Urhahn's avatar
      Refactor missused ViewModels, support automated UI tests and screenshots (EXPOSUREAPP-2946) (#1415) · cec56fdb
      Matthias Urhahn authored
      
      * Introduced `TracingCardState` and `TracingDetailsState`.
      Removed all direct viewmodel/livedata access from all nested layouts for `TracingViewModel`.
      Removed `FormatterRiskHelper`.
      Introduced logic to reactively update the UI state if bluetooth, location or tracing state changes.
      
      TODO:
      * Finish tests in TracingCardStateTest.kt and TracingDetailsStateTest.kt
      * Finish TracingDetailsViewModel.kt and TracingCardViewModel.kt
      * Remove obsolete dependencies on TracingViewModel.kt and singletons RiskLevelRepository.kt, TracingRepository.kt
      
      * Breakthrough, cards update again.
      
      * Further cleanup of TracingViewModel.kt, TracingRepository.kt
      Still not quite there yet, too many calls going into every direction, back and forth, instead of just top->down, but we are getting there.
      We want data flow from business logic code to the UI, keep the UI KISS.
      
      * Update TracingCardState tests to account for changes
      
      * More refactoring, TracingViewModel.kt is now finally gone.
      
      * Fix risk details card, we reuse the cardviewmodel but need to overwrite the `showDetails` flag depending from where it's used.
      
      * Refactored several properties (notification related) out of SettingsViewModel/Repository
      
      * Fix injection
      
      * Refactoring submission related databinding code on the home fragment
      
      * Make TracingRepository.kt injectable and change viewmodel scoping for refresh calls to app scope.
      
      * Remove additional formatter calls from submission cards on home screen.
      
      * Refactored additional SubmissionViewModel logic into SubmissionRepository on the Homescreen.
      First UI Test is now passing.
      
      Simplified ViewModel instantiation related code.
      Prepared HomeFragment for smoother UI state changes, less reloading.
      
      * Improved home,tracing-details and tracing-settings loading behavior, less flickering.
      Fixed LiveData value assignment on background-thread.
      
      * New reactive provider for Bluetooth and Location status.
      Cleaned up ConnectivityHelper.kt partially.
      
      * Implement remaining tests, batch 1.
      
      * Implement remaining tests, batch 2.
      
      * Fix lint issues.
      
      * Removed a few codesmells and code duplication.
      Introduced Flow.shareLatest(...)
      
      * Removed unused parameters.
      
      * LINT fixes.
      
      * Fix unit test failing due to missing mocks.
      
      * Address PR comments.
      
      * Improve UI loading states, remove flickering.
      
      * Remove log spam due to polling values, add extra abort condition that checks for cancellation.
      
      Co-authored-by: default avatarralfgehrer <mail@ralfgehrer.com>
      cec56fdb
  6. Oct 15, 2020
  7. Oct 14, 2020
  8. Oct 12, 2020
  9. Oct 09, 2020
  10. Oct 08, 2020
  11. Oct 07, 2020
  12. Oct 06, 2020
  13. Oct 05, 2020
  14. Oct 02, 2020
    • Matthias Urhahn's avatar
      Reduce code duplication (EXPOSUREAPP-2844) (#1286) · d64a5825
      Matthias Urhahn authored
      * Remove code duplication between different flavors.
      Remove extra MainFragment and NavGraph.
      Introduce TestMenu indirection
      Add logic for splitting test code up into extra fragments.
      
      * Style list items a bit :)
      
      * fix lints
      
      * Detekt *hug*
      
      * We can only show the menu entry if we are actually on the right flavor,
      otherwise, in deviceDebug, we would not have access to the right resources.
      
      * Address PR comments
      
      * Fix wrong XML namespace.
      d64a5825
    • chris-cwa's avatar
      Legal Texts (EXPOSUREAPP-2954 , EXPOSUREAPP-2951, EXPOSUREAPP-2942,... · eb382edf
      chris-cwa authored
      Legal Texts (EXPOSUREAPP-2954 , EXPOSUREAPP-2951, EXPOSUREAPP-2942, EXPOSUREAPP-2938, EXPOSUREAPP-2931, EXPOSUREAPP-2925, EXPOSUREAPP-2924, EXPOSUREAPP-2923, EXPOSUREAPP-2922, EXPOSUREAPP-2920, EXPOSUREAPP-2919, EXPOSUREAPP-2918, EXPOSUREAPP-2917) (#1270)
      
      * text body from EXPOSURE_APP 2740
      
      * line breaks
      
      * - duplicate values
      
      * Interoperability: Make Changes to User Consent Text (Initial Onboarding) (EXPOSUREAPP-2938) (#1276)
      
      * 2938 updated legal strings in defaults, de & tr
      
      * added translatable false
      
      * updated german strings (#1278)
      
      * nex text for EXPOSUREAPP-2942
      
      * Legal Textchange: Exposure Logging Screen (EXPOSUREAPP-2923) (#1280)
      
      * Legal Textchange: Home Screen - FAQ Section (EXPOSUREAPP-2922) (#1281)
      
      * Legal Textchange: Initial Onboarding (EXPOSUREAPP-2920) (#1282)
      
      * Legal Textchange: Test Result Screen (EXPOSUREAPP-2918) (#1283)
      
      * Legal Textchange: Info Screen (EXPOSUREAPP-2917) (#1284)
      
      * update string (#1288)
      
      * kEA-2942
      
      * Legal Textchange: New Eula (Nutzungsbedingungen) (EXPOSUREAPP-2951) (#1285)
      
      * updated eula
      
      * updated tr & en eula with german
      
      * Interoperability: Changes to Data Privacy (EXPOSUREAPP-2954) (#1287)
      
      * Interoperability: Make Changes to User Consent Text (Key Upload) (EXPOSUREAPP-2942) (#1275)
      
      * 2942 - strings updated and added to new legal string file
      
      * removed tr strings, to fix circle ci error.
      
      * added translatable false
      
      * Follow up: Initital onboarding 3rd & 6th paragraph (EXPOSUREAPP-2920) (#1289)
      
      * updated & added strings
      
      * updated 6th paragraph
      
      * Legal Textchange: Cross Country Exposure Logging Screen (EXPOSUREAPP-2924) (#1279)
      
      * updated & added strings
      
      * text under countries added
      
      Co-authored-by: default avatarRituraj Sambherao <git.rituraj.sambherao@gmail.com>
      
      * Interoperability: Delta Onboarding (EXPOSUREAPP-2931, EXPOSUREAPP-2919) (#1277)
      
      * 2931 text update
      
      * move to legal text & update 2919
      
      * delta onboarding text changes for initial text
      
      Co-authored-by: default avatarOliver Zimmerman <oezimmerman@gmail.com>
      
      * Legal Textchange: Delta Interop Screen (EXPOSUREAPP-2919)  (#1294)
      
      * 2931 text update
      
      * delta onboarding text changes for initial text
      
      * Added new legal texts and navigation to terms.
      
      - adjused xml layout
      - added required strings
      - created navigation to legal terms in both nav graphs
      - created navigation in fragment
      
      * Update OnboardingDeltaInteroperabilityFragment.kt
      
      * Update OnboardingDeltaInteroperabilityFragment.kt
      
      Co-authored-by: default avatarLuka Harambasic <luka.harambasic@sap.com>
      
      * fixed wrong implementation regrading user consent in warn others
      
      Co-authored-by: default avatarharambasicluka <64483219+harambasicluka@users.noreply.github.com>
      Co-authored-by: default avatarRituraj Sambherao <git.rituraj.sambherao@gmail.com>
      Co-authored-by: default avatarOliver Zimmerman <oezimmerman@gmail.com>
      Co-authored-by: default avatarLuka Harambasic <luka.harambasic@sap.com>
      eb382edf
  15. Sep 30, 2020
  16. Sep 29, 2020
  17. Sep 28, 2020
    • AlexanderAlferov's avatar
      Interoperability: New Note on Data Processing (EXPOSUREAPP-2742) (#1224) · 76c7d361
      AlexanderAlferov authored
      * New note on interoperability
      
      * Set new note only for onboarding delta interoperability
      76c7d361
    • BMItter's avatar
      Interoperability: List of Countries can not be loaded for 1.5.x in new... · 4ed5be02
      BMItter authored
      Interoperability: List of Countries can not be loaded for 1.5.x in new onboarding / interop (EXPOSUREAPP-2744) (#1232)
      
      * interop nofetch riskdetails, corresponding layout and vector
      
      * updated res to new no country spec
      
      * nofetch fetch layouts
      
      * Create include_interoperability_old.xml
      
      * removed old stuff
      
      * fixed Fixed include_interop_participating_countries_fetch for 1.5.x
      
      * adjusted logic from old base to fit 1.5.x, Converted countryList to LiveData
      
      * showing fetch or no fetch view in include_interoperability.xml, use github name as author
      
      * cleanup & refactor, fixed layout switch issue, wip
      
      * ids cleanup
      
      * system settings delegation according to design spec
      
      * improved countrylist handling for interopConfig Connectivity Settings
      
      * updated string translation tags
      
      * satisfy lint
      
      * satisfy CircleCi
      
      * fixed wrong layout visibility
      
      * delta test disabled, referenced ids adjusted
      
      * FormatHelper as requested
      
      * fix capital letter
      4ed5be02
    • BMItter's avatar
      Encounter with low risk missing link in risk details (EXPOSUREAPP-2883) (#1243) · 54eb8363
      BMItter authored
      
      * updated risk details information body with new text and link (please check twice the text)
      
      * Revert "updated risk details information body with new text and link (please check twice the text)"
      
      This reverts commit 917fdc5715eeb9334dd98be24f522b185adf1cdd.
      
      * missing link fixed for low exposure state risk details (draft)
      
      * fixed link
      
      * testable version for fixed link (on low exposure state)
      
      * Fix not clickable link (#2883)
      
      * fixed herlink convert input reference
      
      * provide default link for encounter but green
      
      * removed testcode for checking low risk exposure state
      
      Co-authored-by: default avatarMert Safter <mert.safter@sap.com>
      54eb8363
  18. Sep 24, 2020
  19. Sep 23, 2020
    • Mert Safter's avatar
      Interoperability Onboarding and Information (EXPOSUREAPP-2730, EXPOSUREAPP-2733) (#1202) · f85da39e
      Mert Safter authored
      
      * Import flag assets. Create init CountrySelectionList and Fragment
      
      * Implement missing components. Create ViewModel and Repository for Interop
      
      * fix wrong property usage
      
      * Implement storage of selected countries
      
      * Implement warn dialog
      
      * Added navigation from country selection to tracing fragment
      
      * Fixed lint errors
      
      * Fix typo and build error
      
      * Move navigation out of onResume
      
      * Implement Warning dialog and do some code cleanup
      
      * Begin of onboarding for Interoperability. Fix linting issues
      
      * Implement onboarding for Interoperability (#1976)
      
      * Implement skip path of interop screen in onboarding (#1976)
      
      * Implement navigation logic for onBoarding (#1976)
      
      * Fix linting issues
      
      * Adjust country list and view to new UI (#2667)
      
      * Merge OnboardingTracingFragment with country list (#2665)
      
      * UI adjustments (#2665)
      
      * Fix linting issues
      
      * Implement Delta Onboarding logic (#2665)
      
      * Adjust interoperability screens to new UI (#2730, #2733)
      
      * Added navigation from country selection to tracing fragment
      
      * Fix merge issues with interoperability branch
      
      * Fix merge issues with interoperability branch
      
      * Fix merge changes with 1.5.x branch
      
      * Remove unused Formatter
      
      * Remove import of unused Formatter
      
      * Remove import of unused Formatter
      
      * Fix linting issue
      
      * Adjust UI to mock changes (#2730)
      
      * Adjust fragment binding to new solution and code cleanup
      
      * Adjust layout ids to guidelines. Comment strings.xml
      
      * Moved back navigation event to ViewModel
      
      * Move to DI and ViewModel navigation
      
      * Improve accessibility
      
      * Improve accessibility
      
      * Adjusted UI to updated mockups. Clean-Up of InteroperabilityRepository and LocalData
      
      * Refactoring and ViewModel use.
      
      * Make detekt happy.
      
      * Fix PR comments, typos, inline getString.
      
      * Fix refactoring typo
      
      Co-authored-by: default avatarAlexandru.Paulescu <alexandru.paulescu@sap.com>
      Co-authored-by: default avatarMatthias Urhahn <matthias.urhahn@sap.com>
      Co-authored-by: default avatarMatthias Urhahn <darken@darken.eu>
      f85da39e
    • chris-cwa's avatar
      Texts for interoperability user consent (EXPOSUREAPP-2750) (#1194) · ffa04ffa
      chris-cwa authored
      
      * texts for interop user consent
      
      * default values
      
      Co-authored-by: default avatarharambasicluka <64483219+harambasicluka@users.noreply.github.com>
      ffa04ffa
  20. Sep 22, 2020
Loading